qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Tomita Moeko <tomitamoeko@gmail.com>
To: "Alex Williamson" <alex.williamson@redhat.com>,
	"Cédric Le Goater" <clg@redhat.com>
Cc: qemu-devel@nongnu.org, "Corvin Köhne" <c.koehne@beckhoff.com>,
	"Tomita Moeko" <tomitamoeko@gmail.com>
Subject: [PATCH v3 0/9] vfio/igd: Detect IGD by OpRegion and enable OpRegion automatically
Date: Tue,  6 May 2025 01:02:56 +0800	[thread overview]
Message-ID: <20250505170305.23622-1-tomitamoeko@gmail.com> (raw)

As proposed in a previous discussion [1], detect IGD devices based on
whether it has VFIO_REGION_SUBTYPE_INTEL_IGD_OPREGION exposed by kernel
and enables OpRegion access by default. This enables out-of-the-box
display output support for IGD passthrough without having to manually
set x-igd-opregion=on, which probably saves effort for libvirt users.

This patchset also limits legacy mode to Gen6-9 devices, as Intel no
longer provides CSM support and VBIOS on newer IGD, and Seabios does not
support setting up the 64 bit BDSM register on Gen 11+ devices. Exposing
VGA ranges to guests by default on platforms without VGA mode support is
undesirable.

Additionally, as we enables OpRegion on IGD devices by default, and
Intel removes the BDSM register from Meteor Lake [2]. There seems to be
no extra register quirks rather than OpRegion required on newer devices.
To support them (and probably future devices), the generation limit is
removed, with BDSM quirk only applied to known Gen 6-12 devices. 

Note: I have not been able to test this on Meteor Lake or newer
platforms due to lack of hardware.


[1] https://lore.kernel.org/qemu-devel/20250325172239.27926-1-tomitamoeko@gmail.com
[2] https://edc.intel.com/content/www/us/en/design/publications/14th-generation-core-processors-cfg-and-mem-registers/d2-f0-processor-graphics-registers/


Changelog:
v3:
* Addressed a nit in patch #8
Link: https://lore.kernel.org/qemu-devel/20250428161004.35613-1-tomitamoeko@gmail.com
v2:
* Removed "Allow hotplugging with OpRegion enabled", hotplugging is
  always forbidden.
* Test device is not hotplugged and get opregion in a single function.
* Update documentation along with code changes.
* Minor code style fixes.
Link: https://lore.kernel.org/qemu-devel/20250421163112.21316-1-tomitamoeko@gmail.com


Tomita Moeko (9):
  vfio/igd: Restrict legacy mode to Gen6-9 devices
  vfio/igd: Always emulate ASLS (OpRegion) register
  vfio/igd: Detect IGD device by OpRegion
  vfio/igd: Check vendor and device ID on GVT-g mdev
  vfio/igd: Check OpRegion support on GVT-g mdev
  vfio/igd: Enable OpRegion by default
  vfio/igd: Allow overriding GMS with 0xf0 to 0xfe on Gen9+
  vfio/igd: Only emulate GGC register when x-igd-gms is set
  vfio/igd: Remove generation limitation for IGD passthrough

 docs/igd-assign.txt |  11 ++-
 hw/vfio/igd.c       | 220 ++++++++++++++++++++++++++------------------
 hw/vfio/pci.c       |   2 +-
 3 files changed, 138 insertions(+), 95 deletions(-)

-- 
2.47.2



             reply	other threads:[~2025-05-05 17:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-05 17:02 Tomita Moeko [this message]
2025-05-05 17:02 ` [PATCH v3 1/9] vfio/igd: Restrict legacy mode to Gen6-9 devices Tomita Moeko
2025-05-05 17:02 ` [PATCH v3 2/9] vfio/igd: Always emulate ASLS (OpRegion) register Tomita Moeko
2025-05-05 17:02 ` [PATCH v3 3/9] vfio/igd: Detect IGD device by OpRegion Tomita Moeko
2025-05-05 17:03 ` [PATCH v3 4/9] vfio/igd: Check vendor and device ID on GVT-g mdev Tomita Moeko
2025-05-05 17:03 ` [PATCH v3 5/9] vfio/igd: Check OpRegion support " Tomita Moeko
2025-05-05 17:03 ` [PATCH v3 6/9] vfio/igd: Enable OpRegion by default Tomita Moeko
2025-05-05 17:03 ` [PATCH v3 7/9] vfio/igd: Allow overriding GMS with 0xf0 to 0xfe on Gen9+ Tomita Moeko
2025-05-05 17:03 ` [PATCH v3 8/9] vfio/igd: Only emulate GGC register when x-igd-gms is set Tomita Moeko
2025-05-05 17:03 ` [PATCH v3 9/9] vfio/igd: Remove generation limitation for IGD passthrough Tomita Moeko
2025-05-05 20:58 ` [PATCH v3 0/9] vfio/igd: Detect IGD by OpRegion and enable OpRegion automatically Cédric Le Goater
2025-05-06  6:58 ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250505170305.23622-1-tomitamoeko@gmail.com \
    --to=tomitamoeko@gmail.com \
    --cc=alex.williamson@redhat.com \
    --cc=c.koehne@beckhoff.com \
    --cc=clg@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).