From: Tomita Moeko <tomitamoeko@gmail.com>
To: "Alex Williamson" <alex.williamson@redhat.com>,
"Cédric Le Goater" <clg@redhat.com>,
"Tomita Moeko" <tomitamoeko@gmail.com>
Cc: qemu-devel@nongnu.org, "Corvin Köhne" <c.koehne@beckhoff.com>
Subject: [PATCH v3 5/9] vfio/igd: Check OpRegion support on GVT-g mdev
Date: Tue, 6 May 2025 01:03:01 +0800 [thread overview]
Message-ID: <20250505170305.23622-6-tomitamoeko@gmail.com> (raw)
In-Reply-To: <20250505170305.23622-1-tomitamoeko@gmail.com>
The Intel GVT-g backend `kvmgt` always emulates OpRegion for vGPU,
make sure the OpRegion is present for enabling access to it
automatically later.
Also, hotplugging GVT-g vGPU is now always disallowed regardless of
OpRegion to prevent potential issues. Intel has never claimed support
for GVT-g hotplugging.
Signed-off-by: Tomita Moeko <tomitamoeko@gmail.com>
---
hw/vfio/igd.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
index f5dd475028..9dec32818c 100644
--- a/hw/vfio/igd.c
+++ b/hw/vfio/igd.c
@@ -685,9 +685,13 @@ static bool vfio_pci_kvmgt_config_quirk(VFIOPCIDevice *vdev, Error **errp)
return true;
}
+ if (!vfio_pci_igd_opregion_detect(vdev, &opregion, errp)) {
+ /* Should never reach here, KVMGT always emulates OpRegion */
+ return false;
+ }
+
if ((vdev->features & VFIO_FEATURE_ENABLE_IGD_OPREGION) &&
- (!vfio_pci_igd_opregion_detect(vdev, &opregion, errp) ||
- !vfio_pci_igd_opregion_init(vdev, opregion, errp))) {
+ !vfio_pci_igd_opregion_init(vdev, opregion, errp)) {
return false;
}
--
2.47.2
next prev parent reply other threads:[~2025-05-05 17:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 17:02 [PATCH v3 0/9] vfio/igd: Detect IGD by OpRegion and enable OpRegion automatically Tomita Moeko
2025-05-05 17:02 ` [PATCH v3 1/9] vfio/igd: Restrict legacy mode to Gen6-9 devices Tomita Moeko
2025-05-05 17:02 ` [PATCH v3 2/9] vfio/igd: Always emulate ASLS (OpRegion) register Tomita Moeko
2025-05-05 17:02 ` [PATCH v3 3/9] vfio/igd: Detect IGD device by OpRegion Tomita Moeko
2025-05-05 17:03 ` [PATCH v3 4/9] vfio/igd: Check vendor and device ID on GVT-g mdev Tomita Moeko
2025-05-05 17:03 ` Tomita Moeko [this message]
2025-05-05 17:03 ` [PATCH v3 6/9] vfio/igd: Enable OpRegion by default Tomita Moeko
2025-05-05 17:03 ` [PATCH v3 7/9] vfio/igd: Allow overriding GMS with 0xf0 to 0xfe on Gen9+ Tomita Moeko
2025-05-05 17:03 ` [PATCH v3 8/9] vfio/igd: Only emulate GGC register when x-igd-gms is set Tomita Moeko
2025-05-05 17:03 ` [PATCH v3 9/9] vfio/igd: Remove generation limitation for IGD passthrough Tomita Moeko
2025-05-05 20:58 ` [PATCH v3 0/9] vfio/igd: Detect IGD by OpRegion and enable OpRegion automatically Cédric Le Goater
2025-05-06 6:58 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505170305.23622-6-tomitamoeko@gmail.com \
--to=tomitamoeko@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=c.koehne@beckhoff.com \
--cc=clg@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).