qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Steve Sistare" <steven.sistare@oracle.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 02/22] qom: Factor qom_resolve_path() out
Date: Tue,  6 May 2025 16:34:51 +0200	[thread overview]
Message-ID: <20250506143512.4315-3-philmd@linaro.org> (raw)
In-Reply-To: <20250506143512.4315-1-philmd@linaro.org>

From: Steve Sistare <steven.sistare@oracle.com>

Factor out a helper to resolve the user's path and print error messages.
No functional change.

Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <1741036202-265696-2-git-send-email-steven.sistare@oracle.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 qom/qom-qmp-cmds.c | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/qom/qom-qmp-cmds.c b/qom/qom-qmp-cmds.c
index e8665476182..293755f409e 100644
--- a/qom/qom-qmp-cmds.c
+++ b/qom/qom-qmp-cmds.c
@@ -28,15 +28,11 @@
 #include "qom/object_interfaces.h"
 #include "qom/qom-qobject.h"
 
-ObjectPropertyInfoList *qmp_qom_list(const char *path, Error **errp)
+static Object *qom_resolve_path(const char *path, Error **errp)
 {
-    Object *obj;
     bool ambiguous = false;
-    ObjectPropertyInfoList *props = NULL;
-    ObjectProperty *prop;
-    ObjectPropertyIterator iter;
+    Object *obj = object_resolve_path(path, &ambiguous);
 
-    obj = object_resolve_path(path, &ambiguous);
     if (obj == NULL) {
         if (ambiguous) {
             error_setg(errp, "Path '%s' is ambiguous", path);
@@ -44,6 +40,19 @@ ObjectPropertyInfoList *qmp_qom_list(const char *path, Error **errp)
             error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
                       "Device '%s' not found", path);
         }
+    }
+    return obj;
+}
+
+ObjectPropertyInfoList *qmp_qom_list(const char *path, Error **errp)
+{
+    Object *obj;
+    ObjectPropertyInfoList *props = NULL;
+    ObjectProperty *prop;
+    ObjectPropertyIterator iter;
+
+    obj = qom_resolve_path(path, errp);
+    if (obj == NULL) {
         return NULL;
     }
 
-- 
2.47.1



  parent reply	other threads:[~2025-05-06 14:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-06 14:34 [PULL 00/22] Misc HW patches for 2025-05-06 Philippe Mathieu-Daudé
2025-05-06 14:34 ` [PULL 01/22] bsd-user: add option to enable plugins Philippe Mathieu-Daudé
2025-05-06 14:34 ` Philippe Mathieu-Daudé [this message]
2025-05-06 14:34 ` [PULL 03/22] qom/object: Fix typo in comment Philippe Mathieu-Daudé
2025-05-06 14:34 ` [PULL 04/22] target/migration: Inline VMSTATE_CPU() Philippe Mathieu-Daudé
2025-05-06 14:34 ` [PULL 05/22] target/i386/hvf: Include missing 'exec/target_page.h' header Philippe Mathieu-Daudé
2025-05-07  6:35   ` Wei Liu
2025-05-07 11:20     ` Philippe Mathieu-Daudé
2025-05-08  1:09       ` Wei Liu
2025-05-06 14:34 ` [PULL 06/22] system/hvf: Avoid including 'cpu.h' Philippe Mathieu-Daudé
2025-05-06 14:34 ` [PULL 07/22] system/hvf: Expose hvf_enabled() to common code Philippe Mathieu-Daudé
2025-05-06 14:34 ` [PULL 08/22] hw/hyperv/hv-balloon-stub: common compilation unit Philippe Mathieu-Daudé
2025-05-06 14:34 ` [PULL 09/22] hw/hyperv/hyperv.h: header cleanup Philippe Mathieu-Daudé
2025-05-06 14:34 ` [PULL 10/22] hw/hyperv/vmbus: common compilation unit Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 11/22] hw/hyperv/syndbg: " Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 12/22] hw/hyperv/balloon: common balloon compilation units Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 13/22] hw/hyperv/hyperv_testdev: common compilation unit Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 14/22] hw/hyperv/hyperv: " Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 15/22] hw/core/machine: Fix indentation Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 16/22] hw/pci/pcie_port: Fix pcie_slot_is_hotpluggbale_bus typo Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 17/22] hw/acpi/ged: Fix wrong identation Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 18/22] hw/i386/acpi-build: Fix build_append_notfication_callback typo Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 19/22] hw/i386/acpi-build: Update document reference Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 20/22] hw/i386/acpi-build: Fix typo and grammar in comment Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 21/22] hw/acpi/pcihp: Fix typo in function name Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 22/22] hw/isa/ich9: Remove stray empty comment Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250506143512.4315-3-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=steven.sistare@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).