qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Wei Liu" <wei.liu@kernel.org>
Subject: [PULL 05/22] target/i386/hvf: Include missing 'exec/target_page.h' header
Date: Tue,  6 May 2025 16:34:54 +0200	[thread overview]
Message-ID: <20250506143512.4315-6-philmd@linaro.org> (raw)
In-Reply-To: <20250506143512.4315-1-philmd@linaro.org>

Include "exec/target_page.h" to be able to compile HVF on x86_64:

  ../target/i386/hvf/hvf.c:139:49: error: use of undeclared identifier 'TARGET_PAGE_SIZE'
              uint64_t dirty_page_start = gpa & ~(TARGET_PAGE_SIZE - 1u);
                                                ^
  ../target/i386/hvf/hvf.c:141:45: error: use of undeclared identifier 'TARGET_PAGE_SIZE'
              hv_vm_protect(dirty_page_start, TARGET_PAGE_SIZE,

Fixes: 9c2ff9cdc9b ("exec/cpu-all: remove exec/target_page include")
Reported-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reported-by: Wei Liu <wei.liu@kernel.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20250425174310.70890-1-philmd@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 target/i386/hvf/hvf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c
index 99e37a33e50..b16fb066758 100644
--- a/target/i386/hvf/hvf.c
+++ b/target/i386/hvf/hvf.c
@@ -50,6 +50,7 @@
 #include "qemu/error-report.h"
 #include "qemu/memalign.h"
 #include "qapi/error.h"
+#include "exec/target_page.h"
 #include "migration/blocker.h"
 
 #include "system/hvf.h"
-- 
2.47.1



  parent reply	other threads:[~2025-05-06 14:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-06 14:34 [PULL 00/22] Misc HW patches for 2025-05-06 Philippe Mathieu-Daudé
2025-05-06 14:34 ` [PULL 01/22] bsd-user: add option to enable plugins Philippe Mathieu-Daudé
2025-05-06 14:34 ` [PULL 02/22] qom: Factor qom_resolve_path() out Philippe Mathieu-Daudé
2025-05-06 14:34 ` [PULL 03/22] qom/object: Fix typo in comment Philippe Mathieu-Daudé
2025-05-06 14:34 ` [PULL 04/22] target/migration: Inline VMSTATE_CPU() Philippe Mathieu-Daudé
2025-05-06 14:34 ` Philippe Mathieu-Daudé [this message]
2025-05-07  6:35   ` [PULL 05/22] target/i386/hvf: Include missing 'exec/target_page.h' header Wei Liu
2025-05-07 11:20     ` Philippe Mathieu-Daudé
2025-05-08  1:09       ` Wei Liu
2025-05-06 14:34 ` [PULL 06/22] system/hvf: Avoid including 'cpu.h' Philippe Mathieu-Daudé
2025-05-06 14:34 ` [PULL 07/22] system/hvf: Expose hvf_enabled() to common code Philippe Mathieu-Daudé
2025-05-06 14:34 ` [PULL 08/22] hw/hyperv/hv-balloon-stub: common compilation unit Philippe Mathieu-Daudé
2025-05-06 14:34 ` [PULL 09/22] hw/hyperv/hyperv.h: header cleanup Philippe Mathieu-Daudé
2025-05-06 14:34 ` [PULL 10/22] hw/hyperv/vmbus: common compilation unit Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 11/22] hw/hyperv/syndbg: " Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 12/22] hw/hyperv/balloon: common balloon compilation units Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 13/22] hw/hyperv/hyperv_testdev: common compilation unit Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 14/22] hw/hyperv/hyperv: " Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 15/22] hw/core/machine: Fix indentation Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 16/22] hw/pci/pcie_port: Fix pcie_slot_is_hotpluggbale_bus typo Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 17/22] hw/acpi/ged: Fix wrong identation Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 18/22] hw/i386/acpi-build: Fix build_append_notfication_callback typo Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 19/22] hw/i386/acpi-build: Update document reference Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 20/22] hw/i386/acpi-build: Fix typo and grammar in comment Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 21/22] hw/acpi/pcihp: Fix typo in function name Philippe Mathieu-Daudé
2025-05-06 14:35 ` [PULL 22/22] hw/isa/ich9: Remove stray empty comment Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250506143512.4315-6-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).