qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Subject: [PULL 16/30] target/arm/helper.c: Fix type conflict of GLib function pointers
Date: Tue,  6 May 2025 17:29:11 +0200	[thread overview]
Message-ID: <20250506152927.222671-17-pbonzini@redhat.com> (raw)
In-Reply-To: <20250506152927.222671-1-pbonzini@redhat.com>

From: Kohei Tokunaga <ktokunaga.mail@gmail.com>

On Emscripten, function pointer casts can result in runtime failures due to
strict function signature checks. This affects the use of g_list_sort and
g_slist_sort, which internally perform function pointer casts that are not
supported by Emscripten. To avoid these issues, g_list_sort_with_data and
g_slist_sort_with_data should be used instead, as they do not rely on
function pointer casting.

Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Link: https://lore.kernel.org/r/7d56c82382e8b4f1694b6d7883b2ce3084fdc72d.1745820062.git.ktokunaga.mail@gmail.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 target/arm/helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index 7fb6e886306..c7ff9f657ca 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -222,7 +222,7 @@ static void count_cpreg(gpointer key, gpointer opaque)
     }
 }
 
-static gint cpreg_key_compare(gconstpointer a, gconstpointer b)
+static gint cpreg_key_compare(gconstpointer a, gconstpointer b, gpointer d)
 {
     uint64_t aidx = cpreg_to_kvm_id((uintptr_t)a);
     uint64_t bidx = cpreg_to_kvm_id((uintptr_t)b);
@@ -246,7 +246,7 @@ void init_cpreg_list(ARMCPU *cpu)
     int arraylen;
 
     keys = g_hash_table_get_keys(cpu->cp_regs);
-    keys = g_list_sort(keys, cpreg_key_compare);
+    keys = g_list_sort_with_data(keys, cpreg_key_compare, NULL);
 
     cpu->cpreg_array_len = 0;
 
-- 
2.49.0



  parent reply	other threads:[~2025-05-06 15:31 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-06 15:28 [PULL 00/30] Rust, wasm changes for 2025-05-06 Paolo Bonzini
2025-05-06 15:28 ` [PULL 01/30] lcitool: use newer Rust for Debian and Ubuntu Paolo Bonzini
2025-09-03 13:54   ` Marc-André Lureau
2025-09-03 13:59     ` Paolo Bonzini
2025-09-04 19:38       ` Marc-André Lureau
2025-09-05  5:16         ` Paolo Bonzini
2025-09-05  5:17           ` Paolo Bonzini
2025-09-05 12:06         ` Alex Bennée
2025-05-06 15:28 ` [PULL 02/30] meson, cargo: require Rust 1.77.0 Paolo Bonzini
2025-05-06 15:28 ` [PULL 03/30] rust: use std::ffi instead of std::os::raw Paolo Bonzini
2025-05-06 15:28 ` [PULL 04/30] rust: let bilge use "let ... else" Paolo Bonzini
2025-05-06 15:29 ` [PULL 05/30] rust: qemu_api_macros: make pattern matching more readable and efficient Paolo Bonzini
2025-05-06 15:29 ` [PULL 06/30] rust: use MaybeUninit::zeroed() in const context Paolo Bonzini
2025-05-06 15:29 ` [PULL 07/30] rust: qom: fix TODO about zeroability of classes Paolo Bonzini
2025-05-06 15:29 ` [PULL 08/30] rust: enable clippy::ptr_cast_constness Paolo Bonzini
2025-05-06 15:29 ` [PULL 09/30] rust: remove offset_of replacement Paolo Bonzini
2025-05-06 15:29 ` [PULL 10/30] rust: replace c_str! with c"" literals Paolo Bonzini
2025-05-06 15:29 ` [PULL 11/30] docs: rust: update for newer minimum supported version Paolo Bonzini
2025-05-06 15:29 ` [PULL 12/30] target/i386/emulate: fix target_ulong format strings Paolo Bonzini
2025-05-06 15:29 ` [PULL 13/30] rust: clippy: enable uninlined_format_args lint Paolo Bonzini
2025-05-06 15:29 ` [PULL 14/30] ci: run RISC-V cross jobs by default Paolo Bonzini
2025-05-06 15:29 ` [PULL 15/30] docs: build-system: fix typo Paolo Bonzini
2025-05-06 15:29 ` Paolo Bonzini [this message]
2025-05-06 15:29 ` [PULL 17/30] target/i386/cpu.c: Fix type conflict of GLib function pointers Paolo Bonzini
2025-05-06 15:29 ` [PULL 18/30] target/ppc: " Paolo Bonzini
2025-05-06 15:29 ` [PULL 19/30] target/s390x: " Paolo Bonzini
2025-05-06 15:29 ` [PULL 20/30] include/glib-compat.h: Poison g_list_sort and g_slist_sort Paolo Bonzini
2025-05-06 15:29 ` [PULL 21/30] util/cacheflush.c: Update cache flushing mechanism for Emscripten Paolo Bonzini
2025-05-06 15:29 ` [PULL 22/30] block: Add including of ioctl header for Emscripten build Paolo Bonzini
2025-05-06 15:29 ` [PULL 23/30] block: Fix type conflict of the copy_file_range stub Paolo Bonzini
2025-05-06 15:29 ` [PULL 24/30] include/qemu/osdep.h: Add Emscripten-specific OS dependencies Paolo Bonzini
2025-05-06 15:29 ` [PULL 25/30] Disable options unsupported on Emscripten Paolo Bonzini
2025-05-06 15:29 ` [PULL 26/30] util: exclude mmap-alloc.c from compilation target " Paolo Bonzini
2025-05-06 15:29 ` [PULL 27/30] util: Add coroutine backend for emscripten Paolo Bonzini
2025-05-06 15:29 ` [PULL 28/30] meson: Add wasm build in build scripts Paolo Bonzini
2025-05-06 15:29 ` [PULL 29/30] tests: Add Dockerfile containing dependencies for Emscripten build Paolo Bonzini
2025-05-06 15:29 ` [PULL 30/30] gitlab: Enable CI for wasm build Paolo Bonzini
2025-05-08 14:26 ` [PULL 00/30] Rust, wasm changes for 2025-05-06 Stefan Hajnoczi
2025-05-08 16:08   ` Paolo Bonzini
2025-05-08 16:53     ` Stefan Hajnoczi
2025-05-08 17:05     ` Thomas Huth
2025-05-08 17:15       ` Paolo Bonzini
2025-05-09 14:11 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250506152927.222671-17-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ktokunaga.mail@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).