qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Nabih Estefan <nabihestefan@google.com>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, pbonzini@redhat.com,
	armbru@redhat.com,  Peter Foley <pefoley@google.com>,
	Nabih Estefan <nabihestefan@google.com>
Subject: [PATCH 1/2] util: fix msan findings in keyval
Date: Thu,  8 May 2025 22:21:31 +0000	[thread overview]
Message-ID: <20250508222132.748479-2-nabihestefan@google.com> (raw)
In-Reply-To: <20250508222132.748479-1-nabihestefan@google.com>

From: Peter Foley <pefoley@google.com>

e.g.
I	2025-02-28 09:51:05.240071-0800		624	stream.go:47	qemu: Uninitialized value was created by an allocation of 'key_in_cur.i' in the stack frame
I	2025-02-28 09:51:05.240187-0800		624	stream.go:47	qemu: #0 0xaaaac49f489c in keyval_parse_one third_party/qemu/util/keyval.c:190:5

Signed-off-by: Peter Foley <pefoley@google.com>
Signed-off-by: Nabih Estefan <nabihestefan@google.com>
---
 util/keyval.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/keyval.c b/util/keyval.c
index a70629a481..f33c64079d 100644
--- a/util/keyval.c
+++ b/util/keyval.c
@@ -187,7 +187,7 @@ static const char *keyval_parse_one(QDict *qdict, const char *params,
 {
     const char *key, *key_end, *val_end, *s, *end;
     size_t len;
-    char key_in_cur[128];
+    char key_in_cur[128] = {};
     QDict *cur;
     int ret;
     QObject *next;
-- 
2.49.0.1015.ga840276032-goog



  reply	other threads:[~2025-05-08 22:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-08 22:21 [PATCH 0/2] Miscellaneous MSan finding Nabih Estefan
2025-05-08 22:21 ` Nabih Estefan [this message]
2025-05-09  5:48   ` [PATCH 1/2] util: fix msan findings in keyval Markus Armbruster
2025-05-09  7:58     ` Daniel P. Berrangé
2025-05-09  8:57       ` Markus Armbruster
2025-05-28  7:55       ` Paolo Bonzini
2025-05-08 22:21 ` [PATCH 2/2] accel/tcg: fix msan findings in translate-all Nabih Estefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250508222132.748479-2-nabihestefan@google.com \
    --to=nabihestefan@google.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pefoley@google.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).