From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A86F4C3ABBC for ; Fri, 9 May 2025 15:36:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uDPlD-0002Tq-JU; Fri, 09 May 2025 11:35:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uDPl4-0002Sx-Ft for qemu-devel@nongnu.org; Fri, 09 May 2025 11:35:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uDPl2-00012Y-Ui for qemu-devel@nongnu.org; Fri, 09 May 2025 11:35:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746804927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KvgodsRX5jVPKQKXhLVAtbiUkGwGclYVHGBsI+/pme4=; b=BH9tFoDGaFrunAID6O6BTPLSqPs+CCyqTj845wdWegkQt8da1FW0m9h86Ij5g20efkkLPC cV1C72iXKFDefVFT/QcctK5Prb/mf/++lpBTnISBmN+2QsHd7HkFPMifMmpKZVeHWGKa+/ 91e/FNIbcp/3P5VhkGjjgMP0c5PKN2o= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-86POYYFxPbSWD-YoNlikng-1; Fri, 09 May 2025 11:35:24 -0400 X-MC-Unique: 86POYYFxPbSWD-YoNlikng-1 X-Mimecast-MFC-AGG-ID: 86POYYFxPbSWD-YoNlikng_1746804923 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43d0830c3f7so14952015e9.2 for ; Fri, 09 May 2025 08:35:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746804923; x=1747409723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KvgodsRX5jVPKQKXhLVAtbiUkGwGclYVHGBsI+/pme4=; b=CQdi6PG8aAWJfDJznhltJPCZ66Eqr/1Jjr3qnc9v/BPbs6nZKqofJUuXpeJwI1kR7C 7792hBBr8S7Lxv6woSH6fAVYQyHomABIXy8KhqleAiiXgk8YWTyAjVAJznq2abpJ6jjg 24ZF6b0X26dZjO5b/W78kKWDl6L92Ovj5G0Z8Fysvcs7GzgA13yp4qs6+fb4LiYjuRRj 9r3jyjXDzVqL9HbGN0Bu8Ry7lBtzvx91BDMu3JmYmdMmW1skwsHXlyS8kOhBxYF+Aoji WfgWm+il1TWdzJHrNZOU0Yyb+O4sPhH9K1ONqGe4f9WCvo348MO1TLk9aHL5tBwL/fja xGFA== X-Gm-Message-State: AOJu0YzSggs6ih4BroxnFYXxXnNz3jH56wNYXB+KOkOMoXaG0y2LxCbA d4TLhV0+1nMnrDEzQSVA+uIX7OamfkoKb862G7HlnG8zYLBXGWDO5XHo/uLhSj/sAJc0vcQntB0 AmyhPFs4KYmcviOVij0UypEYaov4fyOqNp1n8Qlwskss5oyFFm1Bl X-Gm-Gg: ASbGncsXB6CP+/GbqFKwQ/lUUJI8lNuNcHJOFuY1P484nvBnQBqsZlY+W4ziXiXTmvA URvFgbfemh9pjghlGYxZeOiboFkIVZSjxf25pJPG71RsVx1hfnpjFcougCxXOfmzDknUoDggNDz 7usDrqsl5Bt2HB2tlH2duwv1KpjIejKTUAXQfafWM8+8YPxQdnuPtRn39tyIotz2GhMRTYLXMqR mDIT6+Ny9d14vyPdhu26W+qrk+Z+zX1T9RnfX4CYz3Y/cueRBByt3fidhQXBmF/2h+/SKP/TFvK eiAQG7o+M9Fv4e9yRdw4IOQUl336DkYm X-Received: by 2002:a05:600c:1d8c:b0:43c:fe85:e4ba with SMTP id 5b1f17b1804b1-442d6d6477amr38265155e9.15.1746804923098; Fri, 09 May 2025 08:35:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGNyAfppT9uee9ogVYiyR4nXpot/QB0mvHEteKSSPEKtPIA4s/28JMxoH1SBEhBGoRPk3h89g== X-Received: by 2002:a05:600c:1d8c:b0:43c:fe85:e4ba with SMTP id 5b1f17b1804b1-442d6d6477amr38264785e9.15.1746804922673; Fri, 09 May 2025 08:35:22 -0700 (PDT) Received: from imammedo.users.ipa.redhat.com ([85.93.96.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442cd32f1eesm76794905e9.9.2025.05.09.08.35.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 May 2025 08:35:22 -0700 (PDT) Date: Fri, 9 May 2025 17:35:19 +0200 From: Igor Mammedov To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: qemu-devel@nongnu.org, Richard Henderson , kvm@vger.kernel.org, Sergio Lopez , Gerd Hoffmann , Peter Maydell , Laurent Vivier , Jiaxun Yang , Yi Liu , "Michael S. Tsirkin" , Eduardo Habkost , Marcel Apfelbaum , Alistair Francis , Daniel Henrique Barboza , Marcelo Tosatti , qemu-riscv@nongnu.org, Weiwei Li , Amit Shah , Zhao Liu , Yanan Wang , Helge Deller , Palmer Dabbelt , Ani Sinha , Fabiano Rosas , Paolo Bonzini , Liu Zhiwei , =?UTF-8?B?Q2zDqW1lbnQ=?= Mathieu--Drif , qemu-arm@nongnu.org, =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Huacai Chen , Jason Wang Subject: Re: [PATCH v4 04/27] hw/mips/loongson3_virt: Prefer using fw_cfg_init_mem_nodma() Message-ID: <20250509173519.50d4f073@imammedo.users.ipa.redhat.com> In-Reply-To: <20250508133550.81391-5-philmd@linaro.org> References: <20250508133550.81391-1-philmd@linaro.org> <20250508133550.81391-5-philmd@linaro.org> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.129.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.413, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, 8 May 2025 15:35:27 +0200 Philippe Mathieu-Daud=C3=A9 wrote: > fw_cfg_init_mem_wide() is prefered to initialize fw_cfg > with DMA support. Without DMA, use fw_cfg_init_mem_nodma(). >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Igor Mammedov > --- > hw/mips/loongson3_virt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/mips/loongson3_virt.c b/hw/mips/loongson3_virt.c > index de6fbcc0cb4..654a2f0999f 100644 > --- a/hw/mips/loongson3_virt.c > +++ b/hw/mips/loongson3_virt.c > @@ -286,7 +286,7 @@ static void fw_conf_init(void) > FWCfgState *fw_cfg; > hwaddr cfg_addr =3D virt_memmap[VIRT_FW_CFG].base; > =20 > - fw_cfg =3D fw_cfg_init_mem_wide(cfg_addr, cfg_addr + 8, 8, 0, NULL); just a question, given it's a rather modern machine is there a reason why it is not using DMA here? > + fw_cfg =3D fw_cfg_init_mem_nodma(cfg_addr, cfg_addr + 8, 8); > fw_cfg_add_i16(fw_cfg, FW_CFG_NB_CPUS, (uint16_t)current_machine->sm= p.cpus); > fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS, (uint16_t)current_machine->s= mp.max_cpus); > fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, loaderparams.ram_size);