qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: laurent@vivier.eu, schwab@linux-m68k.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v6 12/24] target/m68k: Remove env argument to gen_lea_indexed
Date: Sun, 11 May 2025 13:35:34 -0700	[thread overview]
Message-ID: <20250511203546.139788-13-richard.henderson@linaro.org> (raw)
In-Reply-To: <20250511203546.139788-1-richard.henderson@linaro.org>

Use the env pointer in DisasContext.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/m68k/translate.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index c16925670d..1a589874db 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -392,7 +392,7 @@ static TCGv gen_addr_index(DisasContext *s, uint16_t ext, TCGv tmp)
  * Handle a base + index + displacement effective address.
  * A NULL_QREG base means pc-relative.
  */
-static TCGv gen_lea_indexed(CPUM68KState *env, DisasContext *s, TCGv base)
+static TCGv gen_lea_indexed(DisasContext *s, TCGv base)
 {
     uint32_t offset;
     uint16_t ext;
@@ -401,7 +401,7 @@ static TCGv gen_lea_indexed(CPUM68KState *env, DisasContext *s, TCGv base)
     uint32_t bd, od;
 
     offset = s->pc;
-    ext = read_im16(env, s);
+    ext = read_im16(s->env, s);
 
     if ((ext & 0x800) == 0 && !m68k_feature(s->env, M68K_FEATURE_WORD_INDEX))
         return NULL_QREG;
@@ -419,9 +419,9 @@ static TCGv gen_lea_indexed(CPUM68KState *env, DisasContext *s, TCGv base)
         if ((ext & 0x30) > 0x10) {
             /* base displacement */
             if ((ext & 0x30) == 0x20) {
-                bd = (int16_t)read_im16(env, s);
+                bd = (int16_t)read_im16(s->env, s);
             } else {
-                bd = read_im32(env, s);
+                bd = read_im32(s->env, s);
             }
         } else {
             bd = 0;
@@ -467,9 +467,9 @@ static TCGv gen_lea_indexed(CPUM68KState *env, DisasContext *s, TCGv base)
             if ((ext & 3) > 1) {
                 /* outer displacement */
                 if ((ext & 3) == 2) {
-                    od = (int16_t)read_im16(env, s);
+                    od = (int16_t)read_im16(s->env, s);
                 } else {
-                    od = read_im32(env, s);
+                    od = read_im32(s->env, s);
                 }
             } else {
                 od = 0;
@@ -738,7 +738,7 @@ static TCGv gen_lea_mode(CPUM68KState *env, DisasContext *s,
         return addr;
     case 6: /* Indirect index + displacement.  */
         reg = get_areg(s, reg0);
-        return gen_lea_indexed(env, s, reg);
+        return gen_lea_indexed(s, reg);
     case 7: /* Other */
         switch (reg0) {
         case 0: /* Absolute short.  */
@@ -752,7 +752,7 @@ static TCGv gen_lea_mode(CPUM68KState *env, DisasContext *s,
             offset += (int16_t)read_im16(env, s);
             break;
         case 3: /* pc index+displacement.  */
-            return gen_lea_indexed(env, s, NULL_QREG);
+            return gen_lea_indexed(s, NULL_QREG);
         case 4: /* Immediate.  */
         default:
             return NULL_QREG;
-- 
2.43.0



  parent reply	other threads:[~2025-05-11 20:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-11 20:35 [PATCH v6 00/24] target/m68k: fpu improvements Richard Henderson
2025-05-11 20:35 ` [PATCH v6 01/24] target/m68k: Add FPSR exception bit defines Richard Henderson
2025-05-11 20:35 ` [PATCH v6 02/24] target/m68k: Restore fp rounding mode on vm load Richard Henderson
2025-05-11 20:35 ` [PATCH v6 03/24] target/m68k: Keep FPSR up-to-date Richard Henderson
2025-05-11 20:35 ` [PATCH v6 04/24] target/m68k: Update FPSR.EXC Richard Henderson
2025-05-11 20:35 ` [PATCH v6 05/24] target/m68k: Update FPSR for FMOVECR Richard Henderson
2025-05-11 20:35 ` [PATCH v6 06/24] target/m68k: Introduce M68K_FEATURE_FPU_PACKED_DECIMAL Richard Henderson
2025-05-11 20:35 ` [PATCH v6 07/24] target/m68k: Merge gen_ea into SRC_EA and DEST_EA Richard Henderson
2025-05-11 20:35 ` [PATCH v6 08/24] target/m68k: Use g_assert_not_reached in gen_lea_mode and gen_ea_mode Richard Henderson
2025-05-11 20:35 ` [PATCH v6 09/24] target/m68k: Use OS_UNSIZED in LEA, PEA, JMP Richard Henderson
2025-05-12 14:23   ` Philippe Mathieu-Daudé
2025-05-11 20:35 ` [PATCH v6 10/24] target/m68k: Move pre-dec/post-inc to gen_lea_mode Richard Henderson
2025-05-11 20:35 ` [PATCH v6 11/24] target/m68k: Split gen_ea_mode for load/store Richard Henderson
2025-05-11 20:35 ` Richard Henderson [this message]
2025-05-11 20:35 ` [PATCH v6 13/24] target/m68k: Remove env argument to gen_lea_mode Richard Henderson
2025-05-11 20:35 ` [PATCH v6 14/24] target/m68k: Remove env argument to gen_load_mode Richard Henderson
2025-05-11 20:35 ` [PATCH v6 15/24] target/m68k: Remove env argument to gen_store_mode Richard Henderson
2025-05-11 20:35 ` [PATCH v6 16/24] target/m68k: Remove env argument to gen_ea_mode_fp Richard Henderson
2025-05-11 20:35 ` [PATCH v6 17/24] target/m68k: Split gen_ea_mode_fp for load/store Richard Henderson
2025-05-11 20:35 ` [PATCH v6 18/24] target/m68k: Move gen_addr_fault into gen_{load, store}_mode_fp Richard Henderson
2025-05-11 20:35 ` [PATCH v6 19/24] target/m68k: Merge gen_load_fp, gen_load_mode_fp Richard Henderson
2025-05-11 20:35 ` [PATCH v6 20/24] target/m68k: Merge gen_store_fp, gen_store_mode_fp Richard Henderson
2025-05-11 20:35 ` [PATCH v6 21/24] target/m68k: Implement packed decimal real loads and stores Richard Henderson
2025-05-11 20:35 ` [PATCH v6 22/24] tests/tcg/m68k: Add packed decimal tests Richard Henderson
2025-05-11 20:35 ` [PATCH v6 23/24] target/m68k: Make vmstate variables static Richard Henderson
2025-05-11 20:35 ` [PATCH v6 24/24] target/m68k: Implement FPIAR Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250511203546.139788-13-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).