qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: laurent@vivier.eu, schwab@linux-m68k.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v6 04/24] target/m68k: Update FPSR.EXC
Date: Sun, 11 May 2025 13:35:26 -0700	[thread overview]
Message-ID: <20250511203546.139788-5-richard.henderson@linaro.org> (raw)
In-Reply-To: <20250511203546.139788-1-richard.henderson@linaro.org>

So far we've only been updating the AEXC byte.
Update the EXC byte as well.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/m68k/fpu_helper.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/target/m68k/fpu_helper.c b/target/m68k/fpu_helper.c
index 195281f118..deae94b0ee 100644
--- a/target/m68k/fpu_helper.c
+++ b/target/m68k/fpu_helper.c
@@ -168,26 +168,28 @@ static void update_fpsr(CPUM68KState *env, int cc)
     uint32_t fpsr = env->fpsr;
     int flags = get_float_exception_flags(&env->fp_status);
 
-    fpsr &= ~FPSR_CC_MASK;
+    fpsr &= ~(FPSR_CC_MASK | FPSR_EXC_MASK);
     fpsr |= cc;
 
     if (flags) {
         set_float_exception_flags(0, &env->fp_status);
 
-        if (flags & float_flag_invalid) {
-            fpsr |= FPSR_AEXP_IOP;
+        if (flags & float_flag_invalid_snan) {
+            fpsr |= FPSR_EXC_SNAN | FPSR_AEXP_IOP;
+        } else if (flags & float_flag_invalid) {
+            fpsr |= FPSR_EXC_OPERR | FPSR_AEXP_IOP;
         }
         if (flags & float_flag_overflow) {
-            fpsr |= FPSR_AEXP_OVFL;
+            fpsr |= FPSR_EXC_OVFL | FPSR_AEXP_OVFL;
         }
         if (flags & (float_flag_underflow | float_flag_output_denormal_flushed)) {
-            fpsr |= FPSR_AEXP_UNFL;
+            fpsr |= FPSR_EXC_UNFL | FPSR_AEXP_UNFL;
         }
         if (flags & float_flag_divbyzero) {
-            fpsr |= FPSR_AEXP_DZ;
+            fpsr |= FPSR_EXC_DZ | FPSR_AEXP_DZ;
         }
         if (flags & float_flag_inexact) {
-            fpsr |= FPSR_AEXC_INEX;
+            fpsr |= FPSR_EXC_INEX2 | FPSR_AEXC_INEX;
         }
     }
     env->fpsr = fpsr;
-- 
2.43.0



  parent reply	other threads:[~2025-05-11 20:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-11 20:35 [PATCH v6 00/24] target/m68k: fpu improvements Richard Henderson
2025-05-11 20:35 ` [PATCH v6 01/24] target/m68k: Add FPSR exception bit defines Richard Henderson
2025-05-11 20:35 ` [PATCH v6 02/24] target/m68k: Restore fp rounding mode on vm load Richard Henderson
2025-05-11 20:35 ` [PATCH v6 03/24] target/m68k: Keep FPSR up-to-date Richard Henderson
2025-05-11 20:35 ` Richard Henderson [this message]
2025-05-11 20:35 ` [PATCH v6 05/24] target/m68k: Update FPSR for FMOVECR Richard Henderson
2025-05-11 20:35 ` [PATCH v6 06/24] target/m68k: Introduce M68K_FEATURE_FPU_PACKED_DECIMAL Richard Henderson
2025-05-11 20:35 ` [PATCH v6 07/24] target/m68k: Merge gen_ea into SRC_EA and DEST_EA Richard Henderson
2025-05-11 20:35 ` [PATCH v6 08/24] target/m68k: Use g_assert_not_reached in gen_lea_mode and gen_ea_mode Richard Henderson
2025-05-11 20:35 ` [PATCH v6 09/24] target/m68k: Use OS_UNSIZED in LEA, PEA, JMP Richard Henderson
2025-05-12 14:23   ` Philippe Mathieu-Daudé
2025-05-11 20:35 ` [PATCH v6 10/24] target/m68k: Move pre-dec/post-inc to gen_lea_mode Richard Henderson
2025-05-11 20:35 ` [PATCH v6 11/24] target/m68k: Split gen_ea_mode for load/store Richard Henderson
2025-05-11 20:35 ` [PATCH v6 12/24] target/m68k: Remove env argument to gen_lea_indexed Richard Henderson
2025-05-11 20:35 ` [PATCH v6 13/24] target/m68k: Remove env argument to gen_lea_mode Richard Henderson
2025-05-11 20:35 ` [PATCH v6 14/24] target/m68k: Remove env argument to gen_load_mode Richard Henderson
2025-05-11 20:35 ` [PATCH v6 15/24] target/m68k: Remove env argument to gen_store_mode Richard Henderson
2025-05-11 20:35 ` [PATCH v6 16/24] target/m68k: Remove env argument to gen_ea_mode_fp Richard Henderson
2025-05-11 20:35 ` [PATCH v6 17/24] target/m68k: Split gen_ea_mode_fp for load/store Richard Henderson
2025-05-11 20:35 ` [PATCH v6 18/24] target/m68k: Move gen_addr_fault into gen_{load, store}_mode_fp Richard Henderson
2025-05-11 20:35 ` [PATCH v6 19/24] target/m68k: Merge gen_load_fp, gen_load_mode_fp Richard Henderson
2025-05-11 20:35 ` [PATCH v6 20/24] target/m68k: Merge gen_store_fp, gen_store_mode_fp Richard Henderson
2025-05-11 20:35 ` [PATCH v6 21/24] target/m68k: Implement packed decimal real loads and stores Richard Henderson
2025-05-11 20:35 ` [PATCH v6 22/24] tests/tcg/m68k: Add packed decimal tests Richard Henderson
2025-05-11 20:35 ` [PATCH v6 23/24] target/m68k: Make vmstate variables static Richard Henderson
2025-05-11 20:35 ` [PATCH v6 24/24] target/m68k: Implement FPIAR Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250511203546.139788-5-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).