qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: laurent@vivier.eu, schwab@linux-m68k.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v6 08/24] target/m68k: Use g_assert_not_reached in gen_lea_mode and gen_ea_mode
Date: Sun, 11 May 2025 13:35:30 -0700	[thread overview]
Message-ID: <20250511203546.139788-9-richard.henderson@linaro.org> (raw)
In-Reply-To: <20250511203546.139788-1-richard.henderson@linaro.org>

The mode argument is extracted from 3 bits, and all cases are covered.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/m68k/translate.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index b9633e06da..f87eff3b10 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -768,8 +768,7 @@ static TCGv gen_lea_mode(CPUM68KState *env, DisasContext *s,
         tcg_gen_movi_i32(tmp, offset);
         return tmp;
     }
-    /* Should never happen.  */
-    return NULL_QREG;
+    g_assert_not_reached();
 }
 
 static TCGv gen_lea(CPUM68KState *env, DisasContext *s, uint16_t insn,
@@ -893,8 +892,7 @@ static TCGv gen_ea_mode(CPUM68KState *env, DisasContext *s, int mode, int reg0,
             return NULL_QREG;
         }
     }
-    /* Should never happen.  */
-    return NULL_QREG;
+    g_assert_not_reached();
 }
 
 static TCGv_ptr gen_fp_ptr(int freg)
-- 
2.43.0



  parent reply	other threads:[~2025-05-11 20:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-11 20:35 [PATCH v6 00/24] target/m68k: fpu improvements Richard Henderson
2025-05-11 20:35 ` [PATCH v6 01/24] target/m68k: Add FPSR exception bit defines Richard Henderson
2025-05-11 20:35 ` [PATCH v6 02/24] target/m68k: Restore fp rounding mode on vm load Richard Henderson
2025-05-11 20:35 ` [PATCH v6 03/24] target/m68k: Keep FPSR up-to-date Richard Henderson
2025-05-11 20:35 ` [PATCH v6 04/24] target/m68k: Update FPSR.EXC Richard Henderson
2025-05-11 20:35 ` [PATCH v6 05/24] target/m68k: Update FPSR for FMOVECR Richard Henderson
2025-05-11 20:35 ` [PATCH v6 06/24] target/m68k: Introduce M68K_FEATURE_FPU_PACKED_DECIMAL Richard Henderson
2025-05-11 20:35 ` [PATCH v6 07/24] target/m68k: Merge gen_ea into SRC_EA and DEST_EA Richard Henderson
2025-05-11 20:35 ` Richard Henderson [this message]
2025-05-11 20:35 ` [PATCH v6 09/24] target/m68k: Use OS_UNSIZED in LEA, PEA, JMP Richard Henderson
2025-05-12 14:23   ` Philippe Mathieu-Daudé
2025-05-11 20:35 ` [PATCH v6 10/24] target/m68k: Move pre-dec/post-inc to gen_lea_mode Richard Henderson
2025-05-11 20:35 ` [PATCH v6 11/24] target/m68k: Split gen_ea_mode for load/store Richard Henderson
2025-05-11 20:35 ` [PATCH v6 12/24] target/m68k: Remove env argument to gen_lea_indexed Richard Henderson
2025-05-11 20:35 ` [PATCH v6 13/24] target/m68k: Remove env argument to gen_lea_mode Richard Henderson
2025-05-11 20:35 ` [PATCH v6 14/24] target/m68k: Remove env argument to gen_load_mode Richard Henderson
2025-05-11 20:35 ` [PATCH v6 15/24] target/m68k: Remove env argument to gen_store_mode Richard Henderson
2025-05-11 20:35 ` [PATCH v6 16/24] target/m68k: Remove env argument to gen_ea_mode_fp Richard Henderson
2025-05-11 20:35 ` [PATCH v6 17/24] target/m68k: Split gen_ea_mode_fp for load/store Richard Henderson
2025-05-11 20:35 ` [PATCH v6 18/24] target/m68k: Move gen_addr_fault into gen_{load, store}_mode_fp Richard Henderson
2025-05-11 20:35 ` [PATCH v6 19/24] target/m68k: Merge gen_load_fp, gen_load_mode_fp Richard Henderson
2025-05-11 20:35 ` [PATCH v6 20/24] target/m68k: Merge gen_store_fp, gen_store_mode_fp Richard Henderson
2025-05-11 20:35 ` [PATCH v6 21/24] target/m68k: Implement packed decimal real loads and stores Richard Henderson
2025-05-11 20:35 ` [PATCH v6 22/24] tests/tcg/m68k: Add packed decimal tests Richard Henderson
2025-05-11 20:35 ` [PATCH v6 23/24] target/m68k: Make vmstate variables static Richard Henderson
2025-05-11 20:35 ` [PATCH v6 24/24] target/m68k: Implement FPIAR Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250511203546.139788-9-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).