From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v2 2/4] tests: skip legacy qcow2 encryption test if AES is not available
Date: Mon, 12 May 2025 15:24:37 +0100 [thread overview]
Message-ID: <20250512142439.1101159-3-berrange@redhat.com> (raw)
In-Reply-To: <20250512142439.1101159-1-berrange@redhat.com>
From: Daniel P. Berrangé <berrange@redhat.com>
This avoids test breakage when we drop support for using the
built-in AES impl as a fallback for missing crypto libraries.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/unit/test-crypto-block.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tests/unit/test-crypto-block.c b/tests/unit/test-crypto-block.c
index 9217b9a2ef..3ac7f17b2a 100644
--- a/tests/unit/test-crypto-block.c
+++ b/tests/unit/test-crypto-block.c
@@ -574,6 +574,13 @@ int main(int argc, char **argv)
for (i = 0; i < G_N_ELEMENTS(test_data); i++) {
if (test_data[i].open_opts->format == QCRYPTO_BLOCK_FORMAT_LUKS &&
!qcrypto_hash_supports(test_data[i].hash_alg)) {
+ g_printerr("# skip unsupported %s\n",
+ QCryptoHashAlgo_str(test_data[i].hash_alg));
+ continue;
+ }
+ if (!qcrypto_cipher_supports(QCRYPTO_CIPHER_ALGO_AES_128,
+ QCRYPTO_CIPHER_MODE_CBC)) {
+ g_printerr("# skip unsupported aes-128:cbc\n");
continue;
}
if (!test_data[i].slow ||
--
2.49.0
next prev parent reply other threads:[~2025-05-12 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 14:24 [PATCH v2 0/4] crypto: fully drop built-in cipher provider Daniel P. Berrangé
2025-05-12 14:24 ` [PATCH v2 1/4] tests: skip encrypted secret tests if AES is not available Daniel P. Berrangé
2025-05-12 14:24 ` Daniel P. Berrangé [this message]
2025-05-12 14:24 ` [PATCH v2 3/4] tests: fix skipping cipher tests when " Daniel P. Berrangé
2025-05-12 14:24 ` [PATCH v2 4/4] crypto: fully drop built-in cipher provider Daniel P. Berrangé
2025-05-13 10:05 ` [PATCH v2 0/4] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512142439.1101159-3-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).