From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4B68C3ABCB for ; Mon, 12 May 2025 15:01:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uEUdt-0008MG-V3; Mon, 12 May 2025 11:00:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEUde-0008F0-J1 for qemu-devel@nongnu.org; Mon, 12 May 2025 11:00:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEUda-0002NA-1b for qemu-devel@nongnu.org; Mon, 12 May 2025 11:00:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747062009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eI5J0HXKP1fZkgVktC6av2xKm9xJ4Og8E9m08wcvTwo=; b=WB0MWn6FSW2MN1trfsowKMcMP7Tqlu0WzrV13ApQUQ8zNsxdmptGBAAApTbB45MZiP1xG+ gvt26JrxFyStgm/2xwXmHyP7yuevCqniBRKLQmqfHUNdYOFrAha0vTkeCEnD5dVQzz6Hoy x718tOPjzVY4UfDITPNByNgaGHtsKNc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-sQdim-ixPGuFlZ9UOkmvug-1; Mon, 12 May 2025 11:00:08 -0400 X-MC-Unique: sQdim-ixPGuFlZ9UOkmvug-1 X-Mimecast-MFC-AGG-ID: sQdim-ixPGuFlZ9UOkmvug_1747062007 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-44059976a1fso15052545e9.1 for ; Mon, 12 May 2025 08:00:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747062007; x=1747666807; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eI5J0HXKP1fZkgVktC6av2xKm9xJ4Og8E9m08wcvTwo=; b=PS8b1tXjaPuCGHtdOiIY+4p97MDrpVAHwafzvlUEagNQoGqu585Z7UO/0tkiW/9mJB zCsmv+t1C2rmgbFqnzH8wAZrVkhkAulejCCzlmSR28DCBUMI6iuLiQ6JVAcNKAxpfJG2 XrpSR0k8ph4kJy0RqGfMdOzI/p1tD1bqfP3tBkG67dsfn5iXvyIPHtRMs+bYKdWlirHm tJYmnTeui89g6sR/OeOw9NhCP22PJS1Vh+ijuJ++dpZD+AAR5B7madW1XAPrBTkq73iB 23zb+WHgfep7Z2ZMfxqSMFFLlbMy1yU8mzrCyD5tOWlZKCwb+gRDev51dYA4lths7vLh sCpA== X-Forwarded-Encrypted: i=1; AJvYcCWLi0ZQ9rA6W5GaSzDblRhLiQQ80WIrUxfdU7P+dQY1ymJcJQtw03uKa/tGK7JGqhhaOqoADVGse6S3@nongnu.org X-Gm-Message-State: AOJu0Yzs82O7gGsP7xPJjvOPpIABu3MtFjNZDqT5jQb5okHPBC1scxCn 3tZxV3MgBmk+v+FJ8jUNNd0Ws3PHqBLj4FjZKfB18YEzyATzHxUXrAqELR3j/bE9xNRuFu6A1vs 43U74Q8E9GGOGvlJdLP7UCPA/BYzKHuK3L4TfLW0pfoMUGslM+LR+ X-Gm-Gg: ASbGncsqOV2GG89XN2eQJmAzZtmV+rN5Az+osd+eljYjXncGsImofDHeCLk3FWy2MdO X/cAlMIinRqZ6/Uj6u+4eRiXbkvKpk0ynpyUHK3NxcocR0GkL6rFP8F2GuYFHYIUp4V5Tee4ivZ D0rfTrLyOnjDA2ffcrWElznkNJZwS3GJ+ABkZgHmS0wImmgLgp2XJmYi73g1jKCRJUofWwnVM3U 1Hh1/WyWzBJSv1H++KN9DzlgDFEvEuQv7o8t+7f6qQZBNwITirfG6upnTOp3sTk+Fv3tGspadoV tTi9AA0NxNtRggg7qTTRTIezyPD/21g7 X-Received: by 2002:a05:600c:6090:b0:43b:c95f:fd9 with SMTP id 5b1f17b1804b1-442d6d18bfamr121218155e9.5.1747062007325; Mon, 12 May 2025 08:00:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IENnBzlU+YWO9pdg1Vj3hsTx2kvLvw+CHG1z5vAuqAHrGkAn/2pGCf8Z7HbzTYuwHLj+iYbzA== X-Received: by 2002:a05:600c:6090:b0:43b:c95f:fd9 with SMTP id 5b1f17b1804b1-442d6d18bfamr121217765e9.5.1747062006953; Mon, 12 May 2025 08:00:06 -0700 (PDT) Received: from imammedo.users.ipa.redhat.com ([85.93.96.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442cd3b7e26sm171495205e9.37.2025.05.12.08.00.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 08:00:06 -0700 (PDT) Date: Mon, 12 May 2025 17:00:02 +0200 From: Igor Mammedov To: Zhao Liu Cc: Xiaoyao Li , Philippe =?UTF-8?B?TWF0aGlldS1EYXVk?= =?UTF-8?B?w6k=?= , qemu-devel@nongnu.org, Richard Henderson , kvm@vger.kernel.org, Sergio Lopez , Gerd Hoffmann , Peter Maydell , Laurent Vivier , Jiaxun Yang , Yi Liu , "Michael S. Tsirkin" , Eduardo Habkost , Marcel Apfelbaum , Alistair Francis , Daniel Henrique Barboza , Marcelo Tosatti , qemu-riscv@nongnu.org, Weiwei Li , Amit Shah , Yanan Wang , Helge Deller , Palmer Dabbelt , Ani Sinha , Fabiano Rosas , Paolo Bonzini , Liu Zhiwei , =?UTF-8?B?Q2zDqW1lbnQ=?= Mathieu--Drif , qemu-arm@nongnu.org, =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Huacai Chen , Jason Wang Subject: Re: [PATCH v4 12/27] target/i386/cpu: Remove CPUX86State::enable_cpuid_0xb field Message-ID: <20250512170002.635aa9fa@imammedo.users.ipa.redhat.com> In-Reply-To: References: <20250508133550.81391-1-philmd@linaro.org> <20250508133550.81391-13-philmd@linaro.org> <23260c74-01ba-45bc-bf2f-b3e19c28ec8a@intel.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.551, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, 9 May 2025 15:32:30 +0800 Zhao Liu wrote: > On Fri, May 09, 2025 at 02:49:27PM +0800, Xiaoyao Li wrote: > > Date: Fri, 9 May 2025 14:49:27 +0800 > > From: Xiaoyao Li > > Subject: Re: [PATCH v4 12/27] target/i386/cpu: Remove > > CPUX86State::enable_cpuid_0xb field > >=20 > > On 5/8/2025 9:35 PM, Philippe Mathieu-Daud=C3=A9 wrote: =20 > > > The CPUX86State::enable_cpuid_0xb boolean was only disabled > > > for the pc-q35-2.6 and pc-i440fx-2.6 machines, which got > > > removed. Being now always %true, we can remove it and simplify > > > cpu_x86_cpuid(). > > >=20 > > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 ... > > > @@ -8828,7 +8823,6 @@ static const Property x86_cpu_properties[] =3D { > > > DEFINE_PROP_UINT64("ucode-rev", X86CPU, ucode_rev, 0), > > > DEFINE_PROP_BOOL("full-cpuid-auto-level", X86CPU, full_cpuid_au= to_level, true), > > > DEFINE_PROP_STRING("hv-vendor-id", X86CPU, hyperv_vendor), > > > - DEFINE_PROP_BOOL("cpuid-0xb", X86CPU, enable_cpuid_0xb, true), = =20 ... > @Philippe, thank you for cleaning up this case! I think we can keep this > property, and if you don't mind, I can modify its comment later to > indicate that it's used to adjust the topology support for the CPU. +1, we should not delete this without due process (aka deprecation). So perhaps deprecate now and remove in couple of releases=20