qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Rorie Reyes <rreyes@linux.ibm.com>
To: qemu-devel@nongnu.org, qemu-s390x@nongnu.org
Cc: pbonzini@redhat.com, cohuck@redhat.com, pasic@linux.ibm.com,
	jjherne@linux.ibm.com, borntraeger@linux.ibm.com,
	alex.williamson@redhat.com, clg@redhat.com, thuth@redhat.com,
	akrowiak@linux.ibm.com, rreyes@linux.ibm.com
Subject: [RFC PATCH v9 1/4] hw/vfio/ap: notification handler for AP config changed event
Date: Mon, 12 May 2025 14:02:27 -0400	[thread overview]
Message-ID: <20250512180230.50129-2-rreyes@linux.ibm.com> (raw)
In-Reply-To: <20250512180230.50129-1-rreyes@linux.ibm.com>

Register an event notifier handler to process AP configuration
change events by queuing the event and generating a CRW to let
the guest know its AP configuration has changed

Signed-off-by: Rorie Reyes <rreyes@linux.ibm.com>
Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com>
---
 hw/vfio/ap.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index 1207c08d8d..3d0af7a54a 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -18,6 +18,7 @@
 #include "hw/vfio/vfio-device.h"
 #include "system/iommufd.h"
 #include "hw/s390x/ap-device.h"
+#include "hw/s390x/css.h"
 #include "qemu/error-report.h"
 #include "qemu/event_notifier.h"
 #include "qemu/main-loop.h"
@@ -37,6 +38,7 @@ struct VFIOAPDevice {
     APDevice apdev;
     VFIODevice vdev;
     EventNotifier req_notifier;
+    EventNotifier cfg_notifier;
 };
 
 OBJECT_DECLARE_SIMPLE_TYPE(VFIOAPDevice, VFIO_AP_DEVICE)
@@ -70,6 +72,18 @@ static void vfio_ap_req_notifier_handler(void *opaque)
     }
 }
 
+static void vfio_ap_cfg_chg_notifier_handler(void *opaque)
+{
+    VFIOAPDevice *vapdev = opaque;
+
+    if (!event_notifier_test_and_clear(&vapdev->cfg_notifier)) {
+        return;
+    }
+
+    css_generate_css_crws(0);
+
+}
+
 static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
                                           unsigned int irq, Error **errp)
 {
@@ -85,6 +99,10 @@ static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
         notifier = &vapdev->req_notifier;
         fd_read = vfio_ap_req_notifier_handler;
         break;
+    case VFIO_AP_CFG_CHG_IRQ_INDEX:
+        notifier = &vapdev->cfg_notifier;
+        fd_read = vfio_ap_cfg_chg_notifier_handler;
+        break;
     default:
         error_setg(errp, "vfio: Unsupported device irq(%d)", irq);
         return false;
@@ -136,6 +154,9 @@ static void vfio_ap_unregister_irq_notifier(VFIOAPDevice *vapdev,
     case VFIO_AP_REQ_IRQ_INDEX:
         notifier = &vapdev->req_notifier;
         break;
+    case VFIO_AP_CFG_CHG_IRQ_INDEX:
+        notifier = &vapdev->cfg_notifier;
+        break;
     default:
         error_report("vfio: Unsupported device irq(%d)", irq);
         return;
@@ -175,6 +196,15 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp)
         warn_report_err(err);
     }
 
+    if (!vfio_ap_register_irq_notifier(vapdev, VFIO_AP_CFG_CHG_IRQ_INDEX, &err))
+    {
+        /*
+         * Report this error, but do not make it a failing condition.
+         * Lack of this IRQ in the host does not prevent normal operation.
+         */
+        warn_report_err(err);
+    }
+
     return;
 
 error:
@@ -187,6 +217,7 @@ static void vfio_ap_unrealize(DeviceState *dev)
     VFIOAPDevice *vapdev = VFIO_AP_DEVICE(dev);
 
     vfio_ap_unregister_irq_notifier(vapdev, VFIO_AP_REQ_IRQ_INDEX);
+    vfio_ap_unregister_irq_notifier(vapdev, VFIO_AP_CFG_CHG_IRQ_INDEX);
     vfio_device_detach(&vapdev->vdev);
     g_free(vapdev->vdev.name);
 }
-- 
2.48.1



  reply	other threads:[~2025-05-12 18:04 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-12 18:02 [RFC PATCH v9 0/4] Report vfio-ap configuration changes Rorie Reyes
2025-05-12 18:02 ` Rorie Reyes [this message]
2025-05-12 18:02 ` [RFC PATCH v9 2/4] hw/vfio/ap: store object indicating AP config changed in a queue Rorie Reyes
2025-05-13 11:38   ` Anthony Krowiak
2025-05-22 13:27   ` Cédric Le Goater
2025-05-22 14:28     ` Rorie Reyes
2025-05-22 15:36       ` Cédric Le Goater
2025-05-22 15:55         ` Rorie Reyes
2025-05-23  2:30         ` Rorie Reyes
2025-05-12 18:02 ` [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event Rorie Reyes
2025-05-13 11:38   ` Anthony Krowiak
2025-05-22 13:30   ` Cédric Le Goater
2025-05-22 17:17     ` Rorie Reyes
2025-05-22 19:05       ` Anthony Krowiak
2025-05-22 18:55     ` Anthony Krowiak
2025-05-26  8:43       ` Cédric Le Goater
2025-05-27 11:58         ` Anthony Krowiak
2025-05-22 13:35   ` Cédric Le Goater
2025-05-22 19:02     ` Anthony Krowiak
2025-05-23  3:05       ` Rorie Reyes
2025-05-23  3:27         ` Rorie Reyes
2025-05-12 18:02 ` [RFC PATCH v9 4/4] s390: implementing CHSC SEI for AP config change Rorie Reyes
2025-05-13 11:08   ` Cédric Le Goater
2025-05-13 11:38   ` Anthony Krowiak
2025-05-20  6:52     ` Cédric Le Goater
2025-05-20 13:17       ` Rorie Reyes
2025-05-13 11:47 ` [RFC PATCH v9 0/4] Report vfio-ap configuration changes Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250512180230.50129-2-rreyes@linux.ibm.com \
    --to=rreyes@linux.ibm.com \
    --cc=akrowiak@linux.ibm.com \
    --cc=alex.williamson@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=clg@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=jjherne@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).