From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BABA6C3ABCB for ; Mon, 12 May 2025 18:45:22 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uEY9C-00081s-Ck; Mon, 12 May 2025 14:45:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEY8m-0007jo-Sa for qemu-devel@nongnu.org; Mon, 12 May 2025 14:44:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEY8j-0004wL-73 for qemu-devel@nongnu.org; Mon, 12 May 2025 14:44:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747075476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WMM2sCxtQBMIReRzy2q+7kQlIWs6dSTIJMCncy4oAtg=; b=Jt04WoVqC/2XWB4wPPdx/Ol2Hi8UEWRVzsfmC3QzH14rA30k7mgjFmmaGF0d6Kd/f4p5gP FGqpnvNg84+aJf3+KBflx+5OPiJLtMT5ULHs0MYBHe9Dwh6bGC1QAcxSIEdbpZYUxZ/nrR 9Sc1+IB/4zdx4JHPY3SGDWAMSes8FfM= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-257-dHNHa5heOradimmFyb3XrA-1; Mon, 12 May 2025 14:44:32 -0400 X-MC-Unique: dHNHa5heOradimmFyb3XrA-1 X-Mimecast-MFC-AGG-ID: dHNHa5heOradimmFyb3XrA_1747075471 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DDEFA180087B; Mon, 12 May 2025 18:44:30 +0000 (UTC) Received: from localhost (unknown [10.2.16.161]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 57D88195396E; Mon, 12 May 2025 18:44:30 +0000 (UTC) Date: Mon, 12 May 2025 14:44:29 -0400 From: Stefan Hajnoczi To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, sunnyzhyy@qq.com, vsementsov@yandex-team.ru Subject: Re: [PATCH v4 00/13] Make blockdev-mirror dest sparse in more cases Message-ID: <20250512184429.GI141177@fedora> References: <20250509204341.3553601-15-eblake@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QUuc6/Ch81UGtTHf" Content-Disposition: inline In-Reply-To: <20250509204341.3553601-15-eblake@redhat.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.551, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --QUuc6/Ch81UGtTHf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 09, 2025 at 03:40:17PM -0500, Eric Blake wrote: > v3 was here: > https://lists.gnu.org/archive/html/qemu-devel/2025-04/msg04525.html >=20 > In v4: > - Rearrange series a bit to try and simplify logic for how zero > bitmap is populated, when pre-zeroing is attempted, and how > detect-zeroes=3Dunmap interacts [Sunny] > - Add a couple new patches to make this easier to follow > - iotest tweaks [Stefan] >=20 > 001/13:[----] [--] 'block: Expand block status mode from bool to flags' > 002/13:[----] [--] 'file-posix, gluster: Handle zero block status hint be= tter' > 003/13:[----] [--] 'block: Let bdrv_co_is_zero_fast consolidate adjacent = extents' > 004/13:[----] [--] 'block: Add new bdrv_co_is_all_zeroes() function' > 005/13:[----] [--] 'iotests: Improve iotest 194 to mirror data' > 006/13:[----] [--] 'mirror: Minor refactoring' > 007/13:[down] 'mirror: Pass full sync mode rather than bool to internals' > 008/13:[0038] [FC] 'mirror: Allow QMP override to declare target already = zero' > 009/13:[down] 'mirror: Drop redundant zero_target parameter' > 010/13:[0063] [FC] 'mirror: Skip pre-zeroing destination if it is already= zero' > 011/13:[0021] [FC] 'mirror: Skip writing zeroes when target is already ze= ro' > 012/13:[----] [--] 'iotests/common.rc: add disk_usage function' > 013/13:[0013] [FC] 'tests: Add iotest mirror-sparse for recent patches' >=20 > Andrey Drobyshev (1): > iotests/common.rc: add disk_usage function >=20 > Eric Blake (12): > block: Expand block status mode from bool to flags > file-posix, gluster: Handle zero block status hint better > block: Let bdrv_co_is_zero_fast consolidate adjacent extents > block: Add new bdrv_co_is_all_zeroes() function > iotests: Improve iotest 194 to mirror data > mirror: Minor refactoring > mirror: Pass full sync mode rather than bool to internals > mirror: Allow QMP override to declare target already zero > mirror: Drop redundant zero_target parameter > mirror: Skip pre-zeroing destination if it is already zero > mirror: Skip writing zeroes when target is already zero > tests: Add iotest mirror-sparse for recent patches >=20 > qapi/block-core.json | 8 +- > block/coroutines.h | 4 +- > include/block/block-common.h | 11 + > include/block/block-io.h | 2 + > include/block/block_int-common.h | 27 +- > include/block/block_int-global-state.h | 4 +- > include/block/block_int-io.h | 4 +- > block/io.c | 126 +++++-- > block/blkdebug.c | 6 +- > block/copy-before-write.c | 4 +- > block/file-posix.c | 5 +- > block/gluster.c | 4 +- > block/iscsi.c | 6 +- > block/mirror.c | 183 ++++++++--- > block/nbd.c | 4 +- > block/null.c | 6 +- > block/parallels.c | 6 +- > block/qcow.c | 2 +- > block/qcow2.c | 6 +- > block/qed.c | 6 +- > block/quorum.c | 4 +- > block/raw-format.c | 4 +- > block/rbd.c | 6 +- > block/snapshot-access.c | 4 +- > block/vdi.c | 4 +- > block/vmdk.c | 2 +- > block/vpc.c | 2 +- > block/vvfat.c | 6 +- > blockdev.c | 27 +- > tests/unit/test-block-iothread.c | 2 +- > tests/qemu-iotests/common.rc | 6 + > tests/qemu-iotests/194 | 7 +- > tests/qemu-iotests/194.out | 4 +- > tests/qemu-iotests/250 | 5 - > tests/qemu-iotests/iotests.py | 12 +- > tests/qemu-iotests/tests/mirror-sparse | 125 +++++++ > tests/qemu-iotests/tests/mirror-sparse.out | 365 +++++++++++++++++++++ > 37 files changed, 850 insertions(+), 159 deletions(-) > create mode 100755 tests/qemu-iotests/tests/mirror-sparse > create mode 100644 tests/qemu-iotests/tests/mirror-sparse.out >=20 > --=20 > 2.49.0 >=20 Reviewed-by: Stefan Hajnoczi --QUuc6/Ch81UGtTHf Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmgiQYwACgkQnKSrs4Gr c8htHQf/QvvivXZ7LUnjGzdVE1ukXSBc/40FopU0ECRA2lW7+kcrS8ALkMUDxay5 LotV27dqIAcnvqZs7tenM0gTJkQZTJlebQjYpyUl/eoaNPNH6Rtk1+a57QmWE5dH AizW7Sj7J1uOR4O7qv33B9cTcFll5awHCUEbApYjoyOpQ9M3ZYJLY5DWd5D/+CvH AiqxIIpgXjJZ6kmrilP899R9RldBTpiLrY1BvuV2AhuZTmpfpN8GjFd4DqaJWbUg 5Kk3QS+8UQ9nmpM9Ek+a4idwo2ERkPoL6lWZTT1CFFhQvOumMDW18QDRXX6a33BI EYqeg30VoQtYfV4wZwuNmxvgT8Iw+Q== =27Kp -----END PGP SIGNATURE----- --QUuc6/Ch81UGtTHf--