From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FDA2C3ABC9 for ; Tue, 13 May 2025 08:35:15 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uEl5f-0005l4-7L; Tue, 13 May 2025 04:34:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEl5d-0005kT-Ky for qemu-devel@nongnu.org; Tue, 13 May 2025 04:34:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEl5Z-0006Rw-83 for qemu-devel@nongnu.org; Tue, 13 May 2025 04:34:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747125251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4VUUz/K3vD5ynFqMRnkFNAMs82oWIMcdZAYYGqNsb/s=; b=SpVrHuJWQSEBVYVzZT5dcYNUTJEpvXZBMcQ8iir4AOnqYt0ADl3JO1WnCutLVjiBkgPUZZ kWzotGolQ5ZQRKLmXuZDI2wGlO7BZJUz/gWacAlKWIgOynIDoBmYUENW9/0oKOcDI/kvge fvWZlOIv4Wzok0gQ9eL2DqRCOqnOry0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-aPcWs7CbMky71VPFfUzjTg-1; Tue, 13 May 2025 04:34:09 -0400 X-MC-Unique: aPcWs7CbMky71VPFfUzjTg-1 X-Mimecast-MFC-AGG-ID: aPcWs7CbMky71VPFfUzjTg_1747125248 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43eea5a5d80so30301885e9.1 for ; Tue, 13 May 2025 01:34:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747125248; x=1747730048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4VUUz/K3vD5ynFqMRnkFNAMs82oWIMcdZAYYGqNsb/s=; b=N7E8bG89S1Ts+DszuoSrjJib6WgPbaShMXy6QY/BMtGJz2ZxePvjiVlMxl251IAon0 2XKINsQ5BfgF4wtDQKufp7dwxVnBdgWUXD3WJ4AnxRKCqlKK1uCMeKHgrQATIYXs4VXb l9f86IS3xY5WvZSEjkMksUjakAtp9n0LEeyHuETTzSvTlADMWBAI/MzMLxJRtndnmI+p XSeRP62jMmImn2aqC56/mYipeT27VyYtqjB2nJF+uIZjyUEjvkzpsYeMGe7q+Zh1PGdz 8wDBedF0dxPGpoazoPEsdDugL2E0Ox/nvRH2FN2TcRZHl85TQKmlift1is7SNNMDQqjV H9yQ== X-Gm-Message-State: AOJu0YzRJy3xDaHJlyXTtCkiXT4iCILByx3BzB2HzO+DeSRh4tLct/zm iU+iWSRLCAGjBvVcRnXe+EeFxPl1FSqv9vCvxie8wY5PayrOL0fvt4fGxb3JsanbVObuEnd+dcu eatfh7bQyr7xIkozKwT2mdOF/YvtYJ+C/sQ58Af/DK8cNHRSTUfIJ X-Gm-Gg: ASbGnctqvyKlwe0PZi6Zue4xDl7JA/MsFXPPkRUkzXyr03fgmmOp2N9CarYiwKTIRgJ 6HlU/p7ySit2NC+9URrjzDepP4jwyXMullhfyoVHauwju7qgANQd/kTEWlQhLE08EOe6SHUdVol 3KME8FkyVeEoDoDkt7frat/JRFA5JqMdz/1AVuvP2mdBaSu6I8rfMzm64cSE2/Zotf1C2Di9093 I8DRL5D6Bn9sHrqtxWWHjbXBC+Mfm+M5d2e6uEHMYS5Lob5ZHwCLQR+jziC+95lEc0R7xtTlRPu EOGKdUIpgNg2so7Md+UArm6ZrGRgFbyv X-Received: by 2002:a05:600c:628c:b0:43c:f689:dd with SMTP id 5b1f17b1804b1-442d6d71df0mr146869905e9.19.1747125248011; Tue, 13 May 2025 01:34:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHSlfEs20rOFjqqrW5vXRv0rjvijsDxbmGSr2wixU5yagOHT15C4yLbypPTku5RDF+DKRHL5Q== X-Received: by 2002:a05:600c:628c:b0:43c:f689:dd with SMTP id 5b1f17b1804b1-442d6d71df0mr146869485e9.19.1747125247581; Tue, 13 May 2025 01:34:07 -0700 (PDT) Received: from imammedo.users.ipa.redhat.com ([85.93.96.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442e9d00bacsm40155815e9.12.2025.05.13.01.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 01:34:07 -0700 (PDT) Date: Tue, 13 May 2025 10:34:05 +0200 From: Igor Mammedov To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: qemu-devel@nongnu.org, Richard Henderson , kvm@vger.kernel.org, Sergio Lopez , Gerd Hoffmann , Peter Maydell , Laurent Vivier , Jiaxun Yang , Yi Liu , "Michael S. Tsirkin" , Eduardo Habkost , Marcel Apfelbaum , Alistair Francis , Daniel Henrique Barboza , Marcelo Tosatti , qemu-riscv@nongnu.org, Weiwei Li , Amit Shah , Zhao Liu , Yanan Wang , Helge Deller , Palmer Dabbelt , Ani Sinha , Fabiano Rosas , Paolo Bonzini , Liu Zhiwei , =?UTF-8?B?Q2zDqW1lbnQ=?= Mathieu--Drif , qemu-arm@nongnu.org, =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Huacai Chen , Jason Wang , Mark Cave-Ayland , Thomas Huth Subject: Re: [PATCH v4 14/27] hw/intc/apic: Remove APICCommonState::legacy_instance_id field Message-ID: <20250513103405.6c502bbc@imammedo.users.ipa.redhat.com> In-Reply-To: <20250508133550.81391-15-philmd@linaro.org> References: <20250508133550.81391-1-philmd@linaro.org> <20250508133550.81391-15-philmd@linaro.org> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.129.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.551, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, 8 May 2025 15:35:37 +0200 Philippe Mathieu-Daud=C3=A9 wrote: > The APICCommonState::legacy_instance_id boolean was only set > in the pc_compat_2_6[] array, via the 'legacy-instance-id=3Don' > property. We removed all machines using that array, lets remove > that property, simplifying apic_common_realize(). >=20 > Because instance_id is initialized as initial_apic_id, we can > not register vmstate_apic_common directly via dc->vmsd. I think just removing this property is pretty save, it's highly unlikely to be used by any external user as it's purpose was to keep migration working for 2.6. With the later gone there is not need for the property at all. =20 >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: Mark Cave-Ayland > Reviewed-by: Thomas Huth Reviewed-by: Igor Mammedov > --- > include/hw/i386/apic_internal.h | 1 - > hw/intc/apic_common.c | 5 ----- > 2 files changed, 6 deletions(-) >=20 > diff --git a/include/hw/i386/apic_internal.h b/include/hw/i386/apic_inter= nal.h > index 429278da618..db6a9101530 100644 > --- a/include/hw/i386/apic_internal.h > +++ b/include/hw/i386/apic_internal.h > @@ -188,7 +188,6 @@ struct APICCommonState { > uint32_t vapic_control; > DeviceState *vapic; > hwaddr vapic_paddr; /* note: persistence via kvmvapic */ > - bool legacy_instance_id; > uint32_t extended_log_dest; > }; > =20 > diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c > index 37a7a7019d3..1d259b97e63 100644 > --- a/hw/intc/apic_common.c > +++ b/hw/intc/apic_common.c > @@ -294,9 +294,6 @@ static void apic_common_realize(DeviceState *dev, Err= or **errp) > info->enable_tpr_reporting(s, true); > } > =20 > - if (s->legacy_instance_id) { > - instance_id =3D VMSTATE_INSTANCE_ID_ANY; > - } > vmstate_register_with_alias_id(NULL, instance_id, &vmstate_apic_comm= on, > s, -1, 0, NULL); > =20 > @@ -412,8 +409,6 @@ static const Property apic_properties_common[] =3D { > DEFINE_PROP_UINT8("version", APICCommonState, version, 0x14), > DEFINE_PROP_BIT("vapic", APICCommonState, vapic_control, VAPIC_ENABL= E_BIT, > true), > - DEFINE_PROP_BOOL("legacy-instance-id", APICCommonState, legacy_insta= nce_id, > - false), > }; > =20 > static void apic_common_get_id(Object *obj, Visitor *v, const char *name,