qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 17/19] hw/arm/realview: Replace arm_feature() -> arm_cpu_has_feature()
Date: Tue, 13 May 2025 18:39:26 +0100	[thread overview]
Message-ID: <20250513173928.77376-18-philmd@linaro.org> (raw)
In-Reply-To: <20250513173928.77376-1-philmd@linaro.org>

By using arm_cpu_has_feature() instead of arm_feature()
we don't need to include "cpu.h" anymore.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 hw/arm/realview.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/hw/arm/realview.c b/hw/arm/realview.c
index 5c9050490b4..4c0a8b42709 100644
--- a/hw/arm/realview.c
+++ b/hw/arm/realview.c
@@ -9,7 +9,6 @@
 
 #include "qemu/osdep.h"
 #include "qapi/error.h"
-#include "cpu.h"
 #include "hw/sysbus.h"
 #include "hw/arm/boot.h"
 #include "hw/arm/primecell.h"
@@ -31,6 +30,7 @@
 #include "hw/sd/sd.h"
 #include "audio/audio.h"
 #include "target/arm/cpu-qom.h"
+#include "target/arm/cpu_has_feature.h"
 
 #define SMP_BOOT_ADDR 0xe0000000
 #define SMP_BOOTREG_ADDR 0x10000030
@@ -77,7 +77,6 @@ static void realview_init(MachineState *machine,
                           enum realview_board_type board_type)
 {
     ARMCPU *cpu = NULL;
-    CPUARMState *env;
     MemoryRegion *sysmem = get_system_memory();
     MemoryRegion *ram_lo;
     MemoryRegion *ram_hi = g_new(MemoryRegion, 1);
@@ -138,16 +137,15 @@ static void realview_init(MachineState *machine,
         cpu_irq[n] = qdev_get_gpio_in(DEVICE(cpuobj), ARM_CPU_IRQ);
     }
     cpu = ARM_CPU(first_cpu);
-    env = &cpu->env;
-    if (arm_feature(env, ARM_FEATURE_V7)) {
+    if (arm_cpu_has_feature(cpu, ARM_FEATURE_V7)) {
         if (is_mpcore) {
             proc_id = 0x0c000000;
         } else {
             proc_id = 0x0e000000;
         }
-    } else if (arm_feature(env, ARM_FEATURE_V6K)) {
+    } else if (arm_cpu_has_feature(cpu, ARM_FEATURE_V6K)) {
         proc_id = 0x06000000;
-    } else if (arm_feature(env, ARM_FEATURE_V6)) {
+    } else if (arm_cpu_has_feature(cpu, ARM_FEATURE_V6)) {
         proc_id = 0x04000000;
     } else {
         proc_id = 0x02000000;
-- 
2.47.1



  parent reply	other threads:[~2025-05-13 17:49 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13 17:39 [PATCH 00/19] target/arm: More header rework around arm_feature() & multiprocessing.h Philippe Mathieu-Daudé
2025-05-13 17:39 ` [PATCH 01/19] target/arm/tcg-stubs: compile file once (system) Philippe Mathieu-Daudé
2025-05-13 17:43   ` Philippe Mathieu-Daudé
2025-05-13 22:59   ` Pierrick Bouvier
2025-05-14  8:18   ` Richard Henderson
2025-05-13 17:39 ` [PATCH 02/19] target/arm/hvf_arm: Avoid using poisoned CONFIG_HVF definition Philippe Mathieu-Daudé
2025-05-13 22:58   ` Pierrick Bouvier
2025-05-14  8:19   ` Richard Henderson
2025-05-13 17:39 ` [PATCH 03/19] target/arm: Only link with zlib when TCG is enabled Philippe Mathieu-Daudé
2025-05-13 22:58   ` Pierrick Bouvier
2025-05-13 17:39 ` [PATCH 04/19] target/arm/cpregs: Include missing 'target/arm/cpu.h' header Philippe Mathieu-Daudé
2025-05-13 17:39 ` [PATCH 05/19] hw/arm/boot: Include missing 'system/memory.h' header Philippe Mathieu-Daudé
2025-05-13 17:39 ` [PATCH 06/19] target/arm/cpu-features: Include missing 'cpu.h' header Philippe Mathieu-Daudé
2025-05-13 17:39 ` [PATCH 07/19] target/arm/qmp: " Philippe Mathieu-Daudé
2025-05-13 17:39 ` [PATCH 08/19] target/arm/kvm: Include missing 'cpu-qom.h' header Philippe Mathieu-Daudé
2025-05-13 17:39 ` [PATCH 09/19] target/arm/hvf: " Philippe Mathieu-Daudé
2025-05-13 17:39 ` [PATCH 10/19] hw/arm: Remove unnecessary 'cpu.h' header Philippe Mathieu-Daudé
2025-05-13 17:39 ` [PATCH 11/19] target/arm: Restrict inclusion of 'multiprocessing.h' Philippe Mathieu-Daudé
2025-05-13 17:39 ` [PATCH 12/19] target/arm: Move some definitions from 'cpu.h' to 'multiprocessing.h' Philippe Mathieu-Daudé
2025-05-13 17:39 ` [PATCH 13/19] hw/arm: Include missing 'target/arm/gtimer.h' header Philippe Mathieu-Daudé
2025-05-13 17:39 ` [PATCH 14/19] target/arm: Extract PSCI definitions to 'psci.h' Philippe Mathieu-Daudé
2025-05-13 17:39 ` [PATCH 15/19] target/arm: Extract feature definitions to 'cpu_has_feature.h' header Philippe Mathieu-Daudé
2025-05-13 17:39 ` [PATCH 16/19] target/arm: Add arm_cpu_has_feature() helper Philippe Mathieu-Daudé
2025-05-14  8:24   ` Richard Henderson
2025-05-14 16:53     ` Philippe Mathieu-Daudé
2025-05-14 16:59       ` Pierrick Bouvier
2025-05-15 11:05         ` Philippe Mathieu-Daudé
2025-05-15 15:22           ` Pierrick Bouvier
2025-05-15 16:14             ` Philippe Mathieu-Daudé
2025-05-15 16:20               ` Pierrick Bouvier
2025-05-13 17:39 ` Philippe Mathieu-Daudé [this message]
2025-05-13 17:39 ` [PATCH 18/19] hw/arm/virt-acpi: Replace arm_feature() -> arm_cpu_has_feature() Philippe Mathieu-Daudé
2025-05-13 17:39 ` [PATCH 19/19] target/arm: Always include full path to 'cpu.h' Philippe Mathieu-Daudé
2025-05-13 22:57   ` Pierrick Bouvier
2025-05-13 17:42 ` [PATCH 00/19] target/arm: More header rework around arm_feature() & multiprocessing.h Philippe Mathieu-Daudé
2025-05-13 23:00   ` Pierrick Bouvier
2025-05-29 15:37 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250513173928.77376-18-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).