qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Fabiano Rosas <farosas@suse.de>,
	Prasad Pandit <ppandit@redhat.com>,
	Juraj Marcin <jmarcin@redhat.com>,
	"Dr . David Alan Gilbert" <dave@treblig.org>,
	peterx@redhat.com
Subject: [PATCH 2/3] migration/hmp: Dump global in "info migrate_parameters" instead
Date: Tue, 13 May 2025 18:09:22 -0400	[thread overview]
Message-ID: <20250513220923.518025-3-peterx@redhat.com> (raw)
In-Reply-To: <20250513220923.518025-1-peterx@redhat.com>

"info migrate" is the command people would frequently use to query
migration status.  We may not want it to dump global configurations because
dumping the same things over and over won't help.

The globals are just more suitable for a parameter dump instead.  Hence
move it over.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/migration-hmp-cmds.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
index 49c26daed3..0034dbe47f 100644
--- a/migration/migration-hmp-cmds.c
+++ b/migration/migration-hmp-cmds.c
@@ -58,8 +58,6 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
 
     info = qmp_query_migrate(NULL);
 
-    migration_global_dump(mon);
-
     if (info->blocked_reasons) {
         strList *reasons = info->blocked_reasons;
         monitor_printf(mon, "Outgoing migration blocked:\n");
@@ -235,6 +233,8 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
 {
     MigrationParameters *params;
 
+    migration_global_dump(mon);
+
     params = qmp_query_migrate_parameters(NULL);
 
     if (params) {
-- 
2.49.0



  parent reply	other threads:[~2025-05-13 22:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13 22:09 [PATCH 0/3] migration: Some fix and enhancements to HMP "info migrate" Peter Xu
2025-05-13 22:09 ` [PATCH 1/3] migration: Allow caps to be set when preempt or multifd cap enabled Peter Xu
2025-05-14 12:52   ` Dr. David Alan Gilbert
2025-05-14 13:27   ` Juraj Marcin
2025-05-13 22:09 ` Peter Xu [this message]
2025-05-14 13:25   ` [PATCH 2/3] migration/hmp: Dump global in "info migrate_parameters" instead Dr. David Alan Gilbert
2025-05-14 17:29     ` Peter Xu
2025-05-14 13:28   ` Juraj Marcin
2025-05-13 22:09 ` [PATCH 3/3] migration/hmp: Add "info migrate -a", reorg the dump Peter Xu
2025-05-14 13:15   ` Dr. David Alan Gilbert
2025-05-14 14:33   ` Juraj Marcin
2025-05-14 17:37     ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250513220923.518025-3-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=dave@treblig.org \
    --cc=farosas@suse.de \
    --cc=jmarcin@redhat.com \
    --cc=ppandit@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).