From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, berrange@redhat.com, pbonzini@redhat.com
Subject: [PATCH 0/4] chardev: Fix issues found by vhost-user-test
Date: Thu, 15 May 2025 19:20:10 -0300 [thread overview]
Message-ID: <20250515222014.4161-1-farosas@suse.de> (raw)
Running vhost-user-test with ASAN on a loaded machine reveals several
intermittent issues. These show up every time I test the qtest tree so
I'm trying to get rid of them.
1- UAF of IOWatchPoll.
This one is self explanatory, ASAN caught it.
2- Reference counting issues in glib. It seems it's possible to unref
a source while adding a callback to it, and glib asserts. This
shows up on all architectures, only on the ASAN build after
hundreds of iterations.
3- Extra yank_unregister_function call leads to abort(). This shows up
on all architectures, but it's quite hidden due to vhost-user-test
using a dedicated server thread which dies and causes timeouts in
the test.
Manifests as assert(s->fds_num) failing. Only on the ASAN build,
after tens of iterations (quite common).
Thanks
Fabiano Rosas (4):
chardev: Fix QIOChannel refcount
chardev: Don't attempt to unregister yank function more than once
chardev: Consolidate yank registration
chardev: Introduce a lock for hup_source
chardev/char-io.c | 5 +++++
chardev/char-socket.c | 38 ++++++++++++--------------------------
chardev/char.c | 2 ++
include/chardev/char.h | 1 +
4 files changed, 20 insertions(+), 26 deletions(-)
--
2.35.3
next reply other threads:[~2025-05-15 22:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 22:20 Fabiano Rosas [this message]
2025-05-15 22:20 ` [PATCH 1/4] chardev: Fix QIOChannel refcount Fabiano Rosas
2025-05-19 10:49 ` Daniel P. Berrangé
2025-05-15 22:20 ` [PATCH 2/4] chardev: Don't attempt to unregister yank function more than once Fabiano Rosas
2025-05-19 10:52 ` Daniel P. Berrangé
2025-05-15 22:20 ` [PATCH 3/4] chardev: Consolidate yank registration Fabiano Rosas
2025-05-19 10:53 ` Daniel P. Berrangé
2025-05-15 22:20 ` [PATCH 4/4] chardev: Introduce a lock for hup_source Fabiano Rosas
2025-05-19 11:00 ` Daniel P. Berrangé
2025-05-19 14:21 ` Fabiano Rosas
2025-05-24 17:50 ` [PATCH 0/4] chardev: Fix issues found by vhost-user-test Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515222014.4161-1-farosas@suse.de \
--to=farosas@suse.de \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).