qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org, Hanna Czenczek <hreitz@redhat.com>
Subject: Re: iotest 240 is failing
Date: Tue, 20 May 2025 10:00:55 -0400	[thread overview]
Message-ID: <20250520140055.GB82528@fedora> (raw)
In-Reply-To: <a0d4dd1b-19e8-4b18-85c3-57f867993d69@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 2397 bytes --]

On Fri, May 16, 2025 at 09:21:32AM +0200, Thomas Huth wrote:
> On 24/04/2025 11.39, Thomas Huth wrote:
> > On 26/03/2025 11.43, Thomas Huth wrote:
> > > On 11/03/2025 17.00, Kevin Wolf wrote:
> > > > From: Stefan Hajnoczi <stefanha@redhat.com>
> > > > 
> > > > Allow virtio-scsi virtqueues to be assigned to different IOThreads. This
> > > > makes it possible to take advantage of host multi-queue block layer
> > > > scalability by assigning virtqueues that have affinity with vCPUs to
> > > > different IOThreads that have affinity with host CPUs. The same feature
> > > > was introduced for virtio-blk in the past:
> > > > https://developers.redhat.com/articles/2024/09/05/scaling-virtio-blk-
> > > > disk- io-iothread-virtqueue-mapping
> > > 
> > >   Hi Stefan!
> > > 
> > > This patch seems to cause some troubles with iotest 240 in raw (and
> > > some other) mode:
> > > 
> > > 240   fail       [11:41:33] [11:41:34]   0.8s   (last: 0.8s)  output
> > > mismatch (see tests/qemu-iotests/scratch/raw-file-240/240.out.bad)
> > > --- tests/qemu-iotests/240.out
> > > +++ tests/qemu-iotests/scratch/raw-file-240/240.out.bad
> > > @@ -46,11 +46,11 @@
> > >   {"execute": "device_add", "arguments": {"bus": "scsi0.0", "drive":
> > > "hd0", "driver": "scsi-hd", "id": "scsi-hd0"}}
> > >   {"return": {}}
> > >   {"execute": "device_add", "arguments": {"bus": "scsi1.0", "drive":
> > > "hd0", "driver": "scsi-hd", "id": "scsi-hd1"}}
> > > -{"error": {"class": "GenericError", "desc": "Cannot change iothread
> > > of active block backend"}}
> > > +{"return": {}}
> > >   {"execute": "device_del", "arguments": {"id": "scsi-hd0"}}
> > >   {"return": {}}
> > >   {"execute": "device_add", "arguments": {"bus": "scsi1.0", "drive":
> > > "hd0", "driver": "scsi-hd", "id": "scsi-hd1"}}
> > > -{"return": {}}
> > > +{"error": {"class": "GenericError", "desc": "Duplicate device ID
> > > 'scsi- hd1'"}}
> > >   {"execute": "device_del", "arguments": {"id": "scsi-hd1"}}
> > >   {"return": {}}
> > >   {"execute": "blockdev-del", "arguments": {"node-name": "hd0"}}
> > > Failures: 240
> > > Failed 1 of 1 iotests
> > > 
> > > Could you please have a look?
> > 
> > Ping!
> > 
> > The problem still persists in QEMU 10.0 :-(
> 
> Ping^2 !
> 
> It's still failing. Could anybody please have a look?

Hi Thomas,
I will take a look on Thursday.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2025-05-20 14:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-11 15:59 [PULL 00/22] Block layer patches Kevin Wolf
2025-03-11 16:00 ` [PULL 01/22] block: Remove unused blk_op_is_blocked() Kevin Wolf
2025-03-11 16:00 ` [PULL 02/22] block: Zero block driver state before reopening Kevin Wolf
2025-03-11 16:00 ` [PULL 03/22] file-posix: Support FUA writes Kevin Wolf
2025-03-11 16:00 ` [PULL 04/22] block/io: Ignore FUA with cache.no-flush=on Kevin Wolf
2025-03-11 16:00 ` [PULL 05/22] aio: Create AioPolledEvent Kevin Wolf
2025-03-11 16:00 ` [PULL 06/22] aio-posix: Factor out adjust_polling_time() Kevin Wolf
2025-03-11 16:00 ` [PULL 07/22] aio-posix: Separate AioPolledEvent per AioHandler Kevin Wolf
2025-03-11 16:00 ` [PULL 08/22] aio-posix: Adjust polling time also for new handlers Kevin Wolf
2025-03-11 16:00 ` [PULL 09/22] iotests: Limit qsd-migrate to working formats Kevin Wolf
2025-03-11 16:00 ` [PULL 10/22] scsi-disk: drop unused SCSIDiskState->bh field Kevin Wolf
2025-03-11 16:00 ` [PULL 11/22] dma: use current AioContext for dma_blk_io() Kevin Wolf
2025-03-11 16:00 ` [PULL 12/22] scsi: track per-SCSIRequest AioContext Kevin Wolf
2025-03-11 16:00 ` [PULL 13/22] scsi: introduce requests_lock Kevin Wolf
2025-03-11 16:00 ` [PULL 14/22] virtio-scsi: introduce event and ctrl virtqueue locks Kevin Wolf
2025-03-11 16:00 ` [PULL 15/22] virtio-scsi: protect events_dropped field Kevin Wolf
2025-03-11 16:00 ` [PULL 16/22] virtio-scsi: perform TMFs in appropriate AioContexts Kevin Wolf
2025-03-11 16:00 ` [PULL 17/22] virtio-blk: extract cleanup_iothread_vq_mapping() function Kevin Wolf
2025-03-11 16:00 ` [PULL 18/22] virtio-blk: tidy up iothread_vq_mapping functions Kevin Wolf
2025-03-11 16:00 ` [PULL 19/22] virtio: extract iothread-vq-mapping.h API Kevin Wolf
2025-03-11 16:00 ` [PULL 20/22] virtio-scsi: add iothread-vq-mapping parameter Kevin Wolf
2025-03-26 10:43   ` Thomas Huth
2025-04-24  9:39     ` iotest 240 is failing (was: Re: [PULL 20/22] virtio-scsi: add iothread-vq-mapping parameter) Thomas Huth
2025-05-16  7:21       ` iotest 240 is failing Thomas Huth
2025-05-20 14:00         ` Stefan Hajnoczi [this message]
2025-03-11 16:00 ` [PULL 21/22] virtio-scsi: handle ctrl virtqueue in main loop Kevin Wolf
2025-03-11 16:00 ` [PULL 22/22] virtio-scsi: only expose cmd vqs via iothread-vq-mapping Kevin Wolf
2025-03-12 13:40 ` [PULL 00/22] Block layer patches Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250520140055.GB82528@fedora \
    --to=stefanha@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).