qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Akihiko Odaki" <akihiko.odaki@daynix.com>,
	"John Snow" <jsnow@redhat.com>, "Fabiano Rosas" <farosas@suse.de>,
	"Peter Xu" <peterx@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Alexandre Iooss" <erdnaxe@crans.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>,
	"Sriram Yagnaraman" <sriram.yagnaraman@ericsson.com>,
	"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
	"Gustavo Romero" <gustavo.romero@linaro.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Eric Auger" <eric.auger@redhat.com>
Subject: [PATCH v3 06/20] tests/functional: Add PCI hotplug test for aarch64
Date: Wed, 21 May 2025 17:42:36 +0100	[thread overview]
Message-ID: <20250521164250.135776-7-alex.bennee@linaro.org> (raw)
In-Reply-To: <20250521164250.135776-1-alex.bennee@linaro.org>

From: Gustavo Romero <gustavo.romero@linaro.org>

Add a functional test, aarch64_hotplug_pci, to exercise PCI hotplug and
hot-unplug on arm64.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Message-Id: <20250512144629.182340-1-gustavo.romero@linaro.org>
[AJB: add qemu-arm link]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
v2
  - add qemu-arm link to MAINTAINERS
---
 MAINTAINERS                                  |  6 ++
 tests/functional/meson.build                 |  1 +
 tests/functional/test_aarch64_hotplug_pci.py | 74 ++++++++++++++++++++
 3 files changed, 81 insertions(+)
 create mode 100755 tests/functional/test_aarch64_hotplug_pci.py

diff --git a/MAINTAINERS b/MAINTAINERS
index 7060cf49b9..818d7b9d5f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2078,6 +2078,12 @@ S: Supported
 F: include/hw/pci/pcie_doe.h
 F: hw/pci/pcie_doe.c
 
+ARM PCI Hotplug
+M: Gustavo Romero <gustavo.romero@linaro.org>
+L: qemu-arm@nongnu.org
+S: Supported
+F: tests/functional/test_aarch64_hotplug_pci.py
+
 ACPI/SMBIOS
 M: Michael S. Tsirkin <mst@redhat.com>
 M: Igor Mammedov <imammedo@redhat.com>
diff --git a/tests/functional/meson.build b/tests/functional/meson.build
index 52b4706cfe..2d68840fa2 100644
--- a/tests/functional/meson.build
+++ b/tests/functional/meson.build
@@ -83,6 +83,7 @@ tests_aarch64_system_quick = [
 tests_aarch64_system_thorough = [
   'aarch64_aspeed_ast2700',
   'aarch64_aspeed_ast2700fc',
+  'aarch64_hotplug_pci',
   'aarch64_imx8mp_evk',
   'aarch64_raspi3',
   'aarch64_raspi4',
diff --git a/tests/functional/test_aarch64_hotplug_pci.py b/tests/functional/test_aarch64_hotplug_pci.py
new file mode 100755
index 0000000000..fa1bb62c8f
--- /dev/null
+++ b/tests/functional/test_aarch64_hotplug_pci.py
@@ -0,0 +1,74 @@
+#!/usr/bin/env python3
+#
+# SPDX-License-Identifier: GPL-2.0-or-later
+#
+# The test hotplugs a PCI device and checks it on a Linux guest.
+#
+# Copyright (c) 2025 Linaro Ltd.
+#
+# Author:
+#  Gustavo Romero <gustavo.romero@linaro.org>
+#
+# This work is licensed under the terms of the GNU GPL, version 2 or
+# later.  See the COPYING file in the top-level directory.
+
+from qemu_test import LinuxKernelTest, Asset, exec_command_and_wait_for_pattern
+from qemu_test import BUILD_DIR
+
+class HotplugPCI(LinuxKernelTest):
+
+    ASSET_KERNEL = Asset(
+        ('https://ftp.debian.org/debian/dists/stable/main/installer-arm64/'
+         'current/images/netboot/debian-installer/arm64/linux'),
+        '3821d4db56d42c6a4eac62f31846e35465940afd87746b4cfcdf5c9eca3117b2')
+
+    ASSET_INITRD = Asset(
+        ('https://ftp.debian.org/debian/dists/stable/main/installer-arm64/'
+         'current/images/netboot/debian-installer/arm64/initrd.gz'),
+        '2583ec22b45265ad69e82f198674f53d4cd85be124fe012eedc2fd91156bc4b4')
+
+    def test_hotplug_pci(self):
+
+        self.set_machine('virt')
+        self.vm.add_args('-m', '512M')
+        self.vm.add_args('-cpu', 'cortex-a57')
+        self.vm.add_args('-append',
+                         'console=ttyAMA0,115200 init=/bin/sh')
+        self.vm.add_args('-device',
+                         'pcie-root-port,bus=pcie.0,chassis=1,slot=1,id=pcie.1')
+        self.vm.add_args('-bios', self.build_file('pc-bios',
+                                                  'edk2-aarch64-code.fd'))
+
+        # BusyBox prompt
+        prompt = "~ #"
+        self.launch_kernel(self.ASSET_KERNEL.fetch(),
+                           self.ASSET_INITRD.fetch(),
+                           wait_for=prompt)
+
+        # Check for initial state: 2 network adapters, lo and enp0s1.
+        exec_command_and_wait_for_pattern(self,
+                                          'ls -l /sys/class/net | wc -l',
+                                          '2')
+
+        # Hotplug one network adapter to the root port, i.e. pcie.1 bus.
+        self.vm.cmd('device_add',
+                    driver='virtio-net-pci',
+                    bus='pcie.1',
+                    addr=0,
+                    id='na')
+        # Wait for the kernel to recognize the new device.
+        self.wait_for_console_pattern('virtio-pci')
+        self.wait_for_console_pattern('virtio_net')
+
+        # Check if there is a new network adapter.
+        exec_command_and_wait_for_pattern(self,
+                                          'ls -l /sys/class/net | wc -l',
+                                          '3')
+
+        self.vm.cmd('device_del', id='na')
+        exec_command_and_wait_for_pattern(self,
+                                          'ls -l /sys/class/net | wc -l',
+                                          '2')
+
+if __name__ == '__main__':
+    LinuxKernelTest.main()
-- 
2.39.5



  parent reply	other threads:[~2025-05-21 16:46 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-21 16:42 [PATCH v3 00/20] Maintainer updates for May (testing, plugins, virtio-gpu) - pre-PR Alex Bennée
2025-05-21 16:42 ` [PATCH v3 01/20] tests/docker: expose $HOME/.cache/qemu as docker volume Alex Bennée
2025-05-22  5:23   ` Thomas Huth
2025-05-21 16:42 ` [PATCH v3 02/20] gitlab: disable debug info on CI builds Alex Bennée
2025-05-21 16:42 ` [PATCH v3 03/20] tests/tcg: make aarch64 boot.S handle different starting modes Alex Bennée
2025-05-22  5:10   ` Akihiko Odaki
2025-05-21 16:42 ` [PATCH v3 04/20] tests/qtest: fix igb test failure under --enable-ubsan Alex Bennée
2025-05-22  5:19   ` Akihiko Odaki
2025-05-25 15:18     ` Philippe Mathieu-Daudé
2025-05-21 16:42 ` [PATCH v3 05/20] tests/Makefile: include test-plugins in per-arch build deps Alex Bennée
2025-05-22  5:37   ` Akihiko Odaki
2025-05-22 10:31     ` Alex Bennée
2025-05-22 10:35       ` Akihiko Odaki
2025-05-25 15:18         ` Philippe Mathieu-Daudé
2025-05-21 16:42 ` Alex Bennée [this message]
2025-05-22  5:43   ` [PATCH v3 06/20] tests/functional: Add PCI hotplug test for aarch64 Akihiko Odaki
2025-05-21 16:42 ` [PATCH v3 07/20] contrib/plugins: add a scaling factor to the ips arg Alex Bennée
2025-05-22  5:45   ` Akihiko Odaki
2025-05-25 15:19     ` Philippe Mathieu-Daudé
2025-05-21 16:42 ` [PATCH v3 08/20] contrib/plugins: allow setting of instructions per quantum Alex Bennée
2025-05-22  5:55   ` Akihiko Odaki
2025-05-21 16:42 ` [PATCH v3 09/20] MAINTAINERS: add myself to virtio-gpu for Odd Fixes Alex Bennée
2025-05-22  5:16   ` Markus Armbruster
2025-05-21 16:42 ` [PATCH v3 10/20] MAINTAINERS: add Akihiko and Dmitry as reviewers Alex Bennée
2025-05-22  5:16   ` Markus Armbruster
2025-05-24 11:07   ` Michael S. Tsirkin
2025-05-25 15:20   ` Philippe Mathieu-Daudé
2025-05-21 16:42 ` [PATCH v3 11/20] hw/display: re-arrange memory region tracking Alex Bennée
2025-05-21 16:42 ` [PATCH v3 12/20] virtio-gpu: fix hang under TCG when unmapping blob Alex Bennée
2025-05-22  5:59   ` Akihiko Odaki
2025-05-22  6:45     ` Alex Bennée
2025-05-22  7:02       ` Akihiko Odaki
2025-05-22  7:31         ` Manos Pitsidianakis
2025-05-22  7:40           ` Akihiko Odaki
2025-05-22  9:28             ` Alex Bennée
2025-05-22  9:54               ` Akihiko Odaki
2025-05-27 10:05                 ` Alex Bennée
2025-05-27 11:03                   ` Akihiko Odaki
2025-05-21 16:42 ` [PATCH v3 13/20] virtio-gpu: refactor async blob unmapping Alex Bennée
2025-05-21 16:42 ` [PATCH v3 14/20] ui/gtk-gl-area: Remove extra draw call in refresh Alex Bennée
2025-05-21 16:42 ` [PATCH v3 15/20] virtio-gpu: support context init multiple timeline Alex Bennée
2025-05-21 16:42 ` [PATCH v3 16/20] include/exec: fix assert in size_memop Alex Bennée
2025-05-22  6:07   ` Akihiko Odaki
2025-05-21 16:42 ` [PATCH v3 17/20] include/gdbstub: fix include guard in commands.h Alex Bennée
2025-05-21 16:42 ` [PATCH v3 18/20] gdbstub: assert earlier in handle_read_all_regs Alex Bennée
2025-05-21 16:42 ` [PATCH v3 19/20] gdbstub: Implement qGDBServerVersion packet Alex Bennée
2025-05-22  6:29   ` Akihiko Odaki
2025-05-22 10:05     ` Alex Bennée
2025-05-22 10:15       ` Akihiko Odaki
2025-05-25 15:25   ` Philippe Mathieu-Daudé
2025-05-27  9:16     ` Alex Bennée
2025-05-21 16:42 ` [PATCH v3 20/20] gdbstub: update aarch64-core.xml Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250521164250.135776-7-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=akihiko.odaki@daynix.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=david@redhat.com \
    --cc=dmitry.osipenko@collabora.com \
    --cc=erdnaxe@crans.org \
    --cc=eric.auger@redhat.com \
    --cc=farosas@suse.de \
    --cc=gustavo.romero@linaro.org \
    --cc=jsnow@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=ma.mandourr@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sriram.yagnaraman@ericsson.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).