From: Steven Lee via <qemu-devel@nongnu.org>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Troy Lee" <leetroy@gmail.com>,
"Jamin Lin" <jamin_lin@aspeedtech.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: <troy_lee@aspeedtech.com>, <longzl2@lenovo.com>,
<yunlin.tang@aspeedtech.com>, <steven_lee@aspeedtech.com>
Subject: [PATCH v4 0/6] hw/arm/aspeed_ast2700-fc: Fix null pointer dereference
Date: Thu, 22 May 2025 17:16:54 +0800 [thread overview]
Message-ID: <20250522091701.354185-1-steven_lee@aspeedtech.com> (raw)
Clang's sanitizer reports a runtime error when booting with
'-net nic -net user', due to a null pointer being passed
to memory_region_find(), which subsequently triggers a crash in
flatview_lookup().
Root cause:
- Missing NIC configuration in the CA35 initialization.
Fix:
- Reduce ca35 ram size from 2GiB to 1GiB to align with ast2700a1-evb,
where the ram-container is defined as 1GiB in its class.
- Add nic configuration in ast2700fc's ca35 init function.
v2:
- Split the CA35 memory mapping into a separate patch.
- Added a new patch to fix BMC memory mapping in the fby35 machine,
which had a similar issue (unmapped system_memory).
- Removed Change-Id tag from commit messages
v3:
- Fixed issue with incorrectly inheriting TYPE_ASPEED_MACHINE.
- Rewrote the commit message for "Map BMC memory into system memory".
- Added more details to the commit message for "Fix unimplemented region
overlap with VBootROM".
v4:
- Split the first patch "Fix null pointer dereference" into two patches.
- Remove the patch "hw/arm/aspeed_ast27x0: Fix unimplemented
region overlap with vbootrom".
Steven Lee (6):
hw/arm/aspeed_ast2700-fc: Fix null pointer dereference in ca35 init
hw/arm/aspeed_ast2700-fc: Reduce ca35 ram size to align with ast2700a1
hw/arm/aspeed_ast27x0: Fix unimplemented region overlap with vbootrom
hw/arm/aspeed_ast27x0-fc: Map ca35 memory into system memory
hw/arm/fby35: Map BMC memory into system memory
docs: Remove ast2700fc from Aspeed family boards
docs/system/arm/aspeed.rst | 2 +-
hw/arm/aspeed_ast27x0-fc.c | 10 +++++++++-
hw/arm/aspeed_ast27x0.c | 4 ++--
hw/arm/fby35.c | 1 +
4 files changed, 13 insertions(+), 4 deletions(-)
--
2.43.0
next reply other threads:[~2025-05-22 9:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 9:16 Steven Lee via [this message]
2025-05-22 9:16 ` [PATCH v4 1/6] hw/arm/aspeed_ast2700-fc: Fix null pointer dereference in ca35 init Steven Lee via
2025-05-23 8:08 ` Cédric Le Goater
2025-05-23 9:16 ` Steven Lee
2025-05-22 9:16 ` [PATCH v4 2/6] hw/arm/aspeed_ast2700-fc: Reduce ca35 ram size to align with ast2700a1 Steven Lee via
2025-05-22 10:01 ` Cédric Le Goater
2025-05-22 9:16 ` [PATCH v4 3/6] hw/arm/aspeed_ast27x0: Fix unimplemented region overlap with vbootrom Steven Lee via
2025-05-23 8:10 ` Cédric Le Goater
2025-05-22 9:16 ` [PATCH v4 4/6] hw/arm/aspeed_ast27x0-fc: Map ca35 memory into system memory Steven Lee via
2025-05-22 9:16 ` [PATCH v4 5/6] hw/arm/fby35: Map BMC " Steven Lee via
2025-05-22 9:17 ` [PATCH v4 6/6] docs: Remove ast2700fc from Aspeed family boards Steven Lee via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250522091701.354185-1-steven_lee@aspeedtech.com \
--to=qemu-devel@nongnu.org \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=longzl2@lenovo.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
--cc=yunlin.tang@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).