From: Julian Ganz <neither@nut.email>
To: Rowan Hart <rowanbhart@gmail.com>
Cc: "Julian Ganz" <neither@nut.email>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 1/8] Expose gdb_write_register function to consumers of gdbstub
Date: Thu, 22 May 2025 13:59:30 +0200 [thread overview]
Message-ID: <20250522115935.34716-1-neither@nut.email> (raw)
In-Reply-To: <20250521094333.4075796-2-rowanbhart@gmail.com>
Hi Rowan,
> From: novafacing <rowanbhart@gmail.com>
>
> Signed-off-by: novafacing <rowanbhart@gmail.com>
> Signed-off-by: Rowan Hart <rowanbhart@gmail.com>
As I understand it, the commit subject should be prefixed with the
subsystem the patch (mainly) touches. In this case "plugins".
Commit message bodies would also be appreciated. In this case maybe one
motivating the change in one or two sentences. It's obvious enough from
context here, but you want at least some context when stumbling accross
a commit in isolation (e.g. after consulting git blame).
Reviewed-By: Julian Ganz <neither@nut.email>
Regards,
Julian
next prev parent reply other threads:[~2025-05-22 12:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 9:43 [PATCH v3 0/8] Add additional plugin API functions to read and write memory and registers Rowan Hart
2025-05-21 9:43 ` [PATCH v3 1/8] Expose gdb_write_register function to consumers of gdbstub Rowan Hart
2025-05-21 22:52 ` Pierrick Bouvier
2025-05-22 8:53 ` Manos Pitsidianakis
2025-05-22 11:59 ` Julian Ganz [this message]
2025-05-21 9:43 ` [PATCH v3 2/8] Add register write API Rowan Hart
2025-05-21 22:52 ` Pierrick Bouvier
2025-05-22 11:59 ` Julian Ganz
2025-05-22 15:02 ` Rowan Hart
2025-05-22 15:16 ` Julian Ganz
2025-05-22 15:39 ` Alex Bennée
2025-05-22 20:11 ` Rowan Hart
2025-05-21 9:43 ` [PATCH v3 3/8] Add address space API Rowan Hart
2025-05-21 9:43 ` [PATCH v3 4/8] Add memory virtual address write API Rowan Hart
2025-05-21 22:53 ` Pierrick Bouvier
2025-05-21 9:43 ` [PATCH v3 5/8] Add memory hardware address read/write API Rowan Hart
2025-05-21 23:18 ` Pierrick Bouvier
2025-05-22 3:34 ` Rowan Hart
2025-05-22 19:46 ` Pierrick Bouvier
2025-05-22 11:59 ` Julian Ganz
2025-05-22 19:16 ` Pierrick Bouvier
2025-05-22 21:01 ` Rowan Hart
2025-05-22 22:37 ` Pierrick Bouvier
2025-05-21 9:43 ` [PATCH v3 6/8] Add patcher plugin and test Rowan Hart
2025-05-21 9:43 ` [PATCH v3 7/8] Add hypercalls " Rowan Hart
2025-05-21 9:43 ` [PATCH v3 8/8] Update plugin version and add notes Rowan Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250522115935.34716-1-neither@nut.email \
--to=neither@nut.email \
--cc=alex.bennee@linaro.org \
--cc=eduardo@habkost.net \
--cc=erdnaxe@crans.org \
--cc=ma.mandourr@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rowanbhart@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).