Re: [PATCH v5 14/25] target/openrisc: call plugin trap callbacks

[Julian Ganz <neither@nut.email>]

Hi Richard,

> On 5/19/25 16:19, Julian Ganz wrote:
> > diff --git a/target/openrisc/interrupt.c b/target/openrisc/interrupt.c
> > index 486823094c..08f0ed9b89 100644
> > --- a/target/openrisc/interrupt.c
> > +++ b/target/openrisc/interrupt.c
> > @@ -25,11 +25,13 @@
> >   #ifndef CONFIG_USER_ONLY
> >   #include "hw/loader.h"
> >   #endif
> > +#include "qemu/plugin.h"
> >   
> >   void openrisc_cpu_do_interrupt(CPUState *cs)
> >   {
> >       CPUOpenRISCState *env = cpu_env(cs);
> >       int exception = cs->exception_index;
> > +    uint64_t last_pc = env->pc;
> >   
> >       env->epcr = env->pc;
> >   
> > @@ -98,6 +100,17 @@ void openrisc_cpu_do_interrupt(CPUState *cs)
> >           cpu_abort(cs, "Unhandled exception 0x%x\n", exception);
> >       }
> >   
> > +    switch (exception) {
> > +    case EXCP_RESET:
> 
> There are plenty of other EXCP_RESET uses that aren't marked as interrupt.
> Bug?

Mh... I might not have been perfectly consistent with resets. We do expect
plugins to be notified of resets already, so we probably don't want to trigger
exception or interrupt callbacks.

I'll check and adjust for the next series.

Regards,
Julian