From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Cédric Le Goater" <clg@redhat.com>
Cc: Steven Sistare <steven.sistare@oracle.com>,
qemu-devel@nongnu.org,
Marc-Andre Lureau <marcandre.lureau@redhat.com>,
Thanos Makatos <thanos.makatos@nutanix.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>,
David Hildenbrand <david@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Philippe Mathieu-Daude <philmd@linaro.org>,
John Levon <john.levon@nutanix.com>
Subject: Re: [PATCH V5] vfio: return mr from vfio_get_xlat_addr
Date: Mon, 26 May 2025 10:37:27 -0400 [thread overview]
Message-ID: <20250526103712-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <bc0d41f3-752a-4797-ac61-6716d78a2aea@redhat.com>
On Sun, May 25, 2025 at 11:23:57PM +0200, Cédric Le Goater wrote:
> Michael,
>
> On 5/20/25 15:46, Cédric Le Goater wrote:
> >
> > > > > @@ -1010,6 +1017,8 @@ static void vfio_iommu_map_dirty_notify(IOMMUNotifier *n, IOMMUTLBEntry *iotlb)
> > > > > ram_addr_t translated_addr;
> > > > > Error *local_err = NULL;
> > > > > int ret = -EINVAL;
> > > > > + MemoryRegion *mr;
> > > > > + ram_addr_t xlat;
> > > >
> > > > xlat should be :
> > > >
> > > > hwaddr xlat;
> > >
> > > Will you make that change when you pull, or do you want me to submit a V6
> > > with this and the RB's?
> >
> > I can handle it.
> >
> > An ack from Michael (vhost) is needed for the PR.
>
> Are you okay with us merging this patch via the vfio queue ?
>
> This would facilitate the progress of 2 larges series : live update
> and vfio-user
>
> Thanks,
>
> C.
sure, thanks!
Acked-by: Michael S. Tsirkin <mst@redhat.com>
next prev parent reply other threads:[~2025-05-26 14:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 13:26 [PATCH V5] vfio: return mr from vfio_get_xlat_addr Steve Sistare
2025-05-19 13:46 ` John Levon
2025-05-20 6:46 ` Cédric Le Goater
2025-05-20 7:32 ` Cédric Le Goater
2025-05-20 13:42 ` Steven Sistare
2025-05-20 13:46 ` Cédric Le Goater
2025-05-25 21:23 ` Cédric Le Goater
2025-05-26 14:37 ` Michael S. Tsirkin [this message]
2025-05-26 16:57 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250526103712-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=berrange@redhat.com \
--cc=clg@redhat.com \
--cc=david@redhat.com \
--cc=john.levon@nutanix.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=steven.sistare@oracle.com \
--cc=thanos.makatos@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).