qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	miguel.luis@oracle.com, peter.maydell@linaro.org,
	richard.henderson@linaro.org, maz@kernel.org,
	gkulkarni@amperecomputing.com,
	gankulkarni@os.amperecomputing.com
Subject: [PATCH v5 4/5] target/arm: Enable feature ARM_FEATURE_EL2 if EL2 is supported
Date: Tue, 27 May 2025 08:24:36 +0200	[thread overview]
Message-ID: <20250527062534.1186004-5-eric.auger@redhat.com> (raw)
In-Reply-To: <20250527062534.1186004-1-eric.auger@redhat.com>

From: Haibo Xu <haibo.xu@linaro.org>

KVM_CAP_ARM_EL2 must be supported by the cpu to enable ARM_FEATURE_EL2.
In case the host does support NV, expose the feature.

Signed-off-by: Haibo Xu <haibo.xu@linaro.org>
Signed-off-by: Miguel Luis <miguel.luis@oracle.com>
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

---
v2 -> v3:
- check pmu->has_el2 on kvm_arch_init_vcpu() when setting
  KVM_ARM_VCPU_HAS_EL2 feature (Peter)

v1 -> v2:
- remove isar_feature_aa64_aa32_el2 modif in target/arm/cpu.h
  [Richard] and use el2_supported in kvm_arch_init_vcpu
---
 target/arm/kvm.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/target/arm/kvm.c b/target/arm/kvm.c
index ad6c80dd49..495c8246c2 100644
--- a/target/arm/kvm.c
+++ b/target/arm/kvm.c
@@ -227,6 +227,7 @@ static bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)
      */
     int fdarray[3];
     bool sve_supported;
+    bool el2_supported;
     bool pmu_supported = false;
     uint64_t features = 0;
     int err;
@@ -246,6 +247,14 @@ static bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)
         init.features[0] |= 1 << KVM_ARM_VCPU_SVE;
     }
 
+    /*
+     * Ask for EL2 if supported.
+     */
+    el2_supported = kvm_arm_el2_supported();
+    if (el2_supported) {
+        init.features[0] |= 1 << KVM_ARM_VCPU_HAS_EL2;
+    }
+
     /*
      * Ask for Pointer Authentication if supported, so that we get
      * the unsanitized field values for AA64ISAR1_EL1.
@@ -429,6 +438,10 @@ static bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)
     features |= 1ULL << ARM_FEATURE_AARCH64;
     features |= 1ULL << ARM_FEATURE_GENERIC_TIMER;
 
+    if (el2_supported) {
+        features |= 1ULL << ARM_FEATURE_EL2;
+    }
+
     ahcf->features = features;
 
     return true;
@@ -1889,6 +1902,9 @@ int kvm_arch_init_vcpu(CPUState *cs)
         cpu->kvm_init_features[0] |= (1 << KVM_ARM_VCPU_PTRAUTH_ADDRESS |
                                       1 << KVM_ARM_VCPU_PTRAUTH_GENERIC);
     }
+    if (cpu->has_el2 && kvm_arm_el2_supported()) {
+        cpu->kvm_init_features[0] |= 1 << KVM_ARM_VCPU_HAS_EL2;
+    }
 
     /* Do KVM_ARM_VCPU_INIT ioctl */
     ret = kvm_arm_vcpu_init(cpu);
-- 
2.49.0



  parent reply	other threads:[~2025-05-27  6:29 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-27  6:24 [PATCH v5 0/5] ARM Nested Virt Support Eric Auger
2025-05-27  6:24 ` [PATCH v5 1/5] linux-headers: Update against kvm/next Eric Auger
2025-05-27  6:24 ` [PATCH v5 2/5] hw/arm: Allow setting KVM vGIC maintenance IRQ Eric Auger
2025-05-27  6:24 ` [PATCH v5 3/5] target/arm/kvm: Add helper to detect EL2 when using KVM Eric Auger
2025-05-27  6:24 ` Eric Auger [this message]
2025-05-27  6:24 ` [PATCH v5 5/5] hw/arm/virt: Allow virt extensions with KVM Eric Auger
2025-06-17 14:17   ` Alyssa Ross
2025-06-17 14:52     ` Eric Auger
2025-06-17 15:10     ` Eric Auger
2025-06-17 15:23     ` Miguel Luis
2025-06-17 15:41       ` Eric Auger
2025-06-17 15:50         ` Miguel Luis
2025-06-19  9:40           ` Eric Auger
2025-06-19 13:29           ` Eric Auger
2025-06-19 16:04             ` Alyssa Ross
2025-06-20 16:20             ` Miguel Luis
2025-05-27  7:39 ` [PATCH v5 0/5] ARM Nested Virt Support Marc Zyngier
2025-05-27  9:05   ` Eric Auger
2025-05-27 11:40   ` Miguel Luis
2025-05-27 12:02     ` Marc Zyngier
2025-05-27 13:24       ` Miguel Luis
2025-05-27 13:46         ` Marc Zyngier
2025-05-27 15:55           ` Miguel Luis
2025-05-27 16:52             ` Marc Zyngier
2025-05-27 23:52               ` Miguel Luis
2025-05-28  8:07                 ` Marc Zyngier
2025-06-19  8:19   ` Eric Auger
2025-06-19  8:33     ` Miguel Luis
2025-05-27 11:33 ` Miguel Luis
2025-05-27 12:01   ` Marc Zyngier
2025-05-27 12:54     ` Miguel Luis
2025-05-27 13:11       ` Eric Auger
2025-05-27 14:15         ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250527062534.1186004-5-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=gankulkarni@os.amperecomputing.com \
    --cc=gkulkarni@amperecomputing.com \
    --cc=maz@kernel.org \
    --cc=miguel.luis@oracle.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).