From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: eblake@redhat.com, kwolf@redhat.com, jsnow@redhat.com,
vsementsov@yandex-team.ru, qemu-block@nongnu.org
Subject: [PATCH 12/13] qapi: Tidy up references to job state CONCLUDED
Date: Tue, 27 May 2025 09:39:15 +0200 [thread overview]
Message-ID: <20250527073916.1243024-13-armbru@redhat.com> (raw)
In-Reply-To: <20250527073916.1243024-1-armbru@redhat.com>
When talking about the job state machine, we refer to the states like
READY, ABORTING, CONCLUDED, and so forth. Except in two places, where
we use JOB_STATUS_CONCLUDED. Replace by CONCLUDED for consistency.
We should arguably use the JobStatus enum values instead. Left for
another day.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qapi/block-core.json | 6 +++---
qapi/job.json | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index ad6de151c8..da390f85ac 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -3074,9 +3074,9 @@
# jobs.
#
# This command will refuse to operate on any job that has not yet
-# reached its terminal state, JOB_STATUS_CONCLUDED. For jobs that
-# make use of the BLOCK_JOB_READY event, job-cancel, block-job-cancel
-# or job-complete will still need to be used as appropriate.
+# reached its terminal state, CONCLUDED. For jobs that make use of
+# the BLOCK_JOB_READY event, job-cancel, block-job-cancel or
+# job-complete will still need to be used as appropriate.
#
# @id: The job identifier.
#
diff --git a/qapi/job.json b/qapi/job.json
index 9ddba537db..441cd7772b 100644
--- a/qapi/job.json
+++ b/qapi/job.json
@@ -223,9 +223,9 @@
# jobs.
#
# This command will refuse to operate on any job that has not yet
-# reached its terminal state, JOB_STATUS_CONCLUDED. For jobs that
-# make use of JOB_READY event, job-cancel or job-complete will still
-# need to be used as appropriate.
+# reached its terminal state, CONCLUDED. For jobs that make use of
+# the JOB_READY event, job-cancel or job-complete will still need to
+# be used as appropriate.
#
# @id: The job identifier.
#
--
2.48.1
next prev parent reply other threads:[~2025-05-27 7:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 7:39 [PATCH 00/13] qapi: Doc fixes and improvements Markus Armbruster
2025-05-27 7:39 ` [PATCH 01/13] qapi: Tidy up run-together sentences in doc comments Markus Armbruster
2025-05-27 7:39 ` [PATCH 02/13] qapi: Tidy up whitespace " Markus Armbruster
2025-05-27 7:39 ` [PATCH 03/13] qapi: Move (since X.Y) to end of description Markus Armbruster
2025-05-27 7:39 ` [PATCH 04/13] qapi: Avoid breaking lines within (since X.Y) Markus Armbruster
2025-05-27 7:39 ` [PATCH 05/13] qapi: Drop a problematic (Since: 2.11) from query-hotpluggable-cpus Markus Armbruster
2025-05-27 7:39 ` [PATCH 06/13] qapi: Correct spelling of QEMU in doc comments Markus Armbruster
2025-05-27 7:39 ` [PATCH 07/13] qapi: Fix capitalization " Markus Armbruster
2025-05-27 7:39 ` [PATCH 08/13] qapi: Use proper markup instead of CAPS for emphasis " Markus Armbruster
2025-05-27 7:39 ` [PATCH 09/13] qapi: Spell JSON null correctly in blockdev-reopen documentation Markus Armbruster
2025-05-27 7:39 ` [PATCH 10/13] qapi: Refer to job-FOO instead of deprecated block-job-FOO in docs Markus Armbruster
2025-05-27 7:39 ` [PATCH 11/13] qapi: Mention both job-cancel and block-job-cancel in doc comments Markus Armbruster
2025-05-27 7:39 ` Markus Armbruster [this message]
2025-05-27 7:39 ` [PATCH 13/13] qapi: Improve documentation around job state @concluded Markus Armbruster
2025-05-27 12:51 ` [PATCH 00/13] qapi: Doc fixes and improvements Eric Blake
2025-06-03 6:39 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527073916.1243024-13-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).