From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CECB7C54ED1 for ; Tue, 27 May 2025 16:29:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uJxAn-0003cj-FY; Tue, 27 May 2025 12:29:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uJxAj-0003ab-DE; Tue, 27 May 2025 12:29:01 -0400 Received: from [185.176.79.56] (helo=frasgout.his.huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uJxAf-0001NF-4k; Tue, 27 May 2025 12:29:01 -0400 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4b6HzZ1BNlz6L50R; Wed, 28 May 2025 00:25:14 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id EB14814050D; Wed, 28 May 2025 00:28:44 +0800 (CST) Received: from localhost (10.122.19.247) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 27 May 2025 18:28:44 +0200 Date: Tue, 27 May 2025 17:28:43 +0100 To: "Zhijian Li (Fujitsu)" CC: "qemu-devel@nongnu.org" , Fan Ni , Peter Maydell , "mst@redhat.com" , "linux-cxl@vger.kernel.org" , "linuxarm@huawei.com" , "qemu-arm@nongnu.org" , Yuquan Wang , Itaru Kitayama , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH v13 3/5] hw/cxl-host: Allow split of establishing memory address and mmio setup. Message-ID: <20250527172843.000065a9@huawei.com> In-Reply-To: References: <20250513111455.128266-1-Jonathan.Cameron@huawei.com> <20250513111455.128266-4-Jonathan.Cameron@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.122.19.247] X-ClientProxiedBy: lhrpeml100011.china.huawei.com (7.191.174.247) To frapeml500008.china.huawei.com (7.182.85.71) X-Host-Lookup-Failed: Reverse DNS lookup failed for 185.176.79.56 (deferred) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, 16 May 2025 05:50:59 +0000 "Zhijian Li (Fujitsu)" wrote: > On 13/05/2025 19:14, Jonathan Cameron via wrote: > > > > +hwaddr cxl_fmws_set_memmap(hwaddr base, hwaddr max_addr) > > +{ > > + GSList *cfmws_list, *iter; > > + > > + struct cfmw_update_state cfmwss = { > > + .base = base, > > + .maxaddr = max_addr, > > + .update_mmio = false, > > + }; > > + cfmws_list = cxl_fmws_get_all_sorted(); > > + for (iter = cfmws_list; iter; iter = iter->next) { > > + cxl_fmws_update(iter->data, &cfmwss); > > + } > > + g_slist_free(cfmws_list); > > + > > + return cfmwss.base; > > +} > > + > > hwaddr cxl_fmws_set_memmap_and_update_mmio(hwaddr base, hwaddr max_addr) > > { > > GSList *cfmws_list, *iter; > > @@ -445,6 +466,7 @@ hwaddr cxl_fmws_set_memmap_and_update_mmio(hwaddr base, hwaddr max_addr) > > struct cfmw_update_state cfmwss = { > > .base = base, > > .maxaddr = max_addr, > > + .update_mmio = true, > > }; > > cfmws_list = cxl_fmws_get_all_sorted(); > > for (iter = cfmws_list; iter; iter = iter->next) { > > @@ -455,6 +477,26 @@ hwaddr cxl_fmws_set_memmap_and_update_mmio(hwaddr base, hwaddr max_addr) > > return cfmwss.base; > > } > > > > It seem we can share most of the code in cxl_fmws_set_memmap_and_update_mmio() and cxl_fmws_set_memmap() > In addition, we can drop the cfmw_update_state::update_mmio if there is no other users. Just pass it > to cxl_fmws_update() directly. I'd like to keep the 'documentation' aspect of the function names, but can reduce duplication with a do_cxl_fmws_set_mmemap_and_update_mmio() function that has a shared implementation and takes the extra parameter as you suggestion. Thanks Jonathan > > > Thanks > Zhijian