Re: [PATCH 04/18] hw/i386/kvm: Remove KVMClockState::mach_use_reliable_get_clock field

[Igor Mammedov <imammedo@redhat.com>]

On Thu,  1 May 2025 23:04:42 +0200
Philippe Mathieu-Daudé <philmd@linaro.org> wrote:

> The KVMClockState::mach_use_reliable_get_clock boolean was only
> used by the pc-q35-2.8 and pc-i440fx-2.8 machines, which got removed.
> Remove it, along with the 'x-mach-use-reliable-get-clock' property.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  hw/i386/kvm/clock.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c
> index f56382717f7..726ebfcb0cb 100644
> --- a/hw/i386/kvm/clock.c
> +++ b/hw/i386/kvm/clock.c
> @@ -23,7 +23,6 @@
>  #include "migration/vmstate.h"
>  #include "hw/sysbus.h"
>  #include "hw/i386/kvm/clock.h"
> -#include "hw/qdev-properties.h"
>  #include "qapi/error.h"
>  
>  #include <linux/kvm.h>
> @@ -43,9 +42,6 @@ struct KVMClockState {
>      /* whether the 'clock' value was obtained in the 'paused' state */
>      bool runstate_paused;
>  
> -    /* whether machine type supports reliable KVM_GET_CLOCK */
> -    bool mach_use_reliable_get_clock;
> -
>      /* whether the 'clock' value was obtained in a host with
>       * reliable KVM_GET_CLOCK */
>      bool clock_is_reliable;
> @@ -232,18 +228,10 @@ static void kvmclock_realize(DeviceState *dev, Error **errp)
>      qemu_add_vm_change_state_handler(kvmclock_vm_state_change, s);
>  }
>  
> -static bool kvmclock_clock_is_reliable_needed(void *opaque)
> -{
> -    KVMClockState *s = opaque;
> -
> -    return s->mach_use_reliable_get_clock;
> -}
> -
>  static const VMStateDescription kvmclock_reliable_get_clock = {
>      .name = "kvmclock/clock_is_reliable",
>      .version_id = 1,
>      .minimum_version_id = 1,
> -    .needed = kvmclock_clock_is_reliable_needed,
>      .fields = (const VMStateField[]) {
>          VMSTATE_BOOL(clock_is_reliable, KVMClockState),
>          VMSTATE_END_OF_LIST()
> @@ -304,18 +292,12 @@ static const VMStateDescription kvmclock_vmsd = {
>      }
>  };
>  
> -static const Property kvmclock_properties[] = {
> -    DEFINE_PROP_BOOL("x-mach-use-reliable-get-clock", KVMClockState,
> -                      mach_use_reliable_get_clock, true),
> -};
> -
>  static void kvmclock_class_init(ObjectClass *klass, const void *data)
>  {
>      DeviceClass *dc = DEVICE_CLASS(klass);
>  
>      dc->realize = kvmclock_realize;
>      dc->vmsd = &kvmclock_vmsd;
> -    device_class_set_props(dc, kvmclock_properties);
>  }
>  
>  static const TypeInfo kvmclock_info = {