From: Fiona Ebner <f.ebner@proxmox.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, hreitz@redhat.com,
stefanha@redhat.com, fam@euphon.net, jsnow@redhat.com,
vsementsov@yandex-team.ru, eblake@redhat.com, kbusch@kernel.org,
its@irrelevant.dk, foss@defmacro.it
Subject: [PATCH 2/4] block-coroutine-wrapper: mark generated co-wrapper as GRAPH_UNLOCKED
Date: Wed, 4 Jun 2025 14:07:15 +0200 [thread overview]
Message-ID: <20250604120717.458445-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20250604120717.458445-1-f.ebner@proxmox.com>
Generated co-wrappers poll, so they need to be called with the graph
unlocked.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Unfortunately, it's not clear how to achieve something similar for the
mixed wrappers, which would've caught the issue fixed in the following
patch.
scripts/block-coroutine-wrapper.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/block-coroutine-wrapper.py b/scripts/block-coroutine-wrapper.py
index dbbde99e39..cdde957257 100644
--- a/scripts/block-coroutine-wrapper.py
+++ b/scripts/block-coroutine-wrapper.py
@@ -186,7 +186,7 @@ def create_co_wrapper(func: FuncDecl) -> str:
name = func.target_name
struct_name = func.struct_name
return f"""\
-{func.return_type} {func.name}({ func.gen_list('{decl}') })
+{func.return_type} GRAPH_UNLOCKED {func.name}({ func.gen_list('{decl}') })
{{
{struct_name} s = {{
.poll_state.ctx = qemu_get_current_aio_context(),
--
2.39.5
next prev parent reply other threads:[~2025-06-04 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 12:07 [PATCH 0/4] block: fix deadlock when doing blockdev-snapshot of a node with compress filter Fiona Ebner
2025-06-04 12:07 ` [PATCH 1/4] block/graph-lock: fix typo in comment Fiona Ebner
2025-06-17 18:36 ` Eric Blake
2025-06-04 12:07 ` Fiona Ebner [this message]
2025-06-04 12:07 ` [PATCH 3/4] block: make calling bdrv_refresh_limits() safe while holding graph lock Fiona Ebner
2025-06-04 12:15 ` Klaus Jensen
2025-06-04 12:07 ` [PATCH 4/4] iotests: add test for snapshot on top of node with compress filter Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250604120717.458445-3-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=foss@defmacro.it \
--cc=hreitz@redhat.com \
--cc=its@irrelevant.dk \
--cc=jsnow@redhat.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).