From: Fiona Ebner <f.ebner@proxmox.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, hreitz@redhat.com,
stefanha@redhat.com, fam@euphon.net, jsnow@redhat.com,
vsementsov@yandex-team.ru, eblake@redhat.com, kbusch@kernel.org,
its@irrelevant.dk, foss@defmacro.it
Subject: [PATCH 4/4] iotests: add test for snapshot on top of node with compress filter
Date: Wed, 4 Jun 2025 14:07:17 +0200 [thread overview]
Message-ID: <20250604120717.458445-5-f.ebner@proxmox.com> (raw)
In-Reply-To: <20250604120717.458445-1-f.ebner@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
tests/qemu-iotests/085 | 18 ++++++++++++++++++
tests/qemu-iotests/085.out | 21 +++++++++++++++++++++
2 files changed, 39 insertions(+)
diff --git a/tests/qemu-iotests/085 b/tests/qemu-iotests/085
index 3fb7b0b5c8..5063e3e8d2 100755
--- a/tests/qemu-iotests/085
+++ b/tests/qemu-iotests/085
@@ -270,6 +270,24 @@ _send_qemu_cmd $h "{ 'execute': 'blockdev-snapshot',
'overlay':'snap_${SNAPSHOTS}' }
}" "error"
+echo
+echo === Add snapshot in combination with compress filter ===
+echo
+
+SNAPSHOTS=$((${SNAPSHOTS}+1))
+add_snapshot_image ${SNAPSHOTS}
+
+_send_qemu_cmd $h "{ 'execute': 'blockdev-add',
+ 'arguments': { 'driver':'compress',
+ 'node-name':'compress',
+ 'file':'virtio0' }
+ }" "return"
+
+_send_qemu_cmd $h "{ 'execute': 'blockdev-snapshot',
+ 'arguments': { 'node':'compress',
+ 'overlay':'snap_${SNAPSHOTS}' }
+ }" "return"
+
# success, all done
echo "*** done"
rm -f $seq.full
diff --git a/tests/qemu-iotests/085.out b/tests/qemu-iotests/085.out
index b543b992ff..57d68f3bb9 100644
--- a/tests/qemu-iotests/085.out
+++ b/tests/qemu-iotests/085.out
@@ -255,4 +255,25 @@ Formatting 'TEST_DIR/15-snapshot-v0.IMGFMT', fmt=IMGFMT size=134217728 backing_f
'overlay':'snap_15' }
}
{"error": {"class": "GenericError", "desc": "Cannot find device='nodevice' nor node-name='nodevice'"}}
+
+=== Add snapshot in combination with compress filter ===
+
+Formatting 'TEST_DIR/16-snapshot-v0.IMGFMT', fmt=IMGFMT size=134217728 backing_file=TEST_DIR/15-snapshot-v0.IMGFMT backing_fmt=IMGFMT
+{ 'execute': 'blockdev-add', 'arguments':
+ { 'driver': 'IMGFMT', 'node-name': 'snap_16', 'backing': null,
+ 'file':
+ { 'driver': 'file', 'filename': 'TEST_DIR/16-snapshot-v0.IMGFMT',
+ 'node-name': 'file_16' } } }
+{"return": {}}
+{ 'execute': 'blockdev-add',
+ 'arguments': { 'driver':'compress',
+ 'node-name':'compress',
+ 'file':'virtio0' }
+ }
+{"return": {}}
+{ 'execute': 'blockdev-snapshot',
+ 'arguments': { 'node':'compress',
+ 'overlay':'snap_16' }
+ }
+{"return": {}}
*** done
--
2.39.5
prev parent reply other threads:[~2025-06-04 12:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 12:07 [PATCH 0/4] block: fix deadlock when doing blockdev-snapshot of a node with compress filter Fiona Ebner
2025-06-04 12:07 ` [PATCH 1/4] block/graph-lock: fix typo in comment Fiona Ebner
2025-06-17 18:36 ` Eric Blake
2025-06-04 12:07 ` [PATCH 2/4] block-coroutine-wrapper: mark generated co-wrapper as GRAPH_UNLOCKED Fiona Ebner
2025-06-04 12:07 ` [PATCH 3/4] block: make calling bdrv_refresh_limits() safe while holding graph lock Fiona Ebner
2025-06-04 12:15 ` Klaus Jensen
2025-06-04 12:07 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250604120717.458445-5-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=foss@defmacro.it \
--cc=hreitz@redhat.com \
--cc=its@irrelevant.dk \
--cc=jsnow@redhat.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).