From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3792C5B543 for ; Wed, 4 Jun 2025 20:05:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMuLO-0005uD-6C; Wed, 04 Jun 2025 16:04:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMuLL-0005t9-LL for qemu-devel@nongnu.org; Wed, 04 Jun 2025 16:04:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMuLE-0008HK-Da for qemu-devel@nongnu.org; Wed, 04 Jun 2025 16:04:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749067443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p6SFvWlN7H/XL4425CyVURHGhzfJ/317OQSJPCFw244=; b=XY4QMGdZZ87pPQM6acuEVfbSZghEb8wf1QLYo1FOHJYMDNQb8H7/L/ju4sVgXHyU3trGnn yhYEL6nNAs3tLp2lBxsvdhkkAzkOYkjc4r57G/UtIVGe12vJYXrmhXTJkpallwdsSNGABz O2NF2X0kY3yskoEFcHF7Z90zl7tm0TE= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-PqMl3m2ENNqbnxzVKmNY0w-1; Wed, 04 Jun 2025 16:03:58 -0400 X-MC-Unique: PqMl3m2ENNqbnxzVKmNY0w-1 X-Mimecast-MFC-AGG-ID: PqMl3m2ENNqbnxzVKmNY0w_1749067437 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4D33B1801A00; Wed, 4 Jun 2025 20:03:57 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.64.163]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 12F2B30002C3; Wed, 4 Jun 2025 20:03:55 +0000 (UTC) From: John Snow To: qemu-devel@nongnu.org Cc: John Snow , Michael Roth , Cleber Rosa , Peter Maydell , Markus Armbruster Subject: [PATCH v5 0/6] python: add QAPI and qapidoc et al to python tests Date: Wed, 4 Jun 2025 16:03:48 -0400 Message-ID: <20250604200354.459501-1-jsnow@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.128, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hiya, this series turns on automated linting for scripts/qapi,=0D docs/sphinx/qapidoc.py and docs/sphinx/qapi_domain.py.=0D =0D This includes flake8/isort/pylint/mypy for scripts/qapi, but omits mypy=0D from the Sphinx plugins owing to my inability to strictly type the=0D extensions given the wide versions of Sphinx we actually support.=0D =0D [Maybe this will change soon, but it's not true just yet.]=0D =0D Though I have been using black in my own development, I have not yet=0D enabled it anywhere automatically. Maybe soon.=0D =0D V5:=0D - Fixed test failure on GitLab CI. As far as I can tell, the problem=0D stems from Sphinx requiring a version of `packaging` that is old=0D enough that some newer versions of setuptools break when it is=0D installed. Fix this by pinning setuptools to an older version, for=0D now. Note that this only applies to the "minreqs" test and not=0D general installation.=0D =0D (This change applies only to patch 4/6.)=0D =0D (Note that I am still carrying a patch to bump the Sphinx version,=0D but I wanted to get this series out of the way first... I'll revisit=0D this pinning again shortly.)=0D =0D V4:=0D - Rebase and resend. Pull Request imminent.=0D =0D V3:=0D - Folded in Markus's commit to clean up setup.cfg.=0D =0D V2:=0D - Mostly commit message updates based on Markus's's's review.=0D =0D John Snow (5):=0D qapi: Add some pylint ignores=0D docs/qapidoc: linting fixes=0D python: update missing dependencies from minreqs=0D python: add qapi static analysis tests=0D qapi: delete un-needed python static analysis configs=0D =0D Markus Armbruster (1):=0D python: Drop redundant warn_unused_configs =3D True=0D =0D docs/sphinx/qapi_domain.py | 25 ++++++++++++++-----------=0D docs/sphinx/qapidoc.py | 5 +++--=0D python/setup.cfg | 2 +-=0D python/tests/minreqs.txt | 31 +++++++++++++++++++++++++++++++=0D python/tests/qapi-flake8.sh | 6 ++++++=0D python/tests/qapi-isort.sh | 8 ++++++++=0D python/tests/qapi-mypy.sh | 4 ++++=0D python/tests/qapi-pylint.sh | 8 ++++++++=0D scripts/qapi/.flake8 | 3 ---=0D scripts/qapi/.isort.cfg | 7 -------=0D scripts/qapi/backend.py | 2 ++=0D scripts/qapi/mypy.ini | 4 ----=0D scripts/qapi/pylintrc | 1 +=0D 13 files changed, 78 insertions(+), 28 deletions(-)=0D create mode 100755 python/tests/qapi-flake8.sh=0D create mode 100755 python/tests/qapi-isort.sh=0D create mode 100755 python/tests/qapi-mypy.sh=0D create mode 100755 python/tests/qapi-pylint.sh=0D delete mode 100644 scripts/qapi/.flake8=0D delete mode 100644 scripts/qapi/.isort.cfg=0D delete mode 100644 scripts/qapi/mypy.ini=0D =0D -- =0D 2.48.1=0D =0D