qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>, qemu-devel@nongnu.org
Cc: "Stefan Weil" <sw@weilnetz.de>, "Peter Xu" <peterx@redhat.com>,
	"Fabiano Rosas" <farosas@suse.de>,
	"Hailiang Zhang" <zhanghailiang@xfusion.com>,
	"Phil Dennis-Jordan" <phil@philjordan.eu>,
	devel@daynix.com,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v5 00/13] Improve futex usage
Date: Thu,  5 Jun 2025 15:24:24 +0200	[thread overview]
Message-ID: <20250605132427.404551-1-pbonzini@redhat.com> (raw)
In-Reply-To: <20250529-event-v5-0-53b285203794@daynix.com>

From: Akihiko Odaki <akihiko.odaki@daynix.com>

> In a recent discussion, Phil Dennis-Jordan pointed out a quirk in
> QemuEvent destruction due to futex-like abstraction, which prevented
> the usage of QemuEvent in new and existing code[1]. With some more
> thoughts after this discussion, I also found other problem and room
> of improvement in futex usage. Here is a stack of patches to resolve
> them.

Thanks.  I haven't had the time to go through the final two patches,
so I took the current Linux code unmodified and added the non-Linux
changes on top.  But I have kept the delta locally and will get back
to it.

I also had to squash this in for CI to pass:

diff --git a/meson.build b/meson.build
index 20e8f37e6e7..34729c2a3dd 100644
--- a/meson.build
+++ b/meson.build
@@ -843,7 +843,12 @@ if host_os == 'windows'
   midl = find_program('midl', required: false)
   widl = find_program('widl', required: false)
   pathcch = cc.find_library('pathcch')
-  synchronization = cc.find_library('Synchronization')
+  synchronization = cc.find_library('Synchronization', required: false)
+  if not synchronization.found()
+    # The library name is lowercase on mingw
+    synchronization = cc.find_library('synchronization', required: true)
+  endif
+
   socket = cc.find_library('ws2_32')
   winmm = cc.find_library('winmm')

Paolo



  parent reply	other threads:[~2025-06-05 13:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-29  5:45 [PATCH v5 00/13] Improve futex usage Akihiko Odaki
2025-05-29  5:45 ` [PATCH v5 01/13] futex: Check value after qemu_futex_wait() Akihiko Odaki
2025-05-29  5:45 ` [PATCH v5 02/13] futex: Support Windows Akihiko Odaki
2025-05-29  5:45 ` [PATCH v5 03/13] qemu-thread: Replace __linux__ with CONFIG_LINUX Akihiko Odaki
2025-05-29  5:45 ` [PATCH v5 04/13] qemu-thread: Avoid futex abstraction for non-Linux Akihiko Odaki
2025-05-29  5:45 ` [PATCH v5 05/13] qemu-thread: Use futex for QemuEvent on Windows Akihiko Odaki
2025-05-29  5:45 ` [PATCH v5 06/13] qemu-thread: Use futex if available for QemuLockCnt Akihiko Odaki
2025-05-29  5:45 ` [PATCH v5 07/13] migration: Replace QemuSemaphore with QemuEvent Akihiko Odaki
2025-05-29 14:28   ` Peter Xu
2025-05-29  5:45 ` [PATCH v5 08/13] migration/colo: " Akihiko Odaki
2025-05-29  5:45 ` [PATCH v5 09/13] migration/postcopy: " Akihiko Odaki
2025-05-29  5:45 ` [PATCH v5 10/13] hw/display/apple-gfx: " Akihiko Odaki
2025-05-29  5:46 ` [PATCH v5 11/13] qemu-thread: Remove qatomic_read() in qemu_event_set() Akihiko Odaki
2025-05-29  5:46 ` [PATCH v5 12/13] qemu-thread: Document QemuEvent Akihiko Odaki
2025-05-29  5:46 ` [PATCH v5 13/13] qemu-thread: Document QemuEvent memory ordering Akihiko Odaki
2025-06-05 13:24 ` Paolo Bonzini [this message]
2025-06-06  9:46   ` [PATCH v5 00/13] Improve futex usage Akihiko Odaki
2025-06-06 20:38     ` Paolo Bonzini
2025-06-07  4:35       ` Akihiko Odaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250605132427.404551-1-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=akihiko.odaki@daynix.com \
    --cc=berrange@redhat.com \
    --cc=devel@daynix.com \
    --cc=farosas@suse.de \
    --cc=marcandre.lureau@redhat.com \
    --cc=peterx@redhat.com \
    --cc=phil@philjordan.eu \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    --cc=zhanghailiang@xfusion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).