From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Cleber Rosa <crosa@redhat.com>, John Snow <jsnow@redhat.com>,
Michael Roth <michael.roth@amd.com>,
Peter Maydell <peter.maydell@linaro.org>,
Markus Armbruster <armbru@redhat.com>
Subject: [PULL v2 3/6] python: update missing dependencies from minreqs
Date: Thu, 5 Jun 2025 14:20:11 -0400 [thread overview]
Message-ID: <20250605182014.561172-4-jsnow@redhat.com> (raw)
In-Reply-To: <20250605182014.561172-1-jsnow@redhat.com>
We pin all dependencies for the "check-minreqs" test because pip lacks a
dependency resolver that installs "the oldest possible package that
meets dependency criteria". So, in order to test our stated minimum
requirements, we pin all of our dependencies (and their dependencies,
transitively) at the oldest possible versions that still work and pass
tests; proving that our minimum requirements are correct.
(It also ensures no new features accidentally sneak in from developers
on newer platforms.)
A few transitive dependencies were omitted from the pinned dependency
file by accident; as a result, pip's dependency solver can pull in newer
dependencies, which we don't want. This patch corrects the previous
oversight and pins the missing dependencies.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-id: 20250604200354.459501-4-jsnow@redhat.com
---
python/tests/minreqs.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/python/tests/minreqs.txt b/python/tests/minreqs.txt
index 6445407ba87..d3d53e0da81 100644
--- a/python/tests/minreqs.txt
+++ b/python/tests/minreqs.txt
@@ -38,10 +38,14 @@ pyflakes==2.5.0
# Transitive mypy dependencies
mypy-extensions==1.0.0
+tomli==1.1.0
typing-extensions==4.7.1
# Transitive pylint dependencies
astroid==2.15.4
+dill==0.2
lazy-object-proxy==1.4.0
+platformdirs==2.2.0
toml==0.10.0
+tomlkit==0.10.1
wrapt==1.14.0
--
2.48.1
next prev parent reply other threads:[~2025-06-05 18:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 18:20 [PULL v2 0/6] Python patches John Snow
2025-06-05 18:20 ` [PULL v2 1/6] qapi: Add some pylint ignores John Snow
2025-06-05 18:20 ` [PULL v2 2/6] docs/qapidoc: linting fixes John Snow
2025-06-05 18:20 ` John Snow [this message]
2025-06-05 18:20 ` [PULL v2 4/6] python: add qapi static analysis tests John Snow
2025-06-17 11:44 ` Markus Armbruster
2025-06-17 15:50 ` John Snow
2025-06-05 18:20 ` [PULL v2 5/6] python: Drop redundant warn_unused_configs = True John Snow
2025-06-05 18:20 ` [PULL v2 6/6] qapi: delete un-needed python static analysis configs John Snow
2025-06-06 15:27 ` [PULL v2 0/6] Python patches Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605182014.561172-4-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=michael.roth@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).