From: Zhenzhong Duan <zhenzhong.duan@intel.com>
To: qemu-devel@nongnu.org
Cc: chao.p.peng@intel.com, david@redhat.com, armbru@redhat.com,
Zhenzhong Duan <zhenzhong.duan@intel.com>
Subject: [PATCH v4 0/5] Fix definition of classes with wrong parent
Date: Fri, 6 Jun 2025 17:24:01 +0800 [thread overview]
Message-ID: <20250606092406.229833-1-zhenzhong.duan@intel.com> (raw)
Hi,
This fix definition of some classes with wrong parent.
Used below script to get a list, hoping all are addressed.
find "$directory" -type d \( -name "roms" -o -name "build" \) -prune -o -type f \( -name "*.c" -o -name "*.h" \) -print | while read -r file; do
awk '/^(struct |typedef struct )/ {
first = $0;
getline second;
getline third;
if (first ~ /[Cc]lass/ && !(second ~ /Class/) && !(third ~ /Class/)) {
print FILENAME ":" NR-2 ": " first;
print FILENAME ":" NR-1 ": " second;
print FILENAME ":" NR ": " third;
}
}' "$file"
done
patch4/5 are more like cleanups instead of fixes as those class_size are not
initialized so class definition doesn't take effect, so no Fixes tag for them.
Thanks
Zhenzhong
Changelog:
v4:
- add comments 'this isn't catastrophic only because sizeof(VirtIODevice) >
sizeof(VirtioDeviceClass).' to patch1/2/3 (Markus)
- collect RB for patch5
v3:
- s/Suggested-by/Reported-by on patch2 (David)
- add Closes: tag (David)
- collect RB
v2:
- add more fixes per David
Zhenzhong Duan (5):
virtio-mem: Fix definition of VirtIOMEMClass
virtio-pmem: Fix definition of VirtIOPMEMClass
hw/gpio/aspeed: Fix definition of AspeedGPIOClass
hw/char/sh_serial: Remove dummy definition of SH_SERIAL class
hw/riscv/riscv-iommu: Remove definition of RISCVIOMMU[Pci|Sys]Class
include/hw/gpio/aspeed_gpio.h | 2 +-
include/hw/riscv/iommu.h | 6 ++----
include/hw/virtio/virtio-mem.h | 2 +-
include/hw/virtio/virtio-pmem.h | 2 +-
hw/char/sh_serial.c | 4 +---
hw/riscv/riscv-iommu-pci.c | 6 ------
hw/riscv/riscv-iommu-sys.c | 6 ------
7 files changed, 6 insertions(+), 22 deletions(-)
--
2.34.1
next reply other threads:[~2025-06-06 9:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 9:24 Zhenzhong Duan [this message]
2025-06-06 9:24 ` [PATCH v4 1/5] virtio-mem: Fix definition of VirtIOMEMClass Zhenzhong Duan
2025-06-06 9:24 ` [PATCH v4 2/5] virtio-pmem: Fix definition of VirtIOPMEMClass Zhenzhong Duan
2025-06-06 9:24 ` [PATCH v4 3/5] hw/gpio/aspeed: Fix definition of AspeedGPIOClass Zhenzhong Duan
2025-06-06 9:24 ` [PATCH v4 4/5] hw/char/sh_serial: Remove dummy definition of SH_SERIAL class Zhenzhong Duan
2025-06-06 10:40 ` Philippe Mathieu-Daudé
2025-06-06 10:48 ` Philippe Mathieu-Daudé
2025-06-09 3:06 ` Duan, Zhenzhong
2025-06-06 9:24 ` [PATCH v4 5/5] hw/riscv/riscv-iommu: Remove definition of RISCVIOMMU[Pci|Sys]Class Zhenzhong Duan
2025-06-09 3:43 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250606092406.229833-1-zhenzhong.duan@intel.com \
--to=zhenzhong.duan@intel.com \
--cc=armbru@redhat.com \
--cc=chao.p.peng@intel.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).