Re: [PATCH v2] ramfb: Add property to control if load the romfile

[Alex Williamson <alex.williamson@redhat.com>]

On Mon, 9 Jun 2025 13:16:14 +0800
Shaoqin Huang <shahuang@redhat.com> wrote:

> On 6/6/25 4:07 PM, Cédric Le Goater wrote:
> > On 6/6/25 10:06, Cédric Le Goater wrote:  
> >> On 6/6/25 09:52, Daniel P. Berrangé wrote:  
> >>> On Fri, Jun 06, 2025 at 03:02:34AM -0400, Shaoqin Huang wrote:  
> >>>> Now the ramfb will load the vgabios-ramfb.bin unconditionally, but only
> >>>> the x86 need the vgabios-ramfb.bin, this can cause that when use the
> >>>> release package on arm64 it can't find the vgabios-ramfb.bin.
> >>>>
> >>>> Because only seabios will use the vgabios-ramfb.bin, load the rom logic
> >>>> is x86-specific. For other !x86 platforms, the edk2 ships an EFI driver
> >>>> for ramfb, so they don't need to load the romfile.
> >>>>
> >>>> So add a new property use_legacy_x86_rom in both ramfb and vfio_pci
> >>>> device, because the vfio display also use the ramfb_setup() to load
> >>>> the vgabios-ramfb.bin file.
> >>>>
> >>>> After have this property, the machine type can set the compatibility to
> >>>> not load the vgabios-ramfb.bin if the arch doesn't need it.  
> >>>
> >>> Can you make this a series, with an additional patch that updates the
> >>> current in-dev machine types to use this new property, so we're clear
> >>> about the proposed usage.  
> >>
> >> yes. And please change the vfio-pci property name to use underscores.  
> > 
> > Sorry, to *not* use underscores : use-legacy-x86-rom  
> 
> Thanks for pointing out it. Will fix it.

It's also not evident from the property that this is restricted to
ramfb behavior.  Should the option on the vfio-pci device be prefixed
with ramfb?  Thanks,

Alex