From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Stefan Hajnoczi" <stefanha@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 03/10] tests/functional: Use the 'none' machine for the VNC test
Date: Wed, 11 Jun 2025 14:58:39 +0200 [thread overview]
Message-ID: <20250611125846.125918-4-thuth@redhat.com> (raw)
In-Reply-To: <20250611125846.125918-1-thuth@redhat.com>
From: Thomas Huth <thuth@redhat.com>
The VNC test currently fails if the default machine ("pc" for x86)
has not been compiled into the binary. Since we also can test VNC
when QEMU just shows the default monitor, let's avoid this problem
by simply using the "none" machine (which is always available)
here instead.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20250603103449.32499-1-thuth@redhat.com>
---
tests/functional/test_vnc.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/functional/test_vnc.py b/tests/functional/test_vnc.py
index 5c0ee5f9272..f1dd1597cf1 100755
--- a/tests/functional/test_vnc.py
+++ b/tests/functional/test_vnc.py
@@ -31,6 +31,7 @@ def check_connect(port: int) -> bool:
class Vnc(QemuSystemTest):
def test_no_vnc_change_password(self):
+ self.set_machine('none')
self.vm.add_args('-nodefaults', '-S')
self.vm.launch()
@@ -62,6 +63,7 @@ def launch_guarded(self):
raise excp
def test_change_password_requires_a_password(self):
+ self.set_machine('none')
self.vm.add_args('-nodefaults', '-S', '-vnc', ':1,to=999')
self.launch_guarded()
self.assertTrue(self.vm.qmp('query-vnc')['return']['enabled'])
@@ -74,6 +76,7 @@ def test_change_password_requires_a_password(self):
'Could not set password')
def test_change_password(self):
+ self.set_machine('none')
self.vm.add_args('-nodefaults', '-S', '-vnc', ':1,to=999,password=on')
self.launch_guarded()
self.assertTrue(self.vm.qmp('query-vnc')['return']['enabled'])
@@ -103,6 +106,7 @@ def do_test_change_listen(self, a, b, c):
self.assertTrue(check_connect(c))
def test_change_listen(self):
+ self.set_machine('none')
with Ports() as ports:
a, b, c = ports.find_free_ports(3)
self.do_test_change_listen(a, b, c)
--
2.49.0
next prev parent reply other threads:[~2025-06-11 13:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 12:58 [PULL 00/10] Misc patches (functional tests, travis.yml, MAINTAINERS, ...) Thomas Huth
2025-06-11 12:58 ` [PULL 01/10] travis.yml: Remove the aarch64 job Thomas Huth
2025-06-11 12:58 ` [PULL 02/10] hw/s390x/s390-virtio-ccw: Remove the deprecated 4.1 machine type Thomas Huth
2025-06-11 12:58 ` Thomas Huth [this message]
2025-06-11 12:58 ` [PULL 04/10] tests/functional: Speed up the avr_mega2560 test Thomas Huth
2025-06-11 12:58 ` [PULL 05/10] tests/functional: add skipLockedMemoryTest decorator Thomas Huth
2025-06-11 12:58 ` [PULL 06/10] tests/functional: add memlock tests Thomas Huth
2025-10-24 7:45 ` Philippe Mathieu-Daudé
2025-10-24 7:51 ` Philippe Mathieu-Daudé
2025-06-11 12:58 ` [PULL 07/10] tests/vm/README: fix documentation path in tests/vm/README Thomas Huth
2025-06-11 12:58 ` [PULL 08/10] MAINTAINERS: Update the paths to the testing documentation files Thomas Huth
2025-06-11 12:58 ` [PULL 09/10] MAINTAINERS: Update Akihiko Odaki's affiliation Thomas Huth
2025-06-11 12:58 ` [PULL 10/10] scripts/meson-buildoptions: Sort coroutine_backend choices lexicographically Thomas Huth
2025-06-11 18:22 ` [PULL 00/10] Misc patches (functional tests, travis.yml, MAINTAINERS, ...) Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611125846.125918-4-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).