* [PULL 0/1] Tracing patches @ 2025-06-11 18:29 Stefan Hajnoczi 2025-06-11 18:29 ` [PULL 1/1] meson: fix Windows build Stefan Hajnoczi 0 siblings, 1 reply; 22+ messages in thread From: Stefan Hajnoczi @ 2025-06-11 18:29 UTC (permalink / raw) To: qemu-devel Cc: Mahmoud Mandour, Mads Ynddal, Stefan Hajnoczi, Alexandre Iooss, Pierrick Bouvier, Alex Bennée The following changes since commit bc98ffdc7577e55ab8373c579c28fe24d600c40f: Merge tag 'pull-10.1-maintainer-may-2025-070625-1' of https://gitlab.com/stsquad/qemu into staging (2025-06-07 15:08:55 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 9b8a5fd79df09efa7bfd728ba9e0c95297e42afa: meson: fix Windows build (2025-06-11 14:18:01 -0400) ---------------------------------------------------------------- Pull request ---------------------------------------------------------------- oltolm (1): meson: fix Windows build contrib/plugins/meson.build | 2 +- plugins/meson.build | 2 +- scripts/tracetool/__init__.py | 15 ++++++++++++--- scripts/tracetool/backend/ftrace.py | 4 +--- scripts/tracetool/backend/log.py | 4 +--- scripts/tracetool/backend/syslog.py | 4 +--- tests/functional/meson.build | 4 +--- tests/include/meson.build | 2 +- tests/tcg/plugins/meson.build | 2 +- trace/meson.build | 5 +++-- 10 files changed, 23 insertions(+), 21 deletions(-) -- 2.49.0 ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PULL 1/1] meson: fix Windows build 2025-06-11 18:29 [PULL 0/1] Tracing patches Stefan Hajnoczi @ 2025-06-11 18:29 ` Stefan Hajnoczi 2025-06-11 19:18 ` BALATON Zoltan 0 siblings, 1 reply; 22+ messages in thread From: Stefan Hajnoczi @ 2025-06-11 18:29 UTC (permalink / raw) To: qemu-devel Cc: Mahmoud Mandour, Mads Ynddal, Stefan Hajnoczi, Alexandre Iooss, Pierrick Bouvier, Alex Bennée, oltolm From: oltolm <oleg.tolmatcev@gmail.com> Sorry, I forgot to cc the maintainers. The build failed when run on Windows. I replaced calls to Unix programs like ´cat´, ´sed´ and ´true´ with calls to ´python´. I wrapped calls to ´os.path.relpath´ in try-except because it can fail when the two paths are on different drives. I made sure to convert the Windows paths to Unix paths to prevent warnings in generated files. Signed-off-by: oltolm <oleg.tolmatcev@gmail.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Acked-by: Alex Bennée <alex.bennee@linaro.org> Message-id: 20250607094503.1307-2-oleg.tolmatcev@gmail.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> --- contrib/plugins/meson.build | 2 +- plugins/meson.build | 2 +- scripts/tracetool/__init__.py | 15 ++++++++++++--- scripts/tracetool/backend/ftrace.py | 4 +--- scripts/tracetool/backend/log.py | 4 +--- scripts/tracetool/backend/syslog.py | 4 +--- tests/functional/meson.build | 4 +--- tests/include/meson.build | 2 +- tests/tcg/plugins/meson.build | 2 +- trace/meson.build | 5 +++-- 10 files changed, 23 insertions(+), 21 deletions(-) diff --git a/contrib/plugins/meson.build b/contrib/plugins/meson.build index fa8a426c8b..1876bc7843 100644 --- a/contrib/plugins/meson.build +++ b/contrib/plugins/meson.build @@ -24,7 +24,7 @@ endif if t.length() > 0 alias_target('contrib-plugins', t) else - run_target('contrib-plugins', command: find_program('true')) + run_target('contrib-plugins', command: [python, '-c', '']) endif plugin_modules += t diff --git a/plugins/meson.build b/plugins/meson.build index b20edfbabc..62c991d87f 100644 --- a/plugins/meson.build +++ b/plugins/meson.build @@ -33,7 +33,7 @@ if host_os == 'windows' input: qemu_plugin_symbols, output: 'qemu_plugin_api.def', capture: true, - command: ['sed', '-e', '0,/^/s//EXPORTS/; s/[{};]//g', '@INPUT@']) + command: [python, '-c', 'import fileinput, re; print("EXPORTS", end=""); [print(re.sub(r"[{};]", "", line), end="") for line in fileinput.input()]', '@INPUT@']) # then use dlltool to assemble a delaylib. # The delaylib will have an "imaginary" name (qemu.exe), that is used by the diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index bc03238c0f..6dfcbf71e1 100644 --- a/scripts/tracetool/__init__.py +++ b/scripts/tracetool/__init__.py @@ -12,12 +12,14 @@ __email__ = "stefanha@redhat.com" +import os import re import sys import weakref +from pathlib import PurePath -import tracetool.format import tracetool.backend +import tracetool.format def error_write(*lines): @@ -36,7 +38,7 @@ def error(*lines): def out_open(filename): global out_filename, out_fobj - out_filename = filename + out_filename = posix_relpath(filename) out_fobj = open(filename, 'wt') def out(*lines, **kwargs): @@ -308,7 +310,7 @@ def build(line_str, lineno, filename): fmt = [fmt_trans, fmt] args = Arguments.build(groups["args"]) - return Event(name, props, fmt, args, lineno, filename) + return Event(name, props, fmt, args, lineno, posix_relpath(filename)) def __repr__(self): """Evaluable string representation for this object.""" @@ -447,3 +449,10 @@ def generate(events, group, format, backends, tracetool.backend.dtrace.PROBEPREFIX = probe_prefix tracetool.format.generate(events, format, backend, group) + +def posix_relpath(path, start=None): + try: + path = os.path.relpath(path, start) + except ValueError: + pass + return PurePath(path).as_posix() diff --git a/scripts/tracetool/backend/ftrace.py b/scripts/tracetool/backend/ftrace.py index baed2ae61c..5fa30ccc08 100644 --- a/scripts/tracetool/backend/ftrace.py +++ b/scripts/tracetool/backend/ftrace.py @@ -12,8 +12,6 @@ __email__ = "stefanha@redhat.com" -import os.path - from tracetool import out @@ -47,7 +45,7 @@ def generate_h(event, group): args=event.args, event_id="TRACE_" + event.name.upper(), event_lineno=event.lineno, - event_filename=os.path.relpath(event.filename), + event_filename=event.filename, fmt=event.fmt.rstrip("\n"), argnames=argnames) diff --git a/scripts/tracetool/backend/log.py b/scripts/tracetool/backend/log.py index de27b7e62e..17ba1cd90e 100644 --- a/scripts/tracetool/backend/log.py +++ b/scripts/tracetool/backend/log.py @@ -12,8 +12,6 @@ __email__ = "stefanha@redhat.com" -import os.path - from tracetool import out @@ -55,7 +53,7 @@ def generate_h(event, group): ' }', cond=cond, event_lineno=event.lineno, - event_filename=os.path.relpath(event.filename), + event_filename=event.filename, name=event.name, fmt=event.fmt.rstrip("\n"), argnames=argnames) diff --git a/scripts/tracetool/backend/syslog.py b/scripts/tracetool/backend/syslog.py index 012970f6cc..5a3a00fe31 100644 --- a/scripts/tracetool/backend/syslog.py +++ b/scripts/tracetool/backend/syslog.py @@ -12,8 +12,6 @@ __email__ = "stefanha@redhat.com" -import os.path - from tracetool import out @@ -43,7 +41,7 @@ def generate_h(event, group): ' }', cond=cond, event_lineno=event.lineno, - event_filename=os.path.relpath(event.filename), + event_filename=event.filename, name=event.name, fmt=event.fmt.rstrip("\n"), argnames=argnames) diff --git a/tests/functional/meson.build b/tests/functional/meson.build index 557d59ddf4..4bce961c04 100644 --- a/tests/functional/meson.build +++ b/tests/functional/meson.build @@ -412,6 +412,4 @@ foreach speed : ['quick', 'thorough'] endforeach endforeach -run_target('precache-functional', - depends: precache_all, - command: ['true']) +alias_target('precache-functional', precache_all) diff --git a/tests/include/meson.build b/tests/include/meson.build index 9abba308fa..8e8d1ec4e6 100644 --- a/tests/include/meson.build +++ b/tests/include/meson.build @@ -13,4 +13,4 @@ test_qapi_outputs_extra = [ test_qapi_files_extra = custom_target('QAPI test (include)', output: test_qapi_outputs_extra, input: test_qapi_files, - command: 'true') + command: [python, '-c', '']) diff --git a/tests/tcg/plugins/meson.build b/tests/tcg/plugins/meson.build index 41f02f2c7f..029342282a 100644 --- a/tests/tcg/plugins/meson.build +++ b/tests/tcg/plugins/meson.build @@ -17,7 +17,7 @@ endif if t.length() > 0 alias_target('test-plugins', t) else - run_target('test-plugins', command: find_program('true')) + run_target('test-plugins', command: [python, '-c', '']) endif plugin_modules += t diff --git a/trace/meson.build b/trace/meson.build index 3df4549355..9c42a57a05 100644 --- a/trace/meson.build +++ b/trace/meson.build @@ -4,7 +4,7 @@ trace_events_files = [] foreach item : [ '.' ] + trace_events_subdirs + qapi_trace_events if item in qapi_trace_events trace_events_file = item - group_name = item.full_path().split('/')[-1].underscorify() + group_name = fs.name(item).underscorify() else trace_events_file = meson.project_source_root() / item / 'trace-events' group_name = item == '.' ? 'root' : item.underscorify() @@ -57,10 +57,11 @@ foreach item : [ '.' ] + trace_events_subdirs + qapi_trace_events endif endforeach +cat = [ python, '-c', 'import fileinput; [print(line, end="") for line in fileinput.input()]', '@INPUT@' ] trace_events_all = custom_target('trace-events-all', output: 'trace-events-all', input: trace_events_files, - command: [ 'cat', '@INPUT@' ], + command: cat, capture: true, install: get_option('trace_backends') != [ 'nop' ], install_dir: qemu_datadir) -- 2.49.0 ^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PULL 1/1] meson: fix Windows build 2025-06-11 18:29 ` [PULL 1/1] meson: fix Windows build Stefan Hajnoczi @ 2025-06-11 19:18 ` BALATON Zoltan 2025-06-11 19:54 ` Stefan Hajnoczi 0 siblings, 1 reply; 22+ messages in thread From: BALATON Zoltan @ 2025-06-11 19:18 UTC (permalink / raw) To: Stefan Hajnoczi Cc: qemu-devel, Mahmoud Mandour, Mads Ynddal, Alexandre Iooss, Pierrick Bouvier, Alex Bennée, oltolm [-- Attachment #1: Type: TEXT/PLAIN, Size: 9341 bytes --] On Wed, 11 Jun 2025, Stefan Hajnoczi wrote: > From: oltolm <oleg.tolmatcev@gmail.com> > > Sorry, I forgot to cc the maintainers. Do we want comments like this end up in git log? This could have been fixed before a pull. Also the other pull request about uninitialised stack variables had hw/audio/gus twice which was pointed out by a comment before the pull that one of those should be different but the pull request still had this error. Did you miss these or aren't these important enough to fix before getting in git log forever or there is just no easy way to fix up commit messages in pull requests? Regards, BALATON Zoltan > The build failed when run on Windows. I replaced calls to Unix programs > like ´cat´, ´sed´ and ´true´ with calls to ´python´. I wrapped calls to > ´os.path.relpath´ in try-except because it can fail when the two paths > are on different drives. I made sure to convert the Windows paths to > Unix paths to prevent warnings in generated files. > > Signed-off-by: oltolm <oleg.tolmatcev@gmail.com> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> > Acked-by: Alex Bennée <alex.bennee@linaro.org> > Message-id: 20250607094503.1307-2-oleg.tolmatcev@gmail.com > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > contrib/plugins/meson.build | 2 +- > plugins/meson.build | 2 +- > scripts/tracetool/__init__.py | 15 ++++++++++++--- > scripts/tracetool/backend/ftrace.py | 4 +--- > scripts/tracetool/backend/log.py | 4 +--- > scripts/tracetool/backend/syslog.py | 4 +--- > tests/functional/meson.build | 4 +--- > tests/include/meson.build | 2 +- > tests/tcg/plugins/meson.build | 2 +- > trace/meson.build | 5 +++-- > 10 files changed, 23 insertions(+), 21 deletions(-) > > diff --git a/contrib/plugins/meson.build b/contrib/plugins/meson.build > index fa8a426c8b..1876bc7843 100644 > --- a/contrib/plugins/meson.build > +++ b/contrib/plugins/meson.build > @@ -24,7 +24,7 @@ endif > if t.length() > 0 > alias_target('contrib-plugins', t) > else > - run_target('contrib-plugins', command: find_program('true')) > + run_target('contrib-plugins', command: [python, '-c', '']) > endif > > plugin_modules += t > diff --git a/plugins/meson.build b/plugins/meson.build > index b20edfbabc..62c991d87f 100644 > --- a/plugins/meson.build > +++ b/plugins/meson.build > @@ -33,7 +33,7 @@ if host_os == 'windows' > input: qemu_plugin_symbols, > output: 'qemu_plugin_api.def', > capture: true, > - command: ['sed', '-e', '0,/^/s//EXPORTS/; s/[{};]//g', '@INPUT@']) > + command: [python, '-c', 'import fileinput, re; print("EXPORTS", end=""); [print(re.sub(r"[{};]", "", line), end="") for line in fileinput.input()]', '@INPUT@']) > > # then use dlltool to assemble a delaylib. > # The delaylib will have an "imaginary" name (qemu.exe), that is used by the > diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py > index bc03238c0f..6dfcbf71e1 100644 > --- a/scripts/tracetool/__init__.py > +++ b/scripts/tracetool/__init__.py > @@ -12,12 +12,14 @@ > __email__ = "stefanha@redhat.com" > > > +import os > import re > import sys > import weakref > +from pathlib import PurePath > > -import tracetool.format > import tracetool.backend > +import tracetool.format > > > def error_write(*lines): > @@ -36,7 +38,7 @@ def error(*lines): > > def out_open(filename): > global out_filename, out_fobj > - out_filename = filename > + out_filename = posix_relpath(filename) > out_fobj = open(filename, 'wt') > > def out(*lines, **kwargs): > @@ -308,7 +310,7 @@ def build(line_str, lineno, filename): > fmt = [fmt_trans, fmt] > args = Arguments.build(groups["args"]) > > - return Event(name, props, fmt, args, lineno, filename) > + return Event(name, props, fmt, args, lineno, posix_relpath(filename)) > > def __repr__(self): > """Evaluable string representation for this object.""" > @@ -447,3 +449,10 @@ def generate(events, group, format, backends, > tracetool.backend.dtrace.PROBEPREFIX = probe_prefix > > tracetool.format.generate(events, format, backend, group) > + > +def posix_relpath(path, start=None): > + try: > + path = os.path.relpath(path, start) > + except ValueError: > + pass > + return PurePath(path).as_posix() > diff --git a/scripts/tracetool/backend/ftrace.py b/scripts/tracetool/backend/ftrace.py > index baed2ae61c..5fa30ccc08 100644 > --- a/scripts/tracetool/backend/ftrace.py > +++ b/scripts/tracetool/backend/ftrace.py > @@ -12,8 +12,6 @@ > __email__ = "stefanha@redhat.com" > > > -import os.path > - > from tracetool import out > > > @@ -47,7 +45,7 @@ def generate_h(event, group): > args=event.args, > event_id="TRACE_" + event.name.upper(), > event_lineno=event.lineno, > - event_filename=os.path.relpath(event.filename), > + event_filename=event.filename, > fmt=event.fmt.rstrip("\n"), > argnames=argnames) > > diff --git a/scripts/tracetool/backend/log.py b/scripts/tracetool/backend/log.py > index de27b7e62e..17ba1cd90e 100644 > --- a/scripts/tracetool/backend/log.py > +++ b/scripts/tracetool/backend/log.py > @@ -12,8 +12,6 @@ > __email__ = "stefanha@redhat.com" > > > -import os.path > - > from tracetool import out > > > @@ -55,7 +53,7 @@ def generate_h(event, group): > ' }', > cond=cond, > event_lineno=event.lineno, > - event_filename=os.path.relpath(event.filename), > + event_filename=event.filename, > name=event.name, > fmt=event.fmt.rstrip("\n"), > argnames=argnames) > diff --git a/scripts/tracetool/backend/syslog.py b/scripts/tracetool/backend/syslog.py > index 012970f6cc..5a3a00fe31 100644 > --- a/scripts/tracetool/backend/syslog.py > +++ b/scripts/tracetool/backend/syslog.py > @@ -12,8 +12,6 @@ > __email__ = "stefanha@redhat.com" > > > -import os.path > - > from tracetool import out > > > @@ -43,7 +41,7 @@ def generate_h(event, group): > ' }', > cond=cond, > event_lineno=event.lineno, > - event_filename=os.path.relpath(event.filename), > + event_filename=event.filename, > name=event.name, > fmt=event.fmt.rstrip("\n"), > argnames=argnames) > diff --git a/tests/functional/meson.build b/tests/functional/meson.build > index 557d59ddf4..4bce961c04 100644 > --- a/tests/functional/meson.build > +++ b/tests/functional/meson.build > @@ -412,6 +412,4 @@ foreach speed : ['quick', 'thorough'] > endforeach > endforeach > > -run_target('precache-functional', > - depends: precache_all, > - command: ['true']) > +alias_target('precache-functional', precache_all) > diff --git a/tests/include/meson.build b/tests/include/meson.build > index 9abba308fa..8e8d1ec4e6 100644 > --- a/tests/include/meson.build > +++ b/tests/include/meson.build > @@ -13,4 +13,4 @@ test_qapi_outputs_extra = [ > test_qapi_files_extra = custom_target('QAPI test (include)', > output: test_qapi_outputs_extra, > input: test_qapi_files, > - command: 'true') > + command: [python, '-c', '']) > diff --git a/tests/tcg/plugins/meson.build b/tests/tcg/plugins/meson.build > index 41f02f2c7f..029342282a 100644 > --- a/tests/tcg/plugins/meson.build > +++ b/tests/tcg/plugins/meson.build > @@ -17,7 +17,7 @@ endif > if t.length() > 0 > alias_target('test-plugins', t) > else > - run_target('test-plugins', command: find_program('true')) > + run_target('test-plugins', command: [python, '-c', '']) > endif > > plugin_modules += t > diff --git a/trace/meson.build b/trace/meson.build > index 3df4549355..9c42a57a05 100644 > --- a/trace/meson.build > +++ b/trace/meson.build > @@ -4,7 +4,7 @@ trace_events_files = [] > foreach item : [ '.' ] + trace_events_subdirs + qapi_trace_events > if item in qapi_trace_events > trace_events_file = item > - group_name = item.full_path().split('/')[-1].underscorify() > + group_name = fs.name(item).underscorify() > else > trace_events_file = meson.project_source_root() / item / 'trace-events' > group_name = item == '.' ? 'root' : item.underscorify() > @@ -57,10 +57,11 @@ foreach item : [ '.' ] + trace_events_subdirs + qapi_trace_events > endif > endforeach > > +cat = [ python, '-c', 'import fileinput; [print(line, end="") for line in fileinput.input()]', '@INPUT@' ] > trace_events_all = custom_target('trace-events-all', > output: 'trace-events-all', > input: trace_events_files, > - command: [ 'cat', '@INPUT@' ], > + command: cat, > capture: true, > install: get_option('trace_backends') != [ 'nop' ], > install_dir: qemu_datadir) > -- > 2.49.0 > > > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PULL 1/1] meson: fix Windows build 2025-06-11 19:18 ` BALATON Zoltan @ 2025-06-11 19:54 ` Stefan Hajnoczi 2025-06-11 22:42 ` BALATON Zoltan 2025-06-12 8:59 ` Peter Maydell 0 siblings, 2 replies; 22+ messages in thread From: Stefan Hajnoczi @ 2025-06-11 19:54 UTC (permalink / raw) To: BALATON Zoltan Cc: Stefan Hajnoczi, qemu-devel, Mahmoud Mandour, Mads Ynddal, Alexandre Iooss, Pierrick Bouvier, Alex Bennée, oltolm On Wed, Jun 11, 2025 at 3:25 PM BALATON Zoltan <balaton@eik.bme.hu> wrote: > > On Wed, 11 Jun 2025, Stefan Hajnoczi wrote: > > From: oltolm <oleg.tolmatcev@gmail.com> > > > > Sorry, I forgot to cc the maintainers. > > Do we want comments like this end up in git log? This could have been > fixed before a pull. Also the other pull request about uninitialised stack > variables had hw/audio/gus twice which was pointed out by a comment before > the pull that one of those should be different but the pull request still > had this error. Did you miss these or aren't these important enough to fix > before getting in git log forever or there is just no easy way to fix up > commit messages in pull requests? If another reviewer asks for the author to resend then I'll hold off on merging, but I didn't see the comment about hw/audio/gus. Sorry! I did see this "Sorry, I forgot to cc the maintainers" comment. Although I'm not consistent, nowadays I generally do not fix these issues when merging, provided it's a small issue that can be ignored or understood from the context. I don't really mind either way, so if there is a consensus that all maintainers should be strict about this, I'm happy to join. One related point I do have a strong opinion on is that the qemu.git/master maintainer shouldn't be expected to do fixups on a pull request they receive. Fixups should be done by subsystem maintainers (and the pull request must be resent) or the original patch authors. It doesn't scale when the qemu.git/master maintainer has to make changes to code that they are unfamiliar with. That's not the case here, but I just wanted to mention it because from time to time someone requests this. > > Regards, > BALATON Zoltan > > > The build failed when run on Windows. I replaced calls to Unix programs > > like ´cat´, ´sed´ and ´true´ with calls to ´python´. I wrapped calls to > > ´os.path.relpath´ in try-except because it can fail when the two paths > > are on different drives. I made sure to convert the Windows paths to > > Unix paths to prevent warnings in generated files. > > > > Signed-off-by: oltolm <oleg.tolmatcev@gmail.com> > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> > > Acked-by: Alex Bennée <alex.bennee@linaro.org> > > Message-id: 20250607094503.1307-2-oleg.tolmatcev@gmail.com > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > > --- > > contrib/plugins/meson.build | 2 +- > > plugins/meson.build | 2 +- > > scripts/tracetool/__init__.py | 15 ++++++++++++--- > > scripts/tracetool/backend/ftrace.py | 4 +--- > > scripts/tracetool/backend/log.py | 4 +--- > > scripts/tracetool/backend/syslog.py | 4 +--- > > tests/functional/meson.build | 4 +--- > > tests/include/meson.build | 2 +- > > tests/tcg/plugins/meson.build | 2 +- > > trace/meson.build | 5 +++-- > > 10 files changed, 23 insertions(+), 21 deletions(-) > > > > diff --git a/contrib/plugins/meson.build b/contrib/plugins/meson.build > > index fa8a426c8b..1876bc7843 100644 > > --- a/contrib/plugins/meson.build > > +++ b/contrib/plugins/meson.build > > @@ -24,7 +24,7 @@ endif > > if t.length() > 0 > > alias_target('contrib-plugins', t) > > else > > - run_target('contrib-plugins', command: find_program('true')) > > + run_target('contrib-plugins', command: [python, '-c', '']) > > endif > > > > plugin_modules += t > > diff --git a/plugins/meson.build b/plugins/meson.build > > index b20edfbabc..62c991d87f 100644 > > --- a/plugins/meson.build > > +++ b/plugins/meson.build > > @@ -33,7 +33,7 @@ if host_os == 'windows' > > input: qemu_plugin_symbols, > > output: 'qemu_plugin_api.def', > > capture: true, > > - command: ['sed', '-e', '0,/^/s//EXPORTS/; s/[{};]//g', '@INPUT@']) > > + command: [python, '-c', 'import fileinput, re; print("EXPORTS", end=""); [print(re.sub(r"[{};]", "", line), end="") for line in fileinput.input()]', '@INPUT@']) > > > > # then use dlltool to assemble a delaylib. > > # The delaylib will have an "imaginary" name (qemu.exe), that is used by the > > diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py > > index bc03238c0f..6dfcbf71e1 100644 > > --- a/scripts/tracetool/__init__.py > > +++ b/scripts/tracetool/__init__.py > > @@ -12,12 +12,14 @@ > > __email__ = "stefanha@redhat.com" > > > > > > +import os > > import re > > import sys > > import weakref > > +from pathlib import PurePath > > > > -import tracetool.format > > import tracetool.backend > > +import tracetool.format > > > > > > def error_write(*lines): > > @@ -36,7 +38,7 @@ def error(*lines): > > > > def out_open(filename): > > global out_filename, out_fobj > > - out_filename = filename > > + out_filename = posix_relpath(filename) > > out_fobj = open(filename, 'wt') > > > > def out(*lines, **kwargs): > > @@ -308,7 +310,7 @@ def build(line_str, lineno, filename): > > fmt = [fmt_trans, fmt] > > args = Arguments.build(groups["args"]) > > > > - return Event(name, props, fmt, args, lineno, filename) > > + return Event(name, props, fmt, args, lineno, posix_relpath(filename)) > > > > def __repr__(self): > > """Evaluable string representation for this object.""" > > @@ -447,3 +449,10 @@ def generate(events, group, format, backends, > > tracetool.backend.dtrace.PROBEPREFIX = probe_prefix > > > > tracetool.format.generate(events, format, backend, group) > > + > > +def posix_relpath(path, start=None): > > + try: > > + path = os.path.relpath(path, start) > > + except ValueError: > > + pass > > + return PurePath(path).as_posix() > > diff --git a/scripts/tracetool/backend/ftrace.py b/scripts/tracetool/backend/ftrace.py > > index baed2ae61c..5fa30ccc08 100644 > > --- a/scripts/tracetool/backend/ftrace.py > > +++ b/scripts/tracetool/backend/ftrace.py > > @@ -12,8 +12,6 @@ > > __email__ = "stefanha@redhat.com" > > > > > > -import os.path > > - > > from tracetool import out > > > > > > @@ -47,7 +45,7 @@ def generate_h(event, group): > > args=event.args, > > event_id="TRACE_" + event.name.upper(), > > event_lineno=event.lineno, > > - event_filename=os.path.relpath(event.filename), > > + event_filename=event.filename, > > fmt=event.fmt.rstrip("\n"), > > argnames=argnames) > > > > diff --git a/scripts/tracetool/backend/log.py b/scripts/tracetool/backend/log.py > > index de27b7e62e..17ba1cd90e 100644 > > --- a/scripts/tracetool/backend/log.py > > +++ b/scripts/tracetool/backend/log.py > > @@ -12,8 +12,6 @@ > > __email__ = "stefanha@redhat.com" > > > > > > -import os.path > > - > > from tracetool import out > > > > > > @@ -55,7 +53,7 @@ def generate_h(event, group): > > ' }', > > cond=cond, > > event_lineno=event.lineno, > > - event_filename=os.path.relpath(event.filename), > > + event_filename=event.filename, > > name=event.name, > > fmt=event.fmt.rstrip("\n"), > > argnames=argnames) > > diff --git a/scripts/tracetool/backend/syslog.py b/scripts/tracetool/backend/syslog.py > > index 012970f6cc..5a3a00fe31 100644 > > --- a/scripts/tracetool/backend/syslog.py > > +++ b/scripts/tracetool/backend/syslog.py > > @@ -12,8 +12,6 @@ > > __email__ = "stefanha@redhat.com" > > > > > > -import os.path > > - > > from tracetool import out > > > > > > @@ -43,7 +41,7 @@ def generate_h(event, group): > > ' }', > > cond=cond, > > event_lineno=event.lineno, > > - event_filename=os.path.relpath(event.filename), > > + event_filename=event.filename, > > name=event.name, > > fmt=event.fmt.rstrip("\n"), > > argnames=argnames) > > diff --git a/tests/functional/meson.build b/tests/functional/meson.build > > index 557d59ddf4..4bce961c04 100644 > > --- a/tests/functional/meson.build > > +++ b/tests/functional/meson.build > > @@ -412,6 +412,4 @@ foreach speed : ['quick', 'thorough'] > > endforeach > > endforeach > > > > -run_target('precache-functional', > > - depends: precache_all, > > - command: ['true']) > > +alias_target('precache-functional', precache_all) > > diff --git a/tests/include/meson.build b/tests/include/meson.build > > index 9abba308fa..8e8d1ec4e6 100644 > > --- a/tests/include/meson.build > > +++ b/tests/include/meson.build > > @@ -13,4 +13,4 @@ test_qapi_outputs_extra = [ > > test_qapi_files_extra = custom_target('QAPI test (include)', > > output: test_qapi_outputs_extra, > > input: test_qapi_files, > > - command: 'true') > > + command: [python, '-c', '']) > > diff --git a/tests/tcg/plugins/meson.build b/tests/tcg/plugins/meson.build > > index 41f02f2c7f..029342282a 100644 > > --- a/tests/tcg/plugins/meson.build > > +++ b/tests/tcg/plugins/meson.build > > @@ -17,7 +17,7 @@ endif > > if t.length() > 0 > > alias_target('test-plugins', t) > > else > > - run_target('test-plugins', command: find_program('true')) > > + run_target('test-plugins', command: [python, '-c', '']) > > endif > > > > plugin_modules += t > > diff --git a/trace/meson.build b/trace/meson.build > > index 3df4549355..9c42a57a05 100644 > > --- a/trace/meson.build > > +++ b/trace/meson.build > > @@ -4,7 +4,7 @@ trace_events_files = [] > > foreach item : [ '.' ] + trace_events_subdirs + qapi_trace_events > > if item in qapi_trace_events > > trace_events_file = item > > - group_name = item.full_path().split('/')[-1].underscorify() > > + group_name = fs.name(item).underscorify() > > else > > trace_events_file = meson.project_source_root() / item / 'trace-events' > > group_name = item == '.' ? 'root' : item.underscorify() > > @@ -57,10 +57,11 @@ foreach item : [ '.' ] + trace_events_subdirs + qapi_trace_events > > endif > > endforeach > > > > +cat = [ python, '-c', 'import fileinput; [print(line, end="") for line in fileinput.input()]', '@INPUT@' ] > > trace_events_all = custom_target('trace-events-all', > > output: 'trace-events-all', > > input: trace_events_files, > > - command: [ 'cat', '@INPUT@' ], > > + command: cat, > > capture: true, > > install: get_option('trace_backends') != [ 'nop' ], > > install_dir: qemu_datadir) > > -- > > 2.49.0 > > > > > > ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PULL 1/1] meson: fix Windows build 2025-06-11 19:54 ` Stefan Hajnoczi @ 2025-06-11 22:42 ` BALATON Zoltan 2025-06-12 8:59 ` Peter Maydell 1 sibling, 0 replies; 22+ messages in thread From: BALATON Zoltan @ 2025-06-11 22:42 UTC (permalink / raw) To: Stefan Hajnoczi Cc: Stefan Hajnoczi, qemu-devel, Mahmoud Mandour, Mads Ynddal, Alexandre Iooss, Pierrick Bouvier, Alex Bennée, oltolm [-- Attachment #1: Type: text/plain, Size: 1615 bytes --] On Wed, 11 Jun 2025, Stefan Hajnoczi wrote: > On Wed, Jun 11, 2025 at 3:25 PM BALATON Zoltan <balaton@eik.bme.hu> wrote: >> >> On Wed, 11 Jun 2025, Stefan Hajnoczi wrote: >>> From: oltolm <oleg.tolmatcev@gmail.com> >>> >>> Sorry, I forgot to cc the maintainers. >> >> Do we want comments like this end up in git log? This could have been >> fixed before a pull. Also the other pull request about uninitialised stack >> variables had hw/audio/gus twice which was pointed out by a comment before >> the pull that one of those should be different but the pull request still >> had this error. Did you miss these or aren't these important enough to fix >> before getting in git log forever or there is just no easy way to fix up >> commit messages in pull requests? > > If another reviewer asks for the author to resend then I'll hold off > on merging, but I didn't see the comment about hw/audio/gus. Sorry! > > I did see this "Sorry, I forgot to cc the maintainers" comment. > Although I'm not consistent, nowadays I generally do not fix these > issues when merging, provided it's a small issue that can be ignored > or understood from the context. > > I don't really mind either way, so if there is a consensus that all > maintainers should be strict about this, I'm happy to join. I wouldn't ask maintainers to fixup commits regularly, especially changing the patch itself would need resend from the author but for small typos in commit message only it might be OK to fix them up on commit if noticed before a pull. Just because if these aren't fixed they will be in git log forever. Regards, BALATON Zoltan ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PULL 1/1] meson: fix Windows build 2025-06-11 19:54 ` Stefan Hajnoczi 2025-06-11 22:42 ` BALATON Zoltan @ 2025-06-12 8:59 ` Peter Maydell 1 sibling, 0 replies; 22+ messages in thread From: Peter Maydell @ 2025-06-12 8:59 UTC (permalink / raw) To: Stefan Hajnoczi Cc: BALATON Zoltan, Stefan Hajnoczi, qemu-devel, Mahmoud Mandour, Mads Ynddal, Alexandre Iooss, Pierrick Bouvier, Alex Bennée, oltolm On Wed, 11 Jun 2025 at 20:55, Stefan Hajnoczi <stefanha@gmail.com> wrote: > > On Wed, Jun 11, 2025 at 3:25 PM BALATON Zoltan <balaton@eik.bme.hu> wrote: > > > > On Wed, 11 Jun 2025, Stefan Hajnoczi wrote: > > > From: oltolm <oleg.tolmatcev@gmail.com> > > > > > > Sorry, I forgot to cc the maintainers. > > > > Do we want comments like this end up in git log? This could have been > > fixed before a pull. Also the other pull request about uninitialised stack > > variables had hw/audio/gus twice which was pointed out by a comment before > > the pull that one of those should be different but the pull request still > > had this error. Did you miss these or aren't these important enough to fix > > before getting in git log forever or there is just no easy way to fix up > > commit messages in pull requests? > > If another reviewer asks for the author to resend then I'll hold off > on merging, but I didn't see the comment about hw/audio/gus. Sorry! > > I did see this "Sorry, I forgot to cc the maintainers" comment. > Although I'm not consistent, nowadays I generally do not fix these > issues when merging, provided it's a small issue that can be ignored > or understood from the context. > > I don't really mind either way, so if there is a consensus that all > maintainers should be strict about this, I'm happy to join. Personally when I'm accumulating patches as a maintainer I do fix up this kind of commit message. It's generally from a first time contributor, so the commit needs closer attention anyway, and I favour just fixing "this isn't quite the way we usually do things" problems at my end, rather than asking the submitter to resend. I also fix nits from longer term contributors where it's faster to do that than to ask for a respin. In this specific case I'd probably re-cast the commit message entirely, because the first-person past-tense phrasing is not our standard commit log style. I would also want to add something clarifying exactly what we're fixing (clearly "the Windows build" generally was not broken, or we'd have seen it in CI, so this is fixing a more niche build environment setup, and it's worth having the commit message be clear about what that setup is). > One related point I do have a strong opinion on is that the > qemu.git/master maintainer shouldn't be expected to do fixups on a > pull request they receive. Fixups should be done by subsystem > maintainers (and the pull request must be resent) or the original > patch authors. It doesn't scale when the qemu.git/master maintainer > has to make changes to code that they are unfamiliar with. That's not > the case here, but I just wanted to mention it because from time to > time someone requests this. Fixing up a pullreq is also basically not possible -- the pullreq is signed and you can't change the commits in it. I don't recommend throwing random fixes (as opposed to genuine simple merge conflict fixes) into the merge commit. thanks -- PMM ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PULL 0/1] Tracing patches @ 2025-07-24 14:46 Stefan Hajnoczi 2025-07-25 15:25 ` Stefan Hajnoczi 0 siblings, 1 reply; 22+ messages in thread From: Stefan Hajnoczi @ 2025-07-24 14:46 UTC (permalink / raw) To: qemu-devel Cc: Pierrick Bouvier, Mahmoud Mandour, Mads Ynddal, Alexandre Iooss, Stefan Hajnoczi, Alex Bennée The following changes since commit 9e601684dc24a521bb1d23215a63e5c6e79ea0bb: Update version for the v10.1.0-rc0 release (2025-07-22 15:48:48 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 012842c075520dbe1bd96a2fdcf4e218874ba443: log: make '-msg timestamp=on' apply to all qemu_log usage (2025-07-24 10:12:21 -0400) ---------------------------------------------------------------- Pull request This commit is still worth having in QEMU 10.1 for the all-round improvements made (consistent timestamping, binary size reduction, header pollution cleanup) even if it's debatable whether this is a bug fix. ---------------------------------------------------------------- Daniel P. Berrangé (1): log: make '-msg timestamp=on' apply to all qemu_log usage util/log.c | 20 +++++++++++++++++++- scripts/tracetool/backend/log.py | 14 +------------- 2 files changed, 20 insertions(+), 14 deletions(-) -- 2.50.1 ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PULL 0/1] Tracing patches 2025-07-24 14:46 [PULL 0/1] Tracing patches Stefan Hajnoczi @ 2025-07-25 15:25 ` Stefan Hajnoczi 0 siblings, 0 replies; 22+ messages in thread From: Stefan Hajnoczi @ 2025-07-25 15:25 UTC (permalink / raw) To: Stefan Hajnoczi Cc: qemu-devel, Pierrick Bouvier, Mahmoud Mandour, Mads Ynddal, Alexandre Iooss, Stefan Hajnoczi, Alex Bennée [-- Attachment #1: Type: text/plain, Size: 116 bytes --] Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PULL 0/1] Tracing patches @ 2025-07-22 15:03 Stefan Hajnoczi 0 siblings, 0 replies; 22+ messages in thread From: Stefan Hajnoczi @ 2025-07-22 15:03 UTC (permalink / raw) To: qemu-devel Cc: Pierrick Bouvier, Mads Ynddal, Alex Bennée, Mahmoud Mandour, Stefan Hajnoczi, Alexandre Iooss The following changes since commit ebcc602aae19c06a4f492da3920b64c8033f0d7f: Merge tag 'display-20250718-pull-request' of https://gitlab.com/kraxel/qemu into staging (2025-07-21 12:24:36 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 2b1791323e7ce043cbc3857699e5d5b0ad021cbc: tracetool: removed the unused vcpu property (2025-07-22 10:44:49 -0400) ---------------------------------------------------------------- Pull request Tanish's removal of the remnants of the "vcpu" property. ---------------------------------------------------------------- Tanish Desai (1): tracetool: removed the unused vcpu property scripts/tracetool/__init__.py | 2 +- scripts/tracetool/backend/log.py | 6 +----- scripts/tracetool/backend/simple.py | 6 +----- scripts/tracetool/backend/syslog.py | 6 +----- 4 files changed, 4 insertions(+), 16 deletions(-) -- 2.50.1 ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PULL 0/1] Tracing patches @ 2025-07-21 18:10 Stefan Hajnoczi 0 siblings, 0 replies; 22+ messages in thread From: Stefan Hajnoczi @ 2025-07-21 18:10 UTC (permalink / raw) To: qemu-devel Cc: Pierrick Bouvier, Mahmoud Mandour, Stefan Hajnoczi, Alexandre Iooss, Alex Bennée, Mads Ynddal The following changes since commit 56a3033abcfcf72a2f4f1376a605a0b1ad526b67: Merge tag 'pull-request-2025-07-21' of https://gitlab.com/thuth/qemu into staging (2025-07-21 06:34:56 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 50700e97d85e435363ca4525754b5f00b13491c0: trace: log.py: human-readable timestamp (2025-07-21 14:02:52 -0400) ---------------------------------------------------------------- Pull request ---------------------------------------------------------------- Vladimir Sementsov-Ogievskiy (1): trace: log.py: human-readable timestamp scripts/tracetool/backend/log.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) -- 2.50.1 ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PULL 0/1] Tracing patches @ 2025-06-02 22:29 Stefan Hajnoczi 2025-06-03 15:51 ` Stefan Hajnoczi 0 siblings, 1 reply; 22+ messages in thread From: Stefan Hajnoczi @ 2025-06-02 22:29 UTC (permalink / raw) To: qemu-devel; +Cc: Stefan Hajnoczi, Mads Ynddal The following changes since commit 6322b753f798337835e205b6d805356bea582c86: Merge tag 'for_upstream' of https://git.kernel.org/pub/scm/virt/kvm/mst/qemu into staging (2025-06-02 14:52:45 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to ffcfb0faaa95fc6ca007f7dd989e390dacf936ca: trace/simple: seperate hot paths of tracing fucntions (2025-06-02 16:51:36 -0400) ---------------------------------------------------------------- Pull request ---------------------------------------------------------------- Tanish Desai (1): trace/simple: seperate hot paths of tracing fucntions scripts/tracetool/backend/simple.py | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) -- 2.49.0 ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PULL 0/1] Tracing patches 2025-06-02 22:29 Stefan Hajnoczi @ 2025-06-03 15:51 ` Stefan Hajnoczi 0 siblings, 0 replies; 22+ messages in thread From: Stefan Hajnoczi @ 2025-06-03 15:51 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: qemu-devel, Stefan Hajnoczi, Mads Ynddal [-- Attachment #1: Type: text/plain, Size: 116 bytes --] Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PULL 0/1] Tracing patches @ 2025-03-11 2:53 Stefan Hajnoczi 2025-03-13 7:04 ` Stefan Hajnoczi 0 siblings, 1 reply; 22+ messages in thread From: Stefan Hajnoczi @ 2025-03-11 2:53 UTC (permalink / raw) To: qemu-devel; +Cc: Stefan Hajnoczi, Mads Ynddal The following changes since commit 5136598e2667f35ef3dc1d757616a266bd5eb3a2: Merge tag 'accel-cpus-20250309' of https://github.com/philmd/qemu into staging (2025-03-10 13:40:48 +0800) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to a506a1b16702aae69a43e782f225bdc0ec6545fc: trace/control-target: cleanup headers and make compilation unit common (2025-03-11 10:11:29 +0800) ---------------------------------------------------------------- Pull request A tracing cleanup. ---------------------------------------------------------------- Pierrick Bouvier (1): trace/control-target: cleanup headers and make compilation unit common trace/control-target.c | 2 -- trace/meson.build | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-) -- 2.48.1 ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PULL 0/1] Tracing patches 2025-03-11 2:53 Stefan Hajnoczi @ 2025-03-13 7:04 ` Stefan Hajnoczi 0 siblings, 0 replies; 22+ messages in thread From: Stefan Hajnoczi @ 2025-03-13 7:04 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: qemu-devel, Stefan Hajnoczi, Mads Ynddal [-- Attachment #1: Type: text/plain, Size: 116 bytes --] Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PULL 0/1] Tracing patches @ 2025-02-12 15:05 Stefan Hajnoczi 0 siblings, 0 replies; 22+ messages in thread From: Stefan Hajnoczi @ 2025-02-12 15:05 UTC (permalink / raw) To: qemu-devel; +Cc: Mads Ynddal, Stefan Hajnoczi The following changes since commit f9edf32ea2e18a56de5d92f57e9d10565c822367: Merge tag 'pull-request-2025-02-11' of https://gitlab.com/thuth/qemu into staging (2025-02-11 13:27:32 -0500) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 9976be3911a2d0503f026ae37c17077273bf30ee: scripts: improve error from qemu-trace-stap on missing 'stap' (2025-02-12 10:03:18 -0500) ---------------------------------------------------------------- Pull request ---------------------------------------------------------------- Daniel P. Berrangé (1): scripts: improve error from qemu-trace-stap on missing 'stap' scripts/qemu-trace-stap | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.48.1 ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PULL 0/1] Tracing patches @ 2023-12-27 10:02 Stefan Hajnoczi 0 siblings, 0 replies; 22+ messages in thread From: Stefan Hajnoczi @ 2023-12-27 10:02 UTC (permalink / raw) To: qemu-devel; +Cc: Mads Ynddal, Stefan Hajnoczi The following changes since commit 455f4440687fcee03e62d9b17b28162b638458af: Merge tag 'for_upstream' of https://git.kernel.org/pub/scm/virt/kvm/mst/qemu into staging (2023-12-26 06:07:16 -0500) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 5db052306e69faf9f875ad6dec7c823c140990e0: tracing: install trace events file only if necessary (2023-12-27 05:01:55 -0500) ---------------------------------------------------------------- Pull request ---------------------------------------------------------------- Carlos Santos (1): tracing: install trace events file only if necessary trace/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.43.0 ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PULL 0/1] Tracing patches @ 2023-11-09 7:04 Stefan Hajnoczi 2023-11-10 2:25 ` Stefan Hajnoczi 0 siblings, 1 reply; 22+ messages in thread From: Stefan Hajnoczi @ 2023-11-09 7:04 UTC (permalink / raw) To: qemu-devel; +Cc: Mads Ynddal, Stefan Hajnoczi The following changes since commit a3c3aaa846ad61b801e7196482dcf4afb8ba34e4: Merge tag 'pull-ppc-20231107' of https://gitlab.com/danielhb/qemu into staging (2023-11-08 20:35:00 +0800) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 4d96307c5b4fac40c6ca25f38318b4b65d315de0: tracetool: avoid invalid escape in Python string (2023-11-09 15:03:02 +0800) ---------------------------------------------------------------- Pull request ---------------------------------------------------------------- Marc-André Lureau (1): tracetool: avoid invalid escape in Python string scripts/tracetool/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.41.0 ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PULL 0/1] Tracing patches 2023-11-09 7:04 Stefan Hajnoczi @ 2023-11-10 2:25 ` Stefan Hajnoczi 0 siblings, 0 replies; 22+ messages in thread From: Stefan Hajnoczi @ 2023-11-10 2:25 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: qemu-devel, Mads Ynddal, Stefan Hajnoczi [-- Attachment #1: Type: text/plain, Size: 115 bytes --] Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PULL 0/1] Tracing patches @ 2020-07-07 15:20 Stefan Hajnoczi 2020-07-10 10:29 ` Peter Maydell 0 siblings, 1 reply; 22+ messages in thread From: Stefan Hajnoczi @ 2020-07-07 15:20 UTC (permalink / raw) To: qemu-devel Cc: Peter Maydell, Eduardo Habkost, Gerd Hoffmann, Stefan Hajnoczi, Cleber Rosa, Paolo Bonzini The following changes since commit 7623b5ba017f61de5d7c2bba12c6feb3d55091b1: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging (2020-07-06 11:40:10 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 27e08bab94f7c6ebe0b75938c98c394c969e3fd8: tracetool: work around ust <sys/sdt.h> include conflict (2020-07-07 16:07:14 +0100) ---------------------------------------------------------------- Pull request Fix for a LTTng Userspace Tracer header problem. ---------------------------------------------------------------- Stefan Hajnoczi (1): tracetool: work around ust <sys/sdt.h> include conflict scripts/tracetool/backend/dtrace.py | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.26.2 ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PULL 0/1] Tracing patches 2020-07-07 15:20 Stefan Hajnoczi @ 2020-07-10 10:29 ` Peter Maydell 0 siblings, 0 replies; 22+ messages in thread From: Peter Maydell @ 2020-07-10 10:29 UTC (permalink / raw) To: Stefan Hajnoczi Cc: Paolo Bonzini, Cleber Rosa, QEMU Developers, Eduardo Habkost, Gerd Hoffmann On Tue, 7 Jul 2020 at 16:20, Stefan Hajnoczi <stefanha@redhat.com> wrote: > > The following changes since commit 7623b5ba017f61de5d7c2bba12c6feb3d55091b1: > > Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging (2020-07-06 11:40:10 +0100) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to 27e08bab94f7c6ebe0b75938c98c394c969e3fd8: > > tracetool: work around ust <sys/sdt.h> include conflict (2020-07-07 16:07:14 +0100) > > ---------------------------------------------------------------- > Pull request > > Fix for a LTTng Userspace Tracer header problem. > > ---------------------------------------------------------------- > > Stefan Hajnoczi (1): > tracetool: work around ust <sys/sdt.h> include conflict > > scripts/tracetool/backend/dtrace.py | 6 ++++++ > 1 file changed, 6 insertions(+) Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM ^ permalink raw reply [flat|nested] 22+ messages in thread
* [PULL 0/1] Tracing patches @ 2020-01-14 9:29 Stefan Hajnoczi 2020-01-14 14:11 ` Peter Maydell 0 siblings, 1 reply; 22+ messages in thread From: Stefan Hajnoczi @ 2020-01-14 9:29 UTC (permalink / raw) To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi The following changes since commit dc65a5bdc9fa543690a775b50d4ffbeb22c56d6d: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.0-20200108' into staging (2020-01-10 16:15:04 +0000) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 3f0097169bb60268cc5dda0c5ea47c31ab57b22f: trace: update qemu-trace-stap to Python 3 (2020-01-13 16:42:20 +0000) ---------------------------------------------------------------- Pull request ---------------------------------------------------------------- Stefan Hajnoczi (1): trace: update qemu-trace-stap to Python 3 scripts/qemu-trace-stap | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.24.1 ^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PULL 0/1] Tracing patches 2020-01-14 9:29 Stefan Hajnoczi @ 2020-01-14 14:11 ` Peter Maydell 0 siblings, 0 replies; 22+ messages in thread From: Peter Maydell @ 2020-01-14 14:11 UTC (permalink / raw) To: Stefan Hajnoczi; +Cc: QEMU Developers On Tue, 14 Jan 2020 at 09:29, Stefan Hajnoczi <stefanha@redhat.com> wrote: > > The following changes since commit dc65a5bdc9fa543690a775b50d4ffbeb22c56d6d: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.0-20200108' into staging (2020-01-10 16:15:04 +0000) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to 3f0097169bb60268cc5dda0c5ea47c31ab57b22f: > > trace: update qemu-trace-stap to Python 3 (2020-01-13 16:42:20 +0000) > > ---------------------------------------------------------------- > Pull request > > ---------------------------------------------------------------- Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0 for any user-visible changes. -- PMM ^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2025-07-25 15:26 UTC | newest] Thread overview: 22+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-06-11 18:29 [PULL 0/1] Tracing patches Stefan Hajnoczi 2025-06-11 18:29 ` [PULL 1/1] meson: fix Windows build Stefan Hajnoczi 2025-06-11 19:18 ` BALATON Zoltan 2025-06-11 19:54 ` Stefan Hajnoczi 2025-06-11 22:42 ` BALATON Zoltan 2025-06-12 8:59 ` Peter Maydell -- strict thread matches above, loose matches on Subject: below -- 2025-07-24 14:46 [PULL 0/1] Tracing patches Stefan Hajnoczi 2025-07-25 15:25 ` Stefan Hajnoczi 2025-07-22 15:03 Stefan Hajnoczi 2025-07-21 18:10 Stefan Hajnoczi 2025-06-02 22:29 Stefan Hajnoczi 2025-06-03 15:51 ` Stefan Hajnoczi 2025-03-11 2:53 Stefan Hajnoczi 2025-03-13 7:04 ` Stefan Hajnoczi 2025-02-12 15:05 Stefan Hajnoczi 2023-12-27 10:02 Stefan Hajnoczi 2023-11-09 7:04 Stefan Hajnoczi 2023-11-10 2:25 ` Stefan Hajnoczi 2020-07-07 15:20 Stefan Hajnoczi 2020-07-10 10:29 ` Peter Maydell 2020-01-14 9:29 Stefan Hajnoczi 2020-01-14 14:11 ` Peter Maydell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).