From: Sean Wei <me@sean.taipei>
To: qemu-devel@nongnu.org
Cc: Sean Wei <me@sean.taipei>,
Christian Schoenebeck <qemu_oss@crudebyte.com>,
Greg Kurz <groug@kaod.org>
Subject: [PATCH 0/2] virtio-9p: move G_GNUC_PRINTF to header
Date: Fri, 13 Jun 2025 22:07:40 -0400 [thread overview]
Message-ID: <20250613.qemu.9p@sean.taipei> (raw)
v9fs_string_sprintf() and v9fs_path_sprintf() already have
G_GNUC_PRINTF annotations in their own *.c files, but the
prototypes in the corresponding headers lack them. When another
translation unit includes only the header, -Wformat can no longer
validate the argument list.
This series relocates the annotations to fsdev/9p-marshal.h and
hw/9pfs/9p.h, then drops the now-redundant annotations in
the *.c files. There is no functional change.
I've checked all call sites for these two helper function, all
of them already passes the correct number of arguments.
A minimal PoC (sent as the next mail in the thread) demo how
G_GNUC_PRINTF behaves differently when the attribute is present
only in code.c or code.h file.
--
Sean Wei (3):
fsdev/9p-marshal: move G_GNUC_PRINTF to header
hw/9pfs: move G_GNUC_PRINTF to header
fsdev/9p-marshal.c | 3 +--
fsdev/9p-marshal.h | 2 +-
hw/9pfs/9p.c | 3 +--
hw/9pfs/9p.h | 2 +-
4 files changed, 4 insertions(+), 6 deletions(-)
--
2.49.0
next reply other threads:[~2025-06-14 2:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-14 2:07 Sean Wei [this message]
2025-06-14 2:08 ` [PATCH 1/2] fsdev/9p-marshal: move G_GNUC_PRINTF to header Sean Wei
2025-06-16 5:10 ` Philippe Mathieu-Daudé
2025-06-14 2:09 ` [PATCH 2/2] hw/9pfs: " Sean Wei
2025-06-16 5:10 ` Philippe Mathieu-Daudé
2025-06-14 2:09 ` [PoC] show header-vs-source G_GNUC_PRINTF behavior Sean Wei
2025-06-20 14:17 ` [PATCH 0/2] virtio-9p: move G_GNUC_PRINTF to header Christian Schoenebeck
2025-06-20 15:04 ` Sean Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250613.qemu.9p@sean.taipei \
--to=me@sean.taipei \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).