qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Mario Casquero <mcasquer@redhat.com>,
	Alexey Perevalov <a.perevalov@samsung.com>,
	"Dr . David Alan Gilbert" <dave@treblig.org>,
	peterx@redhat.com, Juraj Marcin <jmarcin@redhat.com>,
	Fabiano Rosas <farosas@suse.de>
Subject: [PATCH v3 05/14] migration/postcopy: Drop PostcopyBlocktimeContext.start_time
Date: Fri, 13 Jun 2025 10:12:08 -0400	[thread overview]
Message-ID: <20250613141217.474825-6-peterx@redhat.com> (raw)
In-Reply-To: <20250613141217.474825-1-peterx@redhat.com>

Now with 64bits, the offseting using start_time is not needed anymore,
because the array can always remember the whole timestamp.

Then drop the unused parameter in get_low_time_offset() altogether.

Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/postcopy-ram.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index ec91821b85..e9acb4ef6e 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -123,7 +123,6 @@ typedef struct PostcopyBlocktimeContext {
     uint64_t last_begin;
     /* number of vCPU are suspended */
     int smp_cpus_down;
-    uint64_t start_time;
 
     /*
      * Handler for exit event, necessary for
@@ -157,7 +156,6 @@ static struct PostcopyBlocktimeContext *blocktime_context_new(void)
     ctx->vcpu_blocktime_total = g_new0(uint64_t, smp_cpus);
     ctx->vcpu_addr = g_new0(uintptr_t, smp_cpus);
     ctx->exit_notifier.notify = migration_exit_cb;
-    ctx->start_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
     qemu_add_exit_notifier(&ctx->exit_notifier);
 
     return ctx;
@@ -818,9 +816,9 @@ static int get_mem_fault_cpu_index(uint32_t pid)
     return -1;
 }
 
-static uint64_t get_low_time_offset(PostcopyBlocktimeContext *dc)
+static uint64_t get_low_time_offset(void)
 {
-    return (uint64_t)qemu_clock_get_ms(QEMU_CLOCK_REALTIME) - dc->start_time;
+    return (uint64_t)qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
 }
 
 /*
@@ -847,7 +845,7 @@ void mark_postcopy_blocktime_begin(uintptr_t addr, uint32_t ptid,
         return;
     }
 
-    low_time_offset = get_low_time_offset(dc);
+    low_time_offset = get_low_time_offset();
     if (dc->vcpu_addr[cpu] == 0) {
         dc->smp_cpus_down++;
     }
@@ -907,7 +905,7 @@ static void mark_postcopy_blocktime_end(uintptr_t addr)
         return;
     }
 
-    low_time_offset = get_low_time_offset(dc);
+    low_time_offset = get_low_time_offset();
     /* lookup cpu, to clear it,
      * that algorithm looks straightforward, but it's not
      * optimal, more optimal algorithm is keeping tree or hash
-- 
2.49.0



  parent reply	other threads:[~2025-06-13 14:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-13 14:12 [PATCH v3 00/14] migration/postcopy: Blocktime tracking overhaul Peter Xu
2025-06-13 14:12 ` [PATCH v3 01/14] migration: Add option to set postcopy-blocktime Peter Xu
2025-06-13 14:12 ` [PATCH v3 02/14] migration/postcopy: Push blocktime start/end into page req mutex Peter Xu
2025-06-13 14:12 ` [PATCH v3 03/14] migration/postcopy: Drop all atomic ops in blocktime feature Peter Xu
2025-06-13 14:12 ` [PATCH v3 04/14] migration/postcopy: Make all blocktime vars 64bits Peter Xu
2025-06-13 14:12 ` Peter Xu [this message]
2025-06-13 14:12 ` [PATCH v3 06/14] migration/postcopy: Bring blocktime layer to ns level Peter Xu
2025-06-13 14:12 ` [PATCH v3 07/14] migration/postcopy: Add blocktime fault counts per-vcpu Peter Xu
2025-06-13 14:12 ` [PATCH v3 08/14] migration/postcopy: Report fault latencies in blocktime Peter Xu
2025-06-13 14:12 ` [PATCH v3 09/14] migration/postcopy: Initialize blocktime context only until listen Peter Xu
2025-06-13 14:12 ` [PATCH v3 10/14] migration/postcopy: Cache the tid->vcpu mapping for blocktime Peter Xu
2025-06-13 14:12 ` [PATCH v3 11/14] migration/postcopy: Cleanup the total blocktime accounting Peter Xu
2025-06-13 14:12 ` [PATCH v3 12/14] migration/postcopy: Optimize blocktime fault tracking with hashtable Peter Xu
2025-06-13 14:12 ` [PATCH v3 13/14] migration/postcopy: blocktime allows track / report non-vCPU faults Peter Xu
2025-06-13 14:12 ` [PATCH v3 14/14] migration/postcopy: Add latency distribution report for blocktime Peter Xu
2025-06-25 13:39 ` [PATCH v3 00/14] migration/postcopy: Blocktime tracking overhaul Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250613141217.474825-6-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=a.perevalov@samsung.com \
    --cc=dave@treblig.org \
    --cc=farosas@suse.de \
    --cc=jmarcin@redhat.com \
    --cc=mcasquer@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).