From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
peter.maydell@linaro.org, imammedo@redhat.com,
gustavo.romero@linaro.org, anisinha@redhat.com, mst@redhat.com,
shannon.zhaosl@gmail.com
Cc: pbonzini@redhat.com, Jonathan.Cameron@huawei.com,
philmd@linaro.org, alex.bennee@linaro.org
Subject: [PATCH v3 07/29] hw/pci-host/gpex-acpi: retrieve and use GED acpi_pcihp setting
Date: Mon, 16 Jun 2025 11:46:36 +0200 [thread overview]
Message-ID: <20250616094903.885753-8-eric.auger@redhat.com> (raw)
In-Reply-To: <20250616094903.885753-1-eric.auger@redhat.com>
retrieve the acpi_pcihp option value from the ged. In
case acpi_pcihp is unset we configure pci native hotplug on
pci0. For expander bridges we keep legacy pci native hotplug,
as done on x86 q35.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
v2 -> v3:
- don'use the virt arm machine option anymore.
---
include/hw/pci-host/gpex.h | 1 +
hw/arm/virt-acpi-build.c | 5 +++++
hw/pci-host/gpex-acpi.c | 3 ++-
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/include/hw/pci-host/gpex.h b/include/hw/pci-host/gpex.h
index 84471533af..feaf827474 100644
--- a/include/hw/pci-host/gpex.h
+++ b/include/hw/pci-host/gpex.h
@@ -45,6 +45,7 @@ struct GPEXConfig {
MemMapEntry pio;
int irq;
PCIBus *bus;
+ bool pci_native_hotplug;
};
typedef struct GPEXIrq GPEXIrq;
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 7e8e0f0298..d7547c8d3b 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -123,12 +123,17 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap,
uint32_t irq, VirtMachineState *vms)
{
int ecam_id = VIRT_ECAM_ID(vms->highmem_ecam);
+ AcpiGedState *acpi_ged_state = ACPI_GED(vms->acpi_dev);
+ AcpiPciHpState *pcihp_state = &acpi_ged_state->pcihp_state;
+
+
struct GPEXConfig cfg = {
.mmio32 = memmap[VIRT_PCIE_MMIO],
.pio = memmap[VIRT_PCIE_PIO],
.ecam = memmap[ecam_id],
.irq = irq,
.bus = vms->bus,
+ .pci_native_hotplug = !pcihp_state->use_acpi_hotplug_bridge,
};
if (vms->highmem_mmio) {
diff --git a/hw/pci-host/gpex-acpi.c b/hw/pci-host/gpex-acpi.c
index 80fc2bf032..44737a8d81 100644
--- a/hw/pci-host/gpex-acpi.c
+++ b/hw/pci-host/gpex-acpi.c
@@ -203,6 +203,7 @@ void acpi_dsdt_add_gpex(Aml *scope, struct GPEXConfig *cfg)
if (is_cxl) {
build_cxl_osc_method(dev);
} else {
+ /* pxb bridges do not have ACPI PCI Hot-plug enabled */
acpi_dsdt_add_host_bridge_methods(dev, true);
}
@@ -278,7 +279,7 @@ void acpi_dsdt_add_gpex(Aml *scope, struct GPEXConfig *cfg)
}
aml_append(dev, aml_name_decl("_CRS", rbuf));
- acpi_dsdt_add_host_bridge_methods(dev, true);
+ acpi_dsdt_add_host_bridge_methods(dev, cfg->pci_native_hotplug);
Aml *dev_res0 = aml_device("%s", "RES0");
aml_append(dev_res0, aml_name_decl("_HID", aml_string("PNP0C02")));
--
2.49.0
next prev parent reply other threads:[~2025-06-16 9:50 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 9:46 [PATCH v3 00/29] ACPI PCI Hotplug support on ARM Eric Auger
2025-06-16 9:46 ` [PATCH v3 01/29] hw/i386/acpi-build: Make aml_pci_device_dsm() static Eric Auger
2025-06-16 9:46 ` [PATCH v3 02/29] hw/acpi/ged: Add a acpi-pci-hotplug-with-bridge-support property Eric Auger
2025-06-20 8:53 ` Jonathan Cameron via
2025-06-20 11:09 ` Igor Mammedov
2025-06-20 11:27 ` Eric Auger
2025-06-16 9:46 ` [PATCH v3 03/29] hw/acpi: Rename and move build_x86_acpi_pci_hotplug to pcihp Eric Auger
2025-06-16 9:46 ` [PATCH v3 04/29] hw/pci-host/gpex-acpi: Add native_pci_hotplug arg to acpi_dsdt_add_pci_osc Eric Auger
2025-06-20 8:45 ` Jonathan Cameron via
2025-06-16 9:46 ` [PATCH v3 05/29] tests/qtest/bios-tables-test: Prepare for changes in the DSDT table Eric Auger
2025-06-20 8:49 ` Jonathan Cameron via
2025-06-20 11:29 ` Eric Auger
2025-06-20 11:11 ` Igor Mammedov
2025-06-16 9:46 ` [PATCH v3 06/29] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation Eric Auger
2025-06-20 8:50 ` Jonathan Cameron via
2025-06-20 11:48 ` Igor Mammedov
2025-06-16 9:46 ` Eric Auger [this message]
2025-06-20 8:52 ` [PATCH v3 07/29] hw/pci-host/gpex-acpi: retrieve and use GED acpi_pcihp setting Jonathan Cameron via
2025-06-20 12:07 ` Igor Mammedov
2025-06-16 9:46 ` [PATCH v3 08/29] hw/i386/acpi-build: Turn build_q35_osc_method into a generic method Eric Auger
2025-06-20 8:54 ` Jonathan Cameron via
2025-06-20 12:11 ` Igor Mammedov
2025-06-16 9:46 ` [PATCH v3 09/29] hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method Eric Auger
2025-06-20 8:57 ` Jonathan Cameron via
2025-06-20 12:16 ` Igor Mammedov
2025-06-16 9:46 ` [PATCH v3 10/29] tests/qtest/bios-tables-test: Update DSDT blobs after GPEX _OSC change Eric Auger
2025-06-20 8:59 ` Jonathan Cameron via
2025-06-20 11:33 ` Eric Auger
2025-06-16 9:46 ` [PATCH v3 11/29] hw/i386/acpi-build: Introduce build_append_pcihp_resources() helper Eric Auger
2025-06-16 9:46 ` [PATCH v3 12/29] hw/acpi/pcihp: Add an AmlRegionSpace arg to build_acpi_pci_hotplug Eric Auger
2025-06-16 9:46 ` [PATCH v3 13/29] hw/i386/acpi-build: Move build_append_notification_callback to pcihp Eric Auger
2025-06-16 9:46 ` [PATCH v3 14/29] hw/i386/acpi-build: Move build_append_pci_bus_devices/pcihp_slots " Eric Auger
2025-06-16 9:46 ` [PATCH v3 15/29] hw/i386/acpi-build: Use AcpiPciHpState::root in acpi_set_pci_info Eric Auger
2025-06-20 9:05 ` Jonathan Cameron via
2025-06-20 12:20 ` Igor Mammedov
2025-06-16 9:46 ` [PATCH v3 16/29] hw/i386/acpi-build: Move aml_pci_edsm to a generic place Eric Auger
2025-06-20 9:19 ` Jonathan Cameron via
2025-06-20 9:28 ` Jonathan Cameron via
2025-06-20 12:27 ` Igor Mammedov
2025-06-24 16:05 ` Eric Auger
2025-06-16 9:46 ` [PATCH v3 17/29] hw/arm/virt-acpi-build: Modify the DSDT ACPI table to enable ACPI PCI hotplug Eric Auger
2025-06-20 9:35 ` Jonathan Cameron via
2025-06-20 12:38 ` Igor Mammedov
2025-06-20 16:13 ` Jonathan Cameron via
2025-06-25 15:23 ` Eric Auger
2025-06-26 8:44 ` Eric Auger
2025-06-24 15:51 ` Eric Auger
2025-06-20 12:33 ` Igor Mammedov
2025-06-16 9:46 ` [PATCH v3 18/29] hw/acpi/ged: Add a bus link property Eric Auger
2025-06-20 9:37 ` Jonathan Cameron via
2025-06-20 12:45 ` Igor Mammedov
2025-06-16 9:46 ` [PATCH v3 19/29] hw/arm/virt: Pass the bus on the ged creation Eric Auger
2025-06-20 9:38 ` Jonathan Cameron via
2025-06-24 15:56 ` Eric Auger
2025-06-16 9:46 ` [PATCH v3 20/29] hw/acpi/ged: Prepare the device to react to PCI hotplug events Eric Auger
2025-06-20 9:44 ` Jonathan Cameron via
2025-06-25 14:31 ` Eric Auger
2025-06-20 12:57 ` Igor Mammedov
2025-06-25 14:21 ` Eric Auger
2025-06-20 13:01 ` Igor Mammedov
2025-06-16 9:46 ` [PATCH v3 21/29] hw/acpi/ged: Call pcihp plug callbacks in hotplug handler implementation Eric Auger
2025-06-20 10:09 ` Jonathan Cameron via
2025-06-20 12:53 ` Igor Mammedov
2025-06-16 9:46 ` [PATCH v3 22/29] hw/acpi/ged: Support migration of AcpiPciHpState Eric Auger
2025-06-16 9:46 ` [PATCH v3 23/29] hw/core/sysbus: Introduce sysbus_mmio_map_name() helper Eric Auger
2025-06-20 10:13 ` Jonathan Cameron via
2025-06-16 9:46 ` [PATCH v3 24/29] hw/arm/virt: Use a SysBusDevice variable in create_acpi_ged() Eric Auger
2025-06-20 10:18 ` Jonathan Cameron via
2025-06-16 9:46 ` [PATCH v3 25/29] hw/arm/virt: Let virt support pci hotplug/unplug GED event Eric Auger
2025-06-20 10:17 ` Jonathan Cameron via
2025-06-25 13:36 ` Eric Auger
2025-06-20 13:06 ` Igor Mammedov
2025-06-25 13:37 ` Eric Auger
2025-06-16 9:46 ` [PATCH v3 26/29] hw/arm/virt: Plug pcihp hotplug/hotunplug callbacks Eric Auger
2025-06-20 10:28 ` Jonathan Cameron via
2025-06-20 13:10 ` Igor Mammedov
2025-06-26 8:16 ` Eric Auger
2025-06-16 9:46 ` [PATCH v3 27/29] tests/qtest/bios-tables-test: Prepare for addition of acpi pci hp tests Eric Auger
2025-06-20 10:31 ` Jonathan Cameron via
2025-06-20 13:11 ` Igor Mammedov
2025-06-23 15:07 ` Eric Auger
2025-06-16 9:46 ` [PATCH v3 28/29] tests/qtest/bios-tables-test: Add aarch64 ACPI PCI hotplug test Eric Auger
2025-06-20 10:40 ` Jonathan Cameron via
2025-06-20 13:22 ` Igor Mammedov
2025-06-26 10:04 ` Eric Auger
2025-06-20 13:18 ` Igor Mammedov
2025-06-16 9:46 ` [PATCH v3 29/29] qtest/bios-tables-test: Create DSDT 'acpipcihp" variant blob Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616094903.885753-8-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alex.bennee@linaro.org \
--cc=anisinha@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=gustavo.romero@linaro.org \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).