qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	kvmarm@lists.linux.dev, peter.maydell@linaro.org,
	richard.henderson@linaro.org, alex.bennee@linaro.org,
	maz@kernel.org, oliver.upton@linux.dev, sebott@redhat.com,
	shameerali.kolothum.thodi@huawei.com, armbru@redhat.com,
	berrange@redhat.com, abologna@redhat.com, jdenemar@redhat.com,
	agraf@csgraf.de
Cc: shahuang@redhat.com, mark.rutland@arm.com, philmd@linaro.org,
	pbonzini@redhat.com, Cornelia Huck <cohuck@redhat.com>
Subject: [PATCH v8 14/14] arm/kvm: use fd instead of fdarray[2]
Date: Tue, 17 Jun 2025 17:39:31 +0200	[thread overview]
Message-ID: <20250617153931.1330449-15-cohuck@redhat.com> (raw)
In-Reply-To: <20250617153931.1330449-1-cohuck@redhat.com>

We have fd, so might as well neaten things up.

Suggested-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 target/arm/kvm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/target/arm/kvm.c b/target/arm/kvm.c
index 3df046b2b911..70919aedd0a4 100644
--- a/target/arm/kvm.c
+++ b/target/arm/kvm.c
@@ -348,11 +348,11 @@ static bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)
         err |= get_host_cpu_reg(fd, ahcf, ID_ISAR6_EL1_IDX);
         err |= get_host_cpu_reg(fd, ahcf, ID_MMFR4_EL1_IDX);
 
-        err |= read_sys_reg32(fdarray[2], &ahcf->isar.mvfr0,
+        err |= read_sys_reg32(fd, &ahcf->isar.mvfr0,
                               ARM64_SYS_REG(3, 0, 0, 3, 0));
-        err |= read_sys_reg32(fdarray[2], &ahcf->isar.mvfr1,
+        err |= read_sys_reg32(fd, &ahcf->isar.mvfr1,
                               ARM64_SYS_REG(3, 0, 0, 3, 1));
-        err |= read_sys_reg32(fdarray[2], &ahcf->isar.mvfr2,
+        err |= read_sys_reg32(fd, &ahcf->isar.mvfr2,
                               ARM64_SYS_REG(3, 0, 0, 3, 2));
         err |= get_host_cpu_reg(fd, ahcf, ID_PFR2_EL1_IDX);
         err |= get_host_cpu_reg(fd, ahcf, ID_DFR1_EL1_IDX);
@@ -390,7 +390,7 @@ static bool kvm_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)
 
         if (pmu_supported) {
             /* PMCR_EL0 is only accessible if the vCPU has feature PMU_V3 */
-            err |= read_sys_reg64(fdarray[2], &ahcf->isar.reset_pmcr_el0,
+            err |= read_sys_reg64(fd, &ahcf->isar.reset_pmcr_el0,
                                   ARM64_SYS_REG(3, 3, 9, 12, 0));
         }
 
-- 
2.49.0



  parent reply	other threads:[~2025-06-17 16:20 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-17 15:39 [PATCH v8 00/14] arm: rework id register storage Cornelia Huck
2025-06-17 15:39 ` [PATCH v8 01/14] arm/cpu: Add sysreg definitions in cpu-sysregs.h Cornelia Huck
2025-06-17 15:39 ` [PATCH v8 02/14] arm/cpu: Store aa64isar0/aa64zfr0 into the idregs arrays Cornelia Huck
2025-06-17 15:39 ` [PATCH v8 03/14] arm/cpu: Store aa64isar1/2 into the idregs array Cornelia Huck
2025-06-17 15:39 ` [PATCH v8 04/14] arm/cpu: Store aa64pfr0/1 " Cornelia Huck
2025-06-17 15:39 ` [PATCH v8 05/14] arm/cpu: Store aa64mmfr0-3 " Cornelia Huck
2025-06-17 15:39 ` [PATCH v8 06/14] arm/cpu: Store aa64dfr0/1 " Cornelia Huck
2025-06-17 15:39 ` [PATCH v8 07/14] arm/cpu: Store aa64smfr0 " Cornelia Huck
2025-06-17 15:39 ` [PATCH v8 08/14] arm/cpu: Store id_isar0-7 " Cornelia Huck
2025-06-17 15:39 ` [PATCH v8 09/14] arm/cpu: Store id_pfr0/1/2 " Cornelia Huck
2025-06-17 15:39 ` [PATCH v8 10/14] arm/cpu: Store id_dfr0/1 " Cornelia Huck
2025-06-17 15:39 ` [PATCH v8 11/14] arm/cpu: Store id_mmfr0-5 " Cornelia Huck
2025-06-17 15:39 ` [PATCH v8 12/14] arm/cpu: Add sysreg generation scripts Cornelia Huck
2025-06-17 15:45   ` Cornelia Huck
2025-06-25  9:16     ` Eric Auger
2025-06-25  9:23       ` Daniel P. Berrangé
2025-06-25  9:31         ` Eric Auger
2025-06-25  9:24       ` Cornelia Huck
2025-06-17 15:39 ` [PATCH v8 13/14] arm/cpu: switch to a generated cpu-sysregs.h.inc Cornelia Huck
2025-06-30 15:23   ` Peter Maydell
2025-07-01 16:06     ` Cornelia Huck
2025-07-01 16:49       ` Peter Maydell
2025-07-02  9:01         ` Cornelia Huck
2025-06-17 15:39 ` Cornelia Huck [this message]
2025-06-25  9:10 ` [PATCH v8 00/14] arm: rework id register storage Eric Auger
2025-06-25 10:14   ` Peter Maydell
2025-06-25 16:37     ` Cornelia Huck
2025-06-30 10:04 ` Cornelia Huck
2025-06-30 15:25 ` Peter Maydell
2025-06-30 16:02   ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250617153931.1330449-15-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=abologna@redhat.com \
    --cc=agraf@csgraf.de \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=eric.auger@redhat.com \
    --cc=jdenemar@redhat.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sebott@redhat.com \
    --cc=shahuang@redhat.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).