From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B7F4C7115B for ; Fri, 20 Jun 2025 08:53:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSXUt-0004Is-Vd; Fri, 20 Jun 2025 04:53:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSXUn-0004I2-Up; Fri, 20 Jun 2025 04:53:13 -0400 Received: from [185.176.79.56] (helo=frasgout.his.huawei.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSXUm-000320-9Y; Fri, 20 Jun 2025 04:53:13 -0400 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4bNrmD1xyxz6L6Gm; Fri, 20 Jun 2025 16:50:52 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 68C131402FE; Fri, 20 Jun 2025 16:53:10 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 20 Jun 2025 10:53:09 +0200 Date: Fri, 20 Jun 2025 09:53:08 +0100 To: Eric Auger CC: , , , , , , , , , , , Subject: Re: [PATCH v3 02/29] hw/acpi/ged: Add a acpi-pci-hotplug-with-bridge-support property Message-ID: <20250620095308.00000d16@huawei.com> In-Reply-To: <20250616094903.885753-3-eric.auger@redhat.com> References: <20250616094903.885753-1-eric.auger@redhat.com> <20250616094903.885753-3-eric.auger@redhat.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To frapeml500008.china.huawei.com (7.182.85.71) X-Host-Lookup-Failed: Reverse DNS lookup failed for 185.176.79.56 (deferred) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, 16 Jun 2025 11:46:31 +0200 Eric Auger wrote: > A new boolean property is introduced. This will be used to turn > ACPI PCI hotplug support. By default it is unset. > > Signed-off-by: Eric Auger I wonder a bit if it makes sense to do this so early rather than just before it is first used in the series? Doesn't really matter though. Just meant I read on a bit before giving an RB on this. Reviewed-by: Jonathan Cameron > --- > include/hw/acpi/generic_event_device.h | 2 ++ > hw/acpi/generic_event_device.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/include/hw/acpi/generic_event_device.h b/include/hw/acpi/generic_event_device.h > index d2dac87b4a..f5ffa67a39 100644 > --- a/include/hw/acpi/generic_event_device.h > +++ b/include/hw/acpi/generic_event_device.h > @@ -63,6 +63,7 @@ > #include "hw/acpi/memory_hotplug.h" > #include "hw/acpi/ghes.h" > #include "hw/acpi/cpu.h" > +#include "hw/acpi/pcihp.h" > #include "qom/object.h" > > #define ACPI_POWER_BUTTON_DEVICE "PWRB" > @@ -114,6 +115,7 @@ struct AcpiGedState { > MemoryRegion container_memhp; > CPUHotplugState cpuhp_state; > MemoryRegion container_cpuhp; > + AcpiPciHpState pcihp_state; > GEDState ged_state; > uint32_t ged_event_bitmap; > qemu_irq irq; > diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c > index 7a62f8d5bc..7831db412b 100644 > --- a/hw/acpi/generic_event_device.c > +++ b/hw/acpi/generic_event_device.c > @@ -318,6 +318,8 @@ static void acpi_ged_send_event(AcpiDeviceIf *adev, AcpiEventStatusBits ev) > > static const Property acpi_ged_properties[] = { > DEFINE_PROP_UINT32("ged-event", AcpiGedState, ged_event_bitmap, 0), > + DEFINE_PROP_BOOL(ACPI_PM_PROP_ACPI_PCIHP_BRIDGE, AcpiGedState, > + pcihp_state.use_acpi_hotplug_bridge, 0), > }; > > static const VMStateDescription vmstate_memhp_state = {