Re: [PATCH v3 20/29] hw/acpi/ged: Prepare the device to react to PCI hotplug events

[Igor Mammedov <imammedo@redhat.com>]

On Mon, 16 Jun 2025 11:46:49 +0200
Eric Auger <eric.auger@redhat.com> wrote:

[...]

> @@ -433,6 +443,12 @@ static void acpi_ged_realize(DeviceState *dev, Error **errp)
>              cpu_hotplug_hw_init(&s->container_cpuhp, OBJECT(dev),
>                                  &s->cpuhp_state, 0);
>              break;
> +        case ACPI_GED_PCI_HOTPLUG_EVT:
> +            memory_region_init(&s->container_pcihp, OBJECT(dev),
> +                               ACPI_PCIHP_REGION_NAME, ACPI_PCIHP_SIZE);
> +            sysbus_init_mmio(sbd, &s->container_pcihp);
> +            acpi_pcihp_init(OBJECT(s), &s->pcihp_state,
> +                            s->pcihp_state.root, &s->container_pcihp, 0);

bus flow looks weird,
I'd suggest to
  * set root bus link on x86 as well for consistency reasons and proper ref accounting
  * and then drop 'bus' from acpi_pcihp_init() its arguments

>          }
>          ged_events--;
>      }
[...]