From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Leif Lindholm" <leif.lindholm@oss.qualcomm.com>,
qemu-arm@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>,
"Roman Bolshakov" <rbolshakov@ddn.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alexander Graf" <agraf@csgraf.de>,
"Bernhard Beschow" <shentey@gmail.com>,
"John Snow" <jsnow@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
kvm@vger.kernel.org, "Eric Auger" <eric.auger@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Cameron Esfahani" <dirty@apple.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Radoslaw Biernacki" <rad@semihalf.com>,
"Phil Dennis-Jordan" <phil@philjordan.eu>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v3 14/26] accel: Keep reference to AccelOpsClass in AccelClass
Date: Mon, 23 Jun 2025 14:18:33 +0200 [thread overview]
Message-ID: <20250623121845.7214-15-philmd@linaro.org> (raw)
In-Reply-To: <20250623121845.7214-1-philmd@linaro.org>
Allow dereferencing AccelOpsClass outside of accel/accel-system.c.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
---
include/qemu/accel.h | 3 +++
include/system/accel-ops.h | 3 ++-
accel/accel-common.c | 1 +
accel/accel-system.c | 3 ++-
accel/tcg/tcg-accel-ops.c | 4 +++-
5 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/include/qemu/accel.h b/include/qemu/accel.h
index fbd3d897fef..9dea3145429 100644
--- a/include/qemu/accel.h
+++ b/include/qemu/accel.h
@@ -37,6 +37,9 @@ typedef struct AccelClass {
/*< public >*/
const char *name;
+ /* Cached by accel_init_ops_interfaces() when created */
+ AccelOpsClass *ops;
+
int (*init_machine)(MachineState *ms);
bool (*cpu_common_realize)(CPUState *cpu, Error **errp);
void (*cpu_common_unrealize)(CPUState *cpu);
diff --git a/include/system/accel-ops.h b/include/system/accel-ops.h
index 4c99d25aeff..44b37592d02 100644
--- a/include/system/accel-ops.h
+++ b/include/system/accel-ops.h
@@ -10,6 +10,7 @@
#ifndef ACCEL_OPS_H
#define ACCEL_OPS_H
+#include "qemu/accel.h"
#include "exec/vaddr.h"
#include "qom/object.h"
@@ -31,7 +32,7 @@ struct AccelOpsClass {
/*< public >*/
/* initialization function called when accel is chosen */
- void (*ops_init)(AccelOpsClass *ops);
+ void (*ops_init)(AccelClass *ac);
bool (*cpus_are_resettable)(void);
void (*cpu_reset_hold)(CPUState *cpu);
diff --git a/accel/accel-common.c b/accel/accel-common.c
index 4894b98d64a..56d88940f92 100644
--- a/accel/accel-common.c
+++ b/accel/accel-common.c
@@ -10,6 +10,7 @@
#include "qemu/osdep.h"
#include "qemu/accel.h"
#include "qemu/target-info.h"
+#include "system/accel-ops.h"
#include "accel/accel-cpu.h"
#include "accel-internal.h"
diff --git a/accel/accel-system.c b/accel/accel-system.c
index a0f562ae9ff..64bc991b1ce 100644
--- a/accel/accel-system.c
+++ b/accel/accel-system.c
@@ -85,8 +85,9 @@ void accel_init_ops_interfaces(AccelClass *ac)
* non-NULL create_vcpu_thread operation.
*/
ops = ACCEL_OPS_CLASS(oc);
+ ac->ops = ops;
if (ops->ops_init) {
- ops->ops_init(ops);
+ ops->ops_init(ac);
}
cpus_register_accel(ops);
}
diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c
index b24d6a75625..da2e22a7dff 100644
--- a/accel/tcg/tcg-accel-ops.c
+++ b/accel/tcg/tcg-accel-ops.c
@@ -198,8 +198,10 @@ static inline void tcg_remove_all_breakpoints(CPUState *cpu)
cpu_watchpoint_remove_all(cpu, BP_GDB);
}
-static void tcg_accel_ops_init(AccelOpsClass *ops)
+static void tcg_accel_ops_init(AccelClass *ac)
{
+ AccelOpsClass *ops = ac->ops;
+
if (qemu_tcg_mttcg_enabled()) {
ops->create_vcpu_thread = mttcg_start_vcpu_thread;
ops->kick_vcpu_thread = mttcg_kick_vcpu_thread;
--
2.49.0
next prev parent reply other threads:[~2025-06-23 12:22 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 12:18 [PATCH v3 00/26] arm: Fixes and preparatory cleanups for split-accel Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 01/26] target/arm: Remove arm_handle_psci_call() stub Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 02/26] target/arm: Reduce arm_cpu_post_init() declaration scope Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 03/26] target/arm: Unify gen_exception_internal() Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 04/26] target/arm/hvf: Simplify GIC hvf_arch_init_vcpu() Philippe Mathieu-Daudé
2025-07-01 9:39 ` Peter Maydell
2025-07-01 10:12 ` Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 05/26] target/arm/hvf: Directly re-lock BQL after hv_vcpu_run() Philippe Mathieu-Daudé
2025-06-25 15:12 ` Pierrick Bouvier
2025-06-23 12:18 ` [PATCH v3 06/26] target/arm/hvf: Trace hv_vcpu_run() failures Philippe Mathieu-Daudé
2025-07-01 9:49 ` Peter Maydell
2025-07-01 10:15 ` Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 07/26] accel/hvf: Trace VM memory mapping Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 08/26] target/arm/hvf: Log $pc in hvf_unknown_hvc() trace event Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 09/26] target/arm: Correct KVM & HVF dtb_compatible value Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 10/26] accel/hvf: Model PhysTimer register Philippe Mathieu-Daudé
2025-06-30 15:31 ` Peter Maydell
2025-06-23 12:18 ` [PATCH v3 11/26] target/arm/hvf: Pass @target_el argument to hvf_raise_exception() Philippe Mathieu-Daudé
2025-07-01 9:53 ` Peter Maydell
2025-06-23 12:18 ` [PATCH v3 12/26] target/arm: Restrict system register properties to system binary Philippe Mathieu-Daudé
2025-07-01 9:55 ` Peter Maydell
2025-07-01 10:17 ` Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 13/26] target/arm: Create GTimers *after* features finalized / accel realized Philippe Mathieu-Daudé
2025-06-23 12:18 ` Philippe Mathieu-Daudé [this message]
2025-06-23 12:18 ` [PATCH v3 15/26] accel: Introduce AccelOpsClass::cpu_target_realize() hook Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 16/26] accel/hvf: Add hvf_arch_cpu_realize() stubs Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 17/26] target/arm/hvf: Really set Generic Timer counter frequency Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 18/26] hw/arm/virt: Only require TCG || QTest to use TrustZone Philippe Mathieu-Daudé
2025-07-01 10:05 ` Peter Maydell
2025-07-01 10:11 ` Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 19/26] hw/arm/virt: Only require TCG || QTest to use virtualization extension Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 20/26] hw/arm/virt: Rename cpu_post_init() -> post_cpus_gic_realized() Philippe Mathieu-Daudé
2025-06-30 15:34 ` Peter Maydell
2025-06-23 12:18 ` [PATCH v3 21/26] hw/arm/sbsa-ref: Tidy up use of RAMLIMIT_GB definition Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 22/26] tests/functional: Set sbsa-ref machine type in each test function Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 23/26] tests/functional: Restrict nested Aarch64 Xen test to TCG Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 24/26] tests/functional: Require TCG to run Aarch64 imx8mp-evk test Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 25/26] tests/functional: Add hvf_available() helper Philippe Mathieu-Daudé
2025-07-01 15:50 ` Peter Maydell
2025-07-01 16:21 ` Peter Maydell
2025-07-01 16:34 ` Philippe Mathieu-Daudé
2025-06-23 12:18 ` [PATCH v3 26/26] tests/functional: Expand Aarch64 SMMU tests to run on HVF accelerator Philippe Mathieu-Daudé
2025-06-23 13:01 ` Thomas Huth
2025-06-23 15:04 ` Alex Bennée
2025-06-23 15:18 ` Philippe Mathieu-Daudé
2025-06-23 16:01 ` Alex Bennée
2025-06-30 10:39 ` [PATCH v3 00/26] arm: Fixes and preparatory cleanups for split-accel Philippe Mathieu-Daudé
2025-07-01 10:16 ` Peter Maydell
2025-07-01 10:18 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250623121845.7214-15-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=agraf@csgraf.de \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=dirty@apple.com \
--cc=eric.auger@redhat.com \
--cc=jsnow@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=leif.lindholm@oss.qualcomm.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=phil@philjordan.eu \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rad@semihalf.com \
--cc=rbolshakov@ddn.com \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).