From: Stefan Hajnoczi <stefanha@redhat.com>
To: Tanish Desai <tanishdesai37@gmail.com>
Cc: qemu-devel@nongnu.org, Mads Ynddal <mads@ynddal.dk>
Subject: Re: [PATCH v2 3/3] tracetool: remove redundant event_get_state checks
Date: Tue, 24 Jun 2025 10:26:19 -0400 [thread overview]
Message-ID: <20250624142619.GA5027@fedora> (raw)
In-Reply-To: <20250620143720.3143-4-tanishdesai37@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 929 bytes --]
On Fri, Jun 20, 2025 at 02:37:20PM +0000, Tanish Desai wrote:
> diff --git a/scripts/tracetool/backend/ftrace.py b/scripts/tracetool/backend/ftrace.py
> index baed2ae61c..2d6d608add 100644
> --- a/scripts/tracetool/backend/ftrace.py
> +++ b/scripts/tracetool/backend/ftrace.py
> @@ -34,18 +34,15 @@ def generate_h(event, group):
> ' char ftrace_buf[MAX_TRACE_STRLEN];',
> ' int unused __attribute__ ((unused));',
> ' int trlen;',
> - ' if (trace_event_get_state(%(event_id)s)) {',
> '#line %(event_lineno)d "%(event_filename)s"',
> ' trlen = snprintf(ftrace_buf, MAX_TRACE_STRLEN,',
> ' "%(name)s " %(fmt)s "\\n" %(argnames)s);',
Please unindent lines now that "if (trace_event_get_state(...)) {" is
gone and deeper indentation is not necessary anymore. There are more
instances below in this patch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-06-24 14:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 14:37 [PATCH v2 0/3] tracetool: cleanup "if(true)" check from trace_foo() Tanish Desai
2025-06-20 14:37 ` [PATCH v2 1/3] tracetool: removed the unused vcpu property Tanish Desai
2025-06-20 16:12 ` Alex Bennée
2025-06-20 16:27 ` Tanish Desai
2025-06-20 14:37 ` [PATCH v2 2/3] tracetool: introduce generate_unconditional Tanish Desai
2025-06-24 14:37 ` Stefan Hajnoczi
2025-06-24 17:37 ` Tanish Desai
2025-06-24 19:03 ` Stefan Hajnoczi
2025-06-25 12:30 ` [PATCH v3] tracetool: generates conitional checks when needed Tanish Desai
2025-06-26 18:43 ` Stefan Hajnoczi
2025-06-26 19:30 ` Tanish Desai
2025-06-20 14:37 ` [PATCH v2 3/3] tracetool: remove redundant event_get_state checks Tanish Desai
2025-06-24 14:26 ` Stefan Hajnoczi [this message]
2025-06-20 14:38 ` [PATCH v2 0/3] tracetool: cleanup "if(true)" check from trace_foo() Tanish Desai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250624142619.GA5027@fedora \
--to=stefanha@redhat.com \
--cc=mads@ynddal.dk \
--cc=qemu-devel@nongnu.org \
--cc=tanishdesai37@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).