[PATCH v2] i386/tdx: Build TDX only for 64-bit target

[PATCH v2] i386/tdx: Build TDX only for 64-bit target

[Xiaoyao Li]

Build errors related to TDX were reported when QEMU built on 32-bit
host[1][2].

Since TDX cannot work on 32-bit host and it's also not worth supporting
TDX with 32-bit QEMU, limit TDX to 64-bit target only.

[1] https://lore.kernel.org/qemu-devel/20250602173101.1052983-1-clg@redhat.com/
[2] https://lore.kernel.org/qemu-devel/b8171c39-6a92-4078-a59a-a63d7452e1e9@kaod.org/

Suggested-by: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
---
 hw/i386/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index eb65bda6e071..14d23e27b580 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -13,7 +13,7 @@ config SGX
 config TDX
     bool
     select X86_FW_OVMF
-    depends on KVM
+    depends on KVM && X86_64
 
 config PC
     bool
-- 
2.43.0

Re: [PATCH v2] i386/tdx: Build TDX only for 64-bit target

[Cédric Le Goater]

On 6/25/25 09:33, Xiaoyao Li wrote:
> Build errors related to TDX were reported when QEMU built on 32-bit
> host[1][2].
> 
> Since TDX cannot work on 32-bit host and it's also not worth supporting
> TDX with 32-bit QEMU, limit TDX to 64-bit target only.
> 
> [1] https://lore.kernel.org/qemu-devel/20250602173101.1052983-1-clg@redhat.com/
> [2] https://lore.kernel.org/qemu-devel/b8171c39-6a92-4078-a59a-a63d7452e1e9@kaod.org/
> 
> Suggested-by: Cédric Le Goater <clg@redhat.com>
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
>   hw/i386/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index eb65bda6e071..14d23e27b580 100644
> --- a/hw/i386/Kconfig
> +++ b/hw/i386/Kconfig
> @@ -13,7 +13,7 @@ config SGX
>   config TDX
>       bool
>       select X86_FW_OVMF
> -    depends on KVM
> +    depends on KVM && X86_64
>   
>   config PC
>       bool


Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.

Re: [PATCH v2] i386/tdx: Build TDX only for 64-bit target

[Zhao Liu]

On Wed, Jun 25, 2025 at 03:33:10PM +0800, Xiaoyao Li wrote:
> Date: Wed, 25 Jun 2025 15:33:10 +0800
> From: Xiaoyao Li <xiaoyao.li@intel.com>
> Subject: [PATCH v2] i386/tdx: Build TDX only for 64-bit target
> X-Mailer: git-send-email 2.43.0
> 
> Build errors related to TDX were reported when QEMU built on 32-bit
> host[1][2].
> 
> Since TDX cannot work on 32-bit host and it's also not worth supporting
> TDX with 32-bit QEMU, limit TDX to 64-bit target only.
> 
> [1] https://lore.kernel.org/qemu-devel/20250602173101.1052983-1-clg@redhat.com/
> [2] https://lore.kernel.org/qemu-devel/b8171c39-6a92-4078-a59a-a63d7452e1e9@kaod.org/
> 
> Suggested-by: Cédric Le Goater <clg@redhat.com>
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
>  hw/i386/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

Re: [PATCH v2] i386/tdx: Build TDX only for 64-bit target

[Cédric Le Goater]

On 6/25/25 09:33, Xiaoyao Li wrote:
> Build errors related to TDX were reported when QEMU built on 32-bit
> host[1][2].
> 
> Since TDX cannot work on 32-bit host and it's also not worth supporting
> TDX with 32-bit QEMU, limit TDX to 64-bit target only.
> 
> [1] https://lore.kernel.org/qemu-devel/20250602173101.1052983-1-clg@redhat.com/
> [2] https://lore.kernel.org/qemu-devel/b8171c39-6a92-4078-a59a-a63d7452e1e9@kaod.org/
> 
> Suggested-by: Cédric Le Goater <clg@redhat.com>
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
>   hw/i386/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index eb65bda6e071..14d23e27b580 100644
> --- a/hw/i386/Kconfig
> +++ b/hw/i386/Kconfig
> @@ -13,7 +13,7 @@ config SGX
>   config TDX
>       bool
>       select X86_FW_OVMF
> -    depends on KVM
> +    depends on KVM && X86_64
>   
>   config PC
>       bool


I will take this change through the vfio queue if no one objects.


Thanks,

C.

Re: [PATCH v2] i386/tdx: Build TDX only for 64-bit target

[Paolo Bonzini]

Queued, thanks.

Paolo