qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Levon <john.levon@nutanix.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Cédric Le Goater" <clg@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"John Levon" <john.levon@nutanix.com>,
	"Thanos Makatos" <thanos.makatos@nutanix.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"John Johnson" <john.g.johnson@oracle.com>,
	"Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
	"Jagannathan Raman" <jag.raman@oracle.com>
Subject: [PATCH v5 07/19] vfio-user: implement VFIO_USER_REGION_READ/WRITE
Date: Wed, 25 Jun 2025 20:29:59 +0100	[thread overview]
Message-ID: <20250625193012.2316242-8-john.levon@nutanix.com> (raw)
In-Reply-To: <20250625193012.2316242-1-john.levon@nutanix.com>

Originally-by: John Johnson <john.g.johnson@oracle.com>
Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
Signed-off-by: John Levon <john.levon@nutanix.com>
---
 hw/vfio-user/protocol.h   | 12 ++++++
 hw/vfio-user/device.c     | 79 +++++++++++++++++++++++++++++++++++++++
 hw/vfio-user/trace-events |  1 +
 3 files changed, 92 insertions(+)

diff --git a/hw/vfio-user/protocol.h b/hw/vfio-user/protocol.h
index db88f5fcb1..0cd32ad71a 100644
--- a/hw/vfio-user/protocol.h
+++ b/hw/vfio-user/protocol.h
@@ -138,4 +138,16 @@ typedef struct {
     uint64_t offset;
 } VFIOUserRegionInfo;
 
+/*
+ * VFIO_USER_REGION_READ
+ * VFIO_USER_REGION_WRITE
+ */
+typedef struct {
+    VFIOUserHdr hdr;
+    uint64_t offset;
+    uint32_t region;
+    uint32_t count;
+    char data[];
+} VFIOUserRegionRW;
+
 #endif /* VFIO_USER_PROTOCOL_H */
diff --git a/hw/vfio-user/device.c b/hw/vfio-user/device.c
index d90232a08f..4ef6a2d850 100644
--- a/hw/vfio-user/device.c
+++ b/hw/vfio-user/device.c
@@ -121,9 +121,88 @@ static int vfio_user_device_io_get_region_info(VFIODevice *vbasedev,
     return 0;
 }
 
+static int vfio_user_device_io_region_read(VFIODevice *vbasedev, uint8_t index,
+                                           off_t off, uint32_t count,
+                                           void *data)
+{
+    g_autofree VFIOUserRegionRW *msgp = NULL;
+    VFIOUserProxy *proxy = vbasedev->proxy;
+    int size = sizeof(*msgp) + count;
+    Error *local_err = NULL;
+
+    if (count > proxy->max_xfer_size) {
+        return -EINVAL;
+    }
+
+    msgp = g_malloc0(size);
+    vfio_user_request_msg(&msgp->hdr, VFIO_USER_REGION_READ, sizeof(*msgp), 0);
+    msgp->offset = off;
+    msgp->region = index;
+    msgp->count = count;
+    trace_vfio_user_region_rw(msgp->region, msgp->offset, msgp->count);
+
+    if (!vfio_user_send_wait(proxy, &msgp->hdr, NULL, size, &local_err)) {
+        error_prepend(&local_err, "%s: ", __func__);
+        error_report_err(local_err);
+        return -EFAULT;
+    }
+
+    if (msgp->hdr.flags & VFIO_USER_ERROR) {
+        return -msgp->hdr.error_reply;
+    } else if (msgp->count > count) {
+        return -E2BIG;
+    } else {
+        memcpy(data, &msgp->data, msgp->count);
+    }
+
+    return msgp->count;
+}
+
+static int vfio_user_device_io_region_write(VFIODevice *vbasedev, uint8_t index,
+                                            off_t off, unsigned count,
+                                            void *data, bool post)
+{
+    g_autofree VFIOUserRegionRW *msgp = NULL;
+    VFIOUserProxy *proxy = vbasedev->proxy;
+    int size = sizeof(*msgp) + count;
+    Error *local_err = NULL;
+    int ret;
+
+    if (count > proxy->max_xfer_size) {
+        return -EINVAL;
+    }
+
+    msgp = g_malloc0(size);
+    vfio_user_request_msg(&msgp->hdr, VFIO_USER_REGION_WRITE, size, 0);
+    msgp->offset = off;
+    msgp->region = index;
+    msgp->count = count;
+    memcpy(&msgp->data, data, count);
+    trace_vfio_user_region_rw(msgp->region, msgp->offset, msgp->count);
+
+    /* Ignore post: all writes are synchronous/non-posted. */
+
+    if (!vfio_user_send_wait(proxy, &msgp->hdr, NULL, 0, &local_err)) {
+        error_prepend(&local_err, "%s: ", __func__);
+        error_report_err(local_err);
+        return -EFAULT;
+    }
+
+    if (msgp->hdr.flags & VFIO_USER_ERROR) {
+        ret = -msgp->hdr.error_reply;
+    } else {
+        ret = count;
+    }
+
+    return ret;
+}
+
 /*
  * Socket-based io_ops
  */
 VFIODeviceIOOps vfio_user_device_io_ops_sock = {
     .get_region_info = vfio_user_device_io_get_region_info,
+    .region_read = vfio_user_device_io_region_read,
+    .region_write = vfio_user_device_io_region_write,
+
 };
diff --git a/hw/vfio-user/trace-events b/hw/vfio-user/trace-events
index ef3f14c74d..733313cd1f 100644
--- a/hw/vfio-user/trace-events
+++ b/hw/vfio-user/trace-events
@@ -10,3 +10,4 @@ vfio_user_send_write(uint16_t id, int wrote) " id 0x%x wrote 0x%x"
 vfio_user_version(uint16_t major, uint16_t minor, const char *caps) " major %d minor %d caps: %s"
 vfio_user_get_info(uint32_t nregions, uint32_t nirqs) " #regions %d #irqs %d"
 vfio_user_get_region_info(uint32_t index, uint32_t flags, uint64_t size) " index %d flags 0x%x size 0x%"PRIx64
+vfio_user_region_rw(uint32_t region, uint64_t off, uint32_t count) " region %d offset 0x%"PRIx64" count %d"
-- 
2.43.0



  parent reply	other threads:[~2025-06-25 19:31 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-25 19:29 [PATCH v5 00/19] vfio-user client John Levon
2025-06-25 19:29 ` [PATCH v5 01/19] vfio-user: add vfio-user class and container John Levon
2025-06-26  6:32   ` Cédric Le Goater
2025-07-02  9:40   ` Cédric Le Goater
2025-06-25 19:29 ` [PATCH v5 02/19] vfio-user: connect vfio proxy to remote server John Levon
2025-06-26  6:32   ` Cédric Le Goater
2025-06-25 19:29 ` [PATCH v5 03/19] vfio-user: implement message receive infrastructure John Levon
2025-06-26  6:34   ` Cédric Le Goater
2025-06-25 19:29 ` [PATCH v5 04/19] vfio-user: implement message send infrastructure John Levon
2025-06-26  6:35   ` Cédric Le Goater
2025-06-25 19:29 ` [PATCH v5 05/19] vfio-user: implement VFIO_USER_DEVICE_GET_INFO John Levon
2025-06-26  6:35   ` Cédric Le Goater
2025-06-25 19:29 ` [PATCH v5 06/19] vfio-user: implement VFIO_USER_DEVICE_GET_REGION_INFO John Levon
2025-06-26  6:35   ` Cédric Le Goater
2025-06-25 19:29 ` John Levon [this message]
2025-06-26  6:37   ` [PATCH v5 07/19] vfio-user: implement VFIO_USER_REGION_READ/WRITE Cédric Le Goater
2025-06-25 19:30 ` [PATCH v5 08/19] vfio-user: set up PCI in vfio_user_pci_realize() John Levon
2025-06-26  6:37   ` Cédric Le Goater
2025-06-25 19:30 ` [PATCH v5 09/19] vfio-user: implement VFIO_USER_DEVICE_GET/SET_IRQ* John Levon
2025-06-26  6:38   ` Cédric Le Goater
2025-06-25 19:30 ` [PATCH v5 10/19] vfio-user: forward MSI-X PBA BAR accesses to server John Levon
2025-06-26  6:40   ` Cédric Le Goater
2025-06-25 19:30 ` [PATCH v5 11/19] vfio-user: set up container access to the proxy John Levon
2025-06-26  6:40   ` Cédric Le Goater
2025-06-25 19:30 ` [PATCH v5 12/19] vfio-user: implement VFIO_USER_DEVICE_RESET John Levon
2025-06-26  6:41   ` Cédric Le Goater
2025-06-25 19:30 ` [PATCH v5 13/19] vfio-user: implement VFIO_USER_DMA_MAP/UNMAP John Levon
2025-06-26  6:41   ` Cédric Le Goater
2025-06-25 19:30 ` [PATCH v5 14/19] vfio-user: implement VFIO_USER_DMA_READ/WRITE John Levon
2025-06-26  6:41   ` Cédric Le Goater
2025-06-25 19:30 ` [PATCH v5 15/19] vfio-user: add 'x-msg-timeout' option John Levon
2025-06-26  6:41   ` Cédric Le Goater
2025-06-25 19:30 ` [PATCH v5 16/19] vfio-user: support posted writes John Levon
2025-06-26  6:41   ` Cédric Le Goater
2025-06-25 19:30 ` [PATCH v5 17/19] vfio-user: add coalesced " John Levon
2025-06-26  6:41   ` Cédric Le Goater
2025-06-25 19:30 ` [PATCH v5 18/19] docs: add vfio-user documentation John Levon
2025-06-26  6:42   ` Cédric Le Goater
2025-06-25 19:30 ` [PATCH v5 19/19] vfio-user: introduce vfio-user protocol specification John Levon
2025-06-26  6:42   ` Cédric Le Goater
2025-06-26  7:12 ` [PATCH v5 00/19] vfio-user client Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250625193012.2316242-8-john.levon@nutanix.com \
    --to=john.levon@nutanix.com \
    --cc=alex.williamson@redhat.com \
    --cc=berrange@redhat.com \
    --cc=clg@redhat.com \
    --cc=elena.ufimtseva@oracle.com \
    --cc=jag.raman@oracle.com \
    --cc=john.g.johnson@oracle.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thanos.makatos@nutanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).