qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	peter.maydell@linaro.org, imammedo@redhat.com,
	gustavo.romero@linaro.org, anisinha@redhat.com, mst@redhat.com,
	shannon.zhaosl@gmail.com
Cc: pbonzini@redhat.com, Jonathan.Cameron@huawei.com,
	philmd@linaro.org, alex.bennee@linaro.org
Subject: [PATCH v4 03/32] hw/pci-host/gpex-acpi: Add native_pci_hotplug arg to acpi_dsdt_add_pci_osc
Date: Fri, 27 Jun 2025 11:54:52 +0200	[thread overview]
Message-ID: <20250627095620.3300028-4-eric.auger@redhat.com> (raw)
In-Reply-To: <20250627095620.3300028-1-eric.auger@redhat.com>

Add a new argument to acpi_dsdt_add_pci_osc to be able to disable
native pci hotplug.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Gustavo Romero <gustavo.romero@linaro.org>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

---

rfc -> v1:
- updated the "Allow OS control for all 5 features" comment
---
 hw/pci-host/gpex-acpi.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/hw/pci-host/gpex-acpi.c b/hw/pci-host/gpex-acpi.c
index 0aba47c71c..f34b7cf25e 100644
--- a/hw/pci-host/gpex-acpi.c
+++ b/hw/pci-host/gpex-acpi.c
@@ -50,7 +50,7 @@ static void acpi_dsdt_add_pci_route_table(Aml *dev, uint32_t irq,
     }
 }
 
-static void acpi_dsdt_add_pci_osc(Aml *dev)
+static void acpi_dsdt_add_pci_osc(Aml *dev, bool enable_native_pcie_hotplug)
 {
     Aml *method, *UUID, *ifctx, *ifctx1, *elsectx, *buf;
 
@@ -77,11 +77,12 @@ static void acpi_dsdt_add_pci_osc(Aml *dev)
     aml_append(ifctx, aml_store(aml_name("CDW3"), aml_name("CTRL")));
 
     /*
-     * Allow OS control for all 5 features:
-     * PCIeHotplug SHPCHotplug PME AER PCIeCapability.
+     * Allow OS control for SHPCHotplug, PME, AER, PCIeCapability,
+     * and PCIeHotplug depending on enable_native_pcie_hotplug
      */
-    aml_append(ifctx, aml_and(aml_name("CTRL"), aml_int(0x1F),
-                              aml_name("CTRL")));
+    aml_append(ifctx, aml_and(aml_name("CTRL"),
+               aml_int(0x1E | (enable_native_pcie_hotplug ? 0x1 : 0x0)),
+               aml_name("CTRL")));
 
     ifctx1 = aml_if(aml_lnot(aml_equal(aml_arg(1), aml_int(0x1))));
     aml_append(ifctx1, aml_or(aml_name("CDW1"), aml_int(0x08),
@@ -192,7 +193,7 @@ void acpi_dsdt_add_gpex(Aml *scope, struct GPEXConfig *cfg)
             if (is_cxl) {
                 build_cxl_osc_method(dev);
             } else {
-                acpi_dsdt_add_pci_osc(dev);
+                acpi_dsdt_add_pci_osc(dev, true);
             }
 
             aml_append(scope, dev);
@@ -267,7 +268,7 @@ void acpi_dsdt_add_gpex(Aml *scope, struct GPEXConfig *cfg)
     }
     aml_append(dev, aml_name_decl("_CRS", rbuf));
 
-    acpi_dsdt_add_pci_osc(dev);
+    acpi_dsdt_add_pci_osc(dev, true);
 
     Aml *dev_res0 = aml_device("%s", "RES0");
     aml_append(dev_res0, aml_name_decl("_HID", aml_string("PNP0C02")));
-- 
2.49.0



  parent reply	other threads:[~2025-06-27  9:59 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27  9:54 [PATCH v4 00/32] ACPI PCI Hotplug support on ARM Eric Auger
2025-06-27  9:54 ` [PATCH v4 01/32] hw/i386/acpi-build: Make aml_pci_device_dsm() static Eric Auger
2025-06-27  9:54 ` [PATCH v4 02/32] hw/acpi: Rename and move build_x86_acpi_pci_hotplug to pcihp Eric Auger
2025-06-27  9:54 ` Eric Auger [this message]
2025-06-27  9:54 ` [PATCH v4 04/32] tests/qtest/bios-tables-test: Prepare for changes in the DSDT table Eric Auger
2025-06-27  9:54 ` [PATCH v4 05/32] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation Eric Auger
2025-06-27  9:54 ` [PATCH v4 06/32] hw/acpi/ged: Add a acpi-pci-hotplug-with-bridge-support property Eric Auger
2025-06-27  9:54 ` [PATCH v4 07/32] hw/pci-host/gpex-acpi: Use GED acpi pcihp property Eric Auger
2025-06-30 11:33   ` Jonathan Cameron via
2025-06-27  9:54 ` [PATCH v4 08/32] hw/i386/acpi-build: Turn build_q35_osc_method into a generic method Eric Auger
2025-06-27  9:54 ` [PATCH v4 09/32] hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method Eric Auger
2025-06-30 11:35   ` Jonathan Cameron via
2025-06-27  9:54 ` [PATCH v4 10/32] tests/qtest/bios-tables-test: Update DSDT blobs after GPEX _OSC change Eric Auger
2025-06-30 11:35   ` Jonathan Cameron via
2025-06-27  9:55 ` [PATCH v4 11/32] hw/i386/acpi-build: Introduce build_append_pcihp_resources() helper Eric Auger
2025-06-27  9:55 ` [PATCH v4 12/32] hw/acpi/pcihp: Add an AmlRegionSpace arg to build_acpi_pci_hotplug Eric Auger
2025-06-27  9:55 ` [PATCH v4 13/32] hw/i386/acpi-build: Move build_append_notification_callback to pcihp Eric Auger
2025-06-27  9:55 ` [PATCH v4 14/32] hw/i386/acpi-build: Move build_append_pci_bus_devices/pcihp_slots " Eric Auger
2025-06-27  9:55 ` [PATCH v4 15/32] hw/i386/acpi-build: Use AcpiPciHpState::root in acpi_set_pci_info Eric Auger
2025-06-27  9:55 ` [PATCH v4 16/32] hw/i386/acpi-build: Move aml_pci_edsm to a generic place Eric Auger
2025-06-30 12:25   ` Jonathan Cameron via
2025-06-27  9:55 ` [PATCH v4 17/32] tests/qtest/bios-tables-test: Prepare for changes in the arm virt DSDT table Eric Auger
2025-06-30 12:26   ` Jonathan Cameron via
2025-06-27  9:55 ` [PATCH v4 18/32] hw/arm/virt-acpi-build: Let non hotplug ports support static acpi-index Eric Auger
2025-06-30 12:28   ` Jonathan Cameron via
2025-06-27  9:55 ` [PATCH v4 19/32] tests/qtest/bios-tables-test: Update ARM DSDT reference blobs Eric Auger
2025-06-27 10:00   ` Eric Auger
2025-06-30 12:31     ` Jonathan Cameron via
2025-07-01  9:22       ` Eric Auger
2025-07-03  5:12       ` Eric Auger
2025-06-27  9:55 ` [PATCH v4 20/32] hw/arm/virt-acpi-build: Modify the DSDT ACPI table to enable ACPI PCI hotplug Eric Auger
2025-06-30 12:33   ` Jonathan Cameron via
2025-06-27  9:55 ` [PATCH v4 21/32] hw/acpi/ged: Add a bus link property Eric Auger
2025-06-27  9:55 ` [PATCH v4 22/32] hw/arm/virt: Pass the bus on the ged creation Eric Auger
2025-06-27  9:55 ` [PATCH v4 23/32] hw/acpi/ged: Call pcihp plug callbacks in hotplug handler implementation Eric Auger
2025-06-27  9:55 ` [PATCH v4 24/32] hw/acpi/pcihp: Remove root arg in acpi_pcihp_init Eric Auger
2025-06-30 12:37   ` Jonathan Cameron via
2025-06-27  9:55 ` [PATCH v4 25/32] hw/acpi/ged: Prepare the device to react to PCI hotplug events Eric Auger
2025-06-30 12:49   ` Jonathan Cameron via
2025-07-01  9:27     ` Eric Auger
2025-06-27  9:55 ` [PATCH v4 26/32] hw/acpi/ged: Support migration of AcpiPciHpState Eric Auger
2025-06-30 12:50   ` Jonathan Cameron via
2025-06-27  9:55 ` [PATCH v4 27/32] hw/core/sysbus: Introduce sysbus_mmio_map_name() helper Eric Auger
2025-06-27  9:55 ` [PATCH v4 28/32] hw/arm/virt: Minor code reshuffling in create_acpi_ged Eric Auger
2025-06-30 12:51   ` Jonathan Cameron via
2025-06-27  9:55 ` [PATCH v4 29/32] hw/arm/virt: Let virt support pci hotplug/unplug GED event Eric Auger
2025-06-30 12:53   ` Jonathan Cameron via
2025-07-01  9:28     ` Eric Auger
2025-06-27  9:55 ` [PATCH v4 30/32] tests/qtest/bios-tables-test: Prepare for addition of acpi pci hp tests Eric Auger
2025-06-30 12:53   ` Jonathan Cameron via
2025-06-27  9:55 ` [PATCH v4 31/32] tests/qtest/bios-tables-test: Add aarch64 ACPI PCI hotplug test Eric Auger
2025-06-30 12:55   ` Jonathan Cameron via
2025-06-27  9:55 ` [PATCH v4 32/32] qtest/bios-tables-test: Create DSDT acpipcihp and hpoffacpiindex variant blobs Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250627095620.3300028-4-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alex.bennee@linaro.org \
    --cc=anisinha@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=gustavo.romero@linaro.org \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shannon.zhaosl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).