qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gustavo Romero <gustavo.romero@linaro.org>
To: qemu-devel@nongnu.org, eric.auger@redhat.com, philmd@linaro.org,
	mst@redhat.com
Cc: qemu-arm@nongnu.org, alex.bennee@linaro.org,
	gustavo.romero@linaro.org, udo@hypervisor.org,
	ajones@ventanamicro.com, peter.maydell@linaro.org,
	imammedo@redhat.com, anisinha@redhat.com
Subject: [PATCH v6 2/9] hw/arm/virt: Simplify logic for setting instance's 'tcg_its' variable
Date: Sat, 28 Jun 2025 19:57:15 +0000	[thread overview]
Message-ID: <20250628195722.977078-3-gustavo.romero@linaro.org> (raw)
In-Reply-To: <20250628195722.977078-1-gustavo.romero@linaro.org>

Because 'tcg_its' in the machine instance is set based on the machine
class’s negated variable 'no_tcg_its', 'tcg_its' is the opposite of
'no_tcg_its' and hence the code in question can be simplified as:
tcg_its = !no_tcg_its.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
---
 hw/arm/virt.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 99fde5836c..6d9256a525 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -3342,12 +3342,8 @@ static void virt_instance_init(Object *obj)
 
     /* Default allows ITS instantiation */
     vms->its = true;
-
-    if (vmc->no_tcg_its) {
-        vms->tcg_its = false;
-    } else {
-        vms->tcg_its = true;
-    }
+    /* Allow ITS emulation if the machine version supports it */
+    vms->tcg_its = !vmc->no_tcg_its;
 
     /* Default disallows iommu instantiation */
     vms->iommu = VIRT_IOMMU_NONE;
-- 
2.34.1



  parent reply	other threads:[~2025-06-28 20:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-28 19:57 [PATCH-for-10.1 v6 0/9] hw/arm: GIC 'its=off' ACPI table fixes Gustavo Romero
2025-06-28 19:57 ` [PATCH v6 1/9] hw/intc/gicv3_its: Do not check its_class_name() Gustavo Romero
2025-06-28 19:57 ` Gustavo Romero [this message]
2025-06-28 19:57 ` [PATCH v6 3/9] hw/arm/virt: Simplify create_its() Gustavo Romero
2025-06-28 19:57 ` [PATCH v6 4/9] hw/arm/virt-acpi-build: Improve comment in build_iort Gustavo Romero
2025-06-28 19:57 ` [PATCH v6 5/9] hw/arm/virt-acpi-build: Factor out create_its_idmaps Gustavo Romero
2025-06-28 19:57 ` [PATCH v6 6/9] qtest/bios-tables-test: Add test for when ITS is off on aarch64 Gustavo Romero
2025-06-28 19:57 ` [PATCH v6 7/9] qtest/bios-tables-test: Add blobs for its=off test " Gustavo Romero
2025-06-28 19:57 ` [PATCH v6 8/9] hw/arm/virt-acpi-build: Fix ACPI IORT and MADT tables when its=off Gustavo Romero
2025-07-02  8:34   ` Shameerali Kolothum Thodi via
2025-07-03  8:53     ` Shameerali Kolothum Thodi via
2025-06-28 19:57 ` [PATCH v6 9/9] qtest/bios-tables-test: Update blobs for its=off test on aarch64 Gustavo Romero
2025-06-30 16:16 ` [PATCH-for-10.1 v6 0/9] hw/arm: GIC 'its=off' ACPI table fixes Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250628195722.977078-3-gustavo.romero@linaro.org \
    --to=gustavo.romero@linaro.org \
    --cc=ajones@ventanamicro.com \
    --cc=alex.bennee@linaro.org \
    --cc=anisinha@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=udo@hypervisor.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).