qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	miguel.luis@oracle.com, peter.maydell@linaro.org,
	richard.henderson@linaro.org, maz@kernel.org,
	gkulkarni@amperecomputing.com,
	gankulkarni@os.amperecomputing.com
Cc: hi@alyssa.is
Subject: [PATCH v9 4/5] hw/arm/arm_gicv3_kvm: Add a migration blocker with kvm nested virt
Date: Mon,  7 Jul 2025 18:40:30 +0200	[thread overview]
Message-ID: <20250707164129.1167837-5-eric.auger@redhat.com> (raw)
In-Reply-To: <20250707164129.1167837-1-eric.auger@redhat.com>

We may be miss some NV related GIC register save/restore. Until
we complete the study, let's add a migration blocker when the
maintenance IRQ is set.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/intc/arm_gicv3_kvm.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c
index b30aac7aee..fccb3886bf 100644
--- a/hw/intc/arm_gicv3_kvm.c
+++ b/hw/intc/arm_gicv3_kvm.c
@@ -827,8 +827,16 @@ static void kvm_arm_gicv3_realize(DeviceState *dev, Error **errp)
     }
 
     if (s->maint_irq) {
+        Error *kvm_nv_migration_blocker = NULL;
         int ret;
 
+        error_setg(&kvm_nv_migration_blocker,
+                       "Live migration disabled due to KVM nested virt enabled");
+        if (migrate_add_blocker(&kvm_nv_migration_blocker, errp)) {
+            error_free(kvm_nv_migration_blocker);
+            return;
+        }
+
         ret = kvm_device_check_attr(s->dev_fd,
                                     KVM_DEV_ARM_VGIC_GRP_MAINT_IRQ, 0);
         if (!ret) {
-- 
2.49.0



  parent reply	other threads:[~2025-07-07 16:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07 16:40 [PATCH v9 0/5] ARM Nested Virt Support Eric Auger
2025-07-07 16:40 ` [PATCH v9 1/5] hw/arm: Allow setting KVM vGIC maintenance IRQ Eric Auger
2025-07-07 16:40 ` [PATCH v9 2/5] target/arm/kvm: Add helper to detect EL2 when using KVM Eric Auger
2025-07-07 16:40 ` [PATCH v9 3/5] target/arm: Enable feature ARM_FEATURE_EL2 if EL2 is supported Eric Auger
2025-07-07 16:40 ` Eric Auger [this message]
2025-07-10 14:04   ` [PATCH v9 4/5] hw/arm/arm_gicv3_kvm: Add a migration blocker with kvm nested virt Philippe Mathieu-Daudé
2025-07-10 14:10     ` Eric Auger
2025-07-10 15:18       ` Philippe Mathieu-Daudé
2025-07-10 15:18       ` Peter Maydell
2025-07-07 16:40 ` [PATCH v9 5/5] hw/arm/virt: Allow virt extensions with KVM Eric Auger
2025-07-10 10:42 ` [PATCH v9 0/5] ARM Nested Virt Support Peter Maydell
2025-07-10 12:38   ` Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250707164129.1167837-5-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=gankulkarni@os.amperecomputing.com \
    --cc=gkulkarni@amperecomputing.com \
    --cc=hi@alyssa.is \
    --cc=maz@kernel.org \
    --cc=miguel.luis@oracle.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).